Bug 124495 - Outline view: slides are not deleted after undo
Summary: Outline view: slides are not deleted after undo
Status: NEW
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Impress (show other bugs)
Version:
(earliest affected)
3.6.0.4 release
Hardware: All All
: medium minor
Assignee: Not Assigned
URL:
Whiteboard:
Keywords: bibisected, regression
Depends on:
Blocks: Impress-Outline-View Undo-Redo
  Show dependency treegraph
 
Reported: 2019-04-02 10:41 UTC by Xisco Faulí
Modified: 2022-06-02 17:53 UTC (History)
4 users (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Xisco Faulí 2019-04-02 10:41:28 UTC
Steps to reproduce:
1. Open Impress
2. Go to Outline tab ( View - View tab bar )
3. Write text and use enter key to create new slides
4. Undo

Observed behaviour -> Text is removed in outline view but the slides are not deleted. Switching to Normal tab and back to Outline tab show the text again.

reproduced in

Version: 6.3.0.0.alpha0+
Build ID: 5f04be8d385f100d0775549cbdd7295cec1d1423
CPU threads: 4; OS: Linux 4.15; UI render: default; VCL: gtk3; 
Locale: ca-ES (ca_ES.UTF-8); UI-Language: en-US
Calc: threaded

and

Version 4.1.0.0.alpha0+ (Build ID: efca6f15609322f62a35619619a6d5fe5c9bd5a)
Comment 1 mulla.tasanim 2019-04-03 05:12:07 UTC
Thank you for reporting the bug

After clicking on Undo,new slide and text gets deleted respectively and Switching to Normal tab and back to Outline tab does not show the text again

I can not reproduce the bug in

Version: 6.2.1.2 (x64)
Build ID: 7bcb35dc3024a62dea0caee87020152d1ee96e71
CPU threads: 4; OS: Windows 6.3; UI render: default; VCL: win; 
Locale: en-US (en_US); UI-Language: en-US
Calc: CL


Version: 6.3.0.0.alpha0+ (x64)
Build ID: 91cdf22b88a4f7bec243c8fb187627e766d3294c
CPU threads: 4; OS: Windows 6.3; UI render: default; VCL: win; 
TinderBox: Win-x86_64@42, Branch:master, Time: 2019-03-08_00:38:10
Locale: en-US (en_US); UI-Language: en-US
Calc: CL
Comment 2 Buovjaga 2019-04-24 19:50:10 UTC
Bibisected on Linux with 43all to https://gerrit.libreoffice.org/plugins/gitiles/core/+log/4eedf5dc54ab19af39d7033462421082d1abb86d..a5661d717197a6723b80fb65cde463c479983934

Looks like https://gerrit.libreoffice.org/plugins/gitiles/core/+/57e6f04066cfddfa79eb2b79cf5c45653c79eff3%5E%21/
Fix fdo#45177 - avoid linked undo for the while.

While I try to wrap head around subtleties for linked undo in
Impress outline view, disable that here for the while. Better than
a crash for sure.

Adding Cc: to Thorsten Behrens

Party like it's 2012!
Comment 3 QA Administrators 2021-04-24 04:10:03 UTC Comment hidden (obsolete)
Comment 4 Xisco Faulí 2021-04-26 07:55:41 UTC
Still reproducible in

Version: 7.2.0.0.alpha0+ / LibreOffice Community
Build ID: 5366811e24532ae0f6b124a2eb85021b59d47f4b
CPU threads: 4; OS: Linux 5.7; UI render: default; VCL: gtk3
Locale: en-US (en_US.UTF-8); UI: en-US
Calc: threaded
Comment 5 Xisco Faulí 2021-04-26 08:03:38 UTC
(In reply to Buovjaga from comment #2)
> Bibisected on Linux with 43all to
> https://gerrit.libreoffice.org/plugins/gitiles/core/+log/
> 4eedf5dc54ab19af39d7033462421082d1abb86d..
> a5661d717197a6723b80fb65cde463c479983934
> 
> Looks like
> https://gerrit.libreoffice.org/plugins/gitiles/core/+/
> 57e6f04066cfddfa79eb2b79cf5c45653c79eff3%5E%21/
> Fix fdo#45177 - avoid linked undo for the while.
> 
> While I try to wrap head around subtleties for linked undo in
> Impress outline view, disable that here for the while. Better than
> a crash for sure.
> 
> Adding Cc: to Thorsten Behrens
> 
> Party like it's 2012!

I tried to revert the mentioned commit but SfxLinkUndoAction is gone since https://cgit.freedesktop.org/libreoffice/core/commit/?id=3e9e667af2d8d307844b29d608b377a04b6bb139 so not so easy...