Bug 124544 - Slideshow loading spinner closes too early
Summary: Slideshow loading spinner closes too early
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice Online
Classification: Unclassified
Component: Impress (show other bugs)
Version:
(earliest affected)
unspecified
Hardware: All All
: medium enhancement
Assignee: Alexandru Vladutu
URL:
Whiteboard: target:6.3.0
Keywords:
Depends on:
Blocks:
 
Reported: 2019-04-04 10:56 UTC by Alexandru Vladutu
Modified: 2019-04-05 05:42 UTC (History)
1 user (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Alexandru Vladutu 2019-04-04 10:56:51 UTC
Open a big enough presentation, then click on 'Fullscreen presentation'. There is a spinner that is displayed from the moment you clicked the button until the slideshow.svg is generated by the LibreOffice Online backend ('onSlideDownloadReady' function from 'loleaflet/src/map/handler/Map.SlideShow.js').

The problem is that is the presentation is big enough it will take a while until it is downloaded and displayed by the browser, meanwhile the user will see a blank screen.
Comment 1 Alexandru Vladutu 2019-04-04 11:52:52 UTC
Fixed via https://gerrit.libreoffice.org/#/c/70250/
Comment 2 Aron Budea 2019-04-04 16:04:34 UTC
Alexandru, as a suggestion, if the first line of the commit message contains a bug number in a format like "tdf#" plus the number (eg. tdf#124544), there's automatic commit notification between gerrit and bugzilla.

Noting the commit manually now, thanks for the fix!

https://cgit.freedesktop.org/libreoffice/online/commit/?id=51e849bf5dcb4bcef1fd042bb45f07b4383cb461
author		Alexandru Vlăduţu <alexandru.vladutu@1and1.ro>	2019-04-04 13:57:23 +0300
committer	Szymon Kłos <szymon.klos@collabora.com>	2019-04-04 13:46:29 +0200

loleaflet: optimize slideshow spinner
Comment 3 Alexandru Vladutu 2019-04-05 05:42:59 UTC
Thank you Aron, I was not aware of this at the time!