Created attachment 150680 [details] Screenshot 1 Started Windows 10 in a VM, switched to the high contrast mode and started LibreOffice. The menu items have gray font color on a gray canvas and the sidebar has a dark background (unlike the toolbars) with Sifr dark icons.
Created attachment 150681 [details] Screenshot 2
This report kind of has multiple issues. There is bug 98067 for the menus, but back then they were black on black. I confirm they are now gray on gray. Maybe we should make this about the icons. They are actually Sifr, not Sifr dark (which would work fine). The sidebar deck icons are actually not visible at all, which might be some other issue. Version: 6.4.0.0.alpha0+ (x64) Build ID: 3e64065612acec2eb29aa21e2b515953422256d7 CPU threads: 4; OS: Windows 10.0; UI render: default; VCL: win; TinderBox: Win-x86_64@62-TDF, Branch:master, Time: 2019-08-15_22:57:26 Locale: fi-FI (fi_FI); UI-Language: en-US Calc: threaded
The theme High contrast #2 shows green text for menus. High contrast white shows black text for menus, but Sidebar icons are still invisible.
So before we switch to Sifr Dark we have to fix bug 98067 that also affects the toolbar background color, AFAICS.
Not that simple. The Sifr icon shapes are fine, and in reality a "highcontrast" theme being passed in from Windows WDM could use either (currently hard coded to switch to Sifr (the dark icons) when os reports HC mode). What is needed is a test of the contrast between fg/bg of the HC theme and select either default Sifr (the dark icons) or Sifr-dark (the light icons). Alternatively, Sifr is one of the icon sets that would be suitable to colorizing the SVG flavor of the icons in response to os/DE theme. Have a look at the GreyEve HighContrast configured Windows WDM theme [1], where issues of bug 98067 are very evident on the main menu. =-ref-= [1] https://github.com/nitschis/GreyEveTheme
Caolán McNamara committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/d6dff5e96afc214baf11a3a41932b1432689b02e tdf#124672 for hicontrast white/black bg select either Sifr vs Sifr Dark It will be available in 7.5.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
done in trunk, backport to 7-4 in gerrit
The toggle between the Sifr and Sifr (Dark) icon theme depending on os/DE HighContrast theme selection is working well on Windows now. Do we need to do anything to use the SVG flavors of Sifr icon themes for HiDPI or UI scaled above 150%? Think crispness of the icons when for accessibility a low vision user needs highly scaled UI. The default Sifr PNG themes will pixelate, would need the SVG then. Version: 7.5.0.0.alpha0+ (x64) / LibreOffice Community Build ID: d72571fdd47c627efcd0dff92fbe8a9747f92932 CPU threads: 8; OS: Windows 10.0 Build 19044; UI render: Skia/Vulkan; VCL: win Locale: en-US (en_US); UI: en-US Calc: threaded
I've some comment elsewhere that going the gnome route of having svg and pngs as a single theme with svg as "scalable" and pngs as pre-canned sizes might make most sense.
Caolán McNamara committed a patch related to this issue. It has been pushed to "libreoffice-7-4": https://git.libreoffice.org/core/commit/a8b7a725c62671599245733e55f311795f49b6e4 tdf#124672 for hicontrast white/black bg select either Sifr vs Sifr Dark It will be available in 7.4.3. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.