Bug 124719 - EXTENSION: The togglr bookmarks script doesn't work
Summary: EXTENSION: The togglr bookmarks script doesn't work
Status: RESOLVED NOTOURBUG
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Extensions (show other bugs)
Version:
(earliest affected)
6.3.0.0.alpha0+
Hardware: x86-64 (AMD64) Windows (All)
: medium normal
Assignee: Not Assigned
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-04-13 13:29 UTC by Sebők Gábor
Modified: 2019-05-15 16:29 UTC (History)
3 users (show)

See Also:
Crash report or crash signature:


Attachments
Libreoffice-Dev (8.21 KB, application/vnd.oasis.opendocument.text)
2019-05-12 17:23 UTC, paulmcquad
Details
screenshot (13.86 KB, image/png)
2019-05-15 15:55 UTC, rolfofsaxony
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Sebők Gábor 2019-04-13 13:29:56 UTC
Description:
After deploying https://extensions.libreoffice.org/extensions/bookmark-toggle/1-0.0 and restarting LO,ALT + 1 (one) doesn't do anything.

Actual Results:
After deploying script, it's meaningless kéép pushing ALT + 1.

Expected Results:
Show bookmarks in text.


Reproducible: Always


User Profile Reset: No



Additional Info:
Comment 1 Dieter 2019-04-13 13:38:12 UTC
(In reply to Sebők Gábor from comment #0)
> Description:
> After deploying
> https://extensions.libreoffice.org/extensions/bookmark-toggle/1-0.0 and
> restarting LO,ALT + 1 (one) doesn't do anything.

Please try version 1.1.0 (https://extensions.libreoffice.org/extensions/bookmark-toggle/1-1.0). Does solve your problem => NEEDINFO
Comment 2 Sebők Gábor 2019-04-13 16:02:45 UTC
I've tried out https://extensions.libreoffice.org/extensions/bookmark-toggle/1-1.0
but I don't have LINUX (THIS IS ONLY FOR LINUX). My system is Win10 on HP Folio 9470m.


Regards,
Gábor
Comment 3 Dieter 2019-04-14 05:27:33 UTC
Gábor, sorry I diidn't see, that it is only for Linux. I assume, that the author of the extension is responsible for fixing the bug mentioned in the Linux release also for windows. But there are no information about the author. So I would say NOTOURBUG.
Comment 4 Sebők Gábor 2019-04-14 10:28:32 UTC
I got your letter. Which mean... who is responsible now?

Gábor
Comment 5 Dieter 2019-04-15 06:17:43 UTC
(In reply to Sebők Gábor from comment #4)
> I got your letter. Which mean... who is responsible now?
> 
> Gábor

For me, the author of the extension is responsible to make it available for Lo 6.2 under Windows, but perhaps more experienced users have another opinon.
Comment 6 paulmcquad 2019-05-12 17:23:32 UTC
Created attachment 151323 [details]
Libreoffice-Dev

Version: 6.3.0.0.alpha0


Message: <class 'KeyError'>: 'bookmarktoggle.oxt'
  File "/home/gamer/Downloads/LibreOfficeDev_6.3.0.0.alpha0_Linux_x86-64_rpm/RPMS/opt/libreofficedev6.3/program/pythonscript.py", line 1037, in getScript
    self.provCtx.uriHelper.getStorageURI(scriptUri) );
  File "/home/gamer/Downloads/LibreOfficeDev_6.3.0.0.alpha0_Linux_x86-64_rpm/RPMS/opt/libreofficedev6.3/program/pythonscript.py", line 407, in getStorageUrlFromPersistentUrl
    package = self.mapPackageName2Path[ packageName ]
Comment 7 Buovjaga 2019-05-12 17:30:11 UTC
Adding extension author to Cc, hoping for comments.
Comment 8 Sebők Gábor 2019-05-12 23:09:29 UTC
(In reply to Dieter Praas from comment #1)
> (In reply to Sebők Gábor from comment #0)
> > Description:
> > After deploying
> > https://extensions.libreoffice.org/extensions/bookmark-toggle/1-0.0 and
> > restarting LO,ALT + 1 (one) doesn't do anything.
> 
> Please try version 1.1.0
> (https://extensions.libreoffice.org/extensions/bookmark-toggle/1-1.0). Does
> solve your problem => NEEDINFO

Thanks,but unfortunately I've Win10.
Comment 9 Dieter 2019-05-13 11:49:17 UTC
I would say NOTOURBUG, but a bug of the extension.
Comment 10 rolfofsaxony 2019-05-13 19:18:05 UTC
(In reply to paulmcquad from comment #6)
> Created attachment 151323 [details]
> Libreoffice-Dev
> 
> Version: 6.3.0.0.alpha0
> 
> 
> Message: <class 'KeyError'>: 'bookmarktoggle.oxt'
>   File
> "/home/gamer/Downloads/LibreOfficeDev_6.3.0.0.alpha0_Linux_x86-64_rpm/RPMS/
> opt/libreofficedev6.3/program/pythonscript.py", line 1037, in getScript
>     self.provCtx.uriHelper.getStorageURI(scriptUri) );
>   File
> "/home/gamer/Downloads/LibreOfficeDev_6.3.0.0.alpha0_Linux_x86-64_rpm/RPMS/
> opt/libreofficedev6.3/program/pythonscript.py", line 407, in
> getStorageUrlFromPersistentUrl
>     package = self.mapPackageName2Path[ packageName ]

I have tested your attachment in both LO 6.0 and 6.2 on Linux Mint 19.1 (Ubuntu 18.04) where it functions happily.

I do not as yet have a copy of LO 6.3 but if I can load it up I will.

With regard to the issue about working on Windows, the code does nothing Linux specific, so unless there is some difference in the implementation/installation between Windows and Linux, I would expect it to function, as long as the person installing it has the requiste libraries loaded i.e, python, pyuno and libreoffice-python-script-provider and the description of the extension does specify that.

The issue of testing in on Windows is, I don't own a windows OS and refuse point blank to allow it in the house, so I won't be testing it on Windows. 

However it is a simple python script, so it wouldn't be difficult, if someone had the urge, it's only creating annotations for each bookmark found.
As I said, I don't see why it wouldn't work on Windows but as I don't use that OS, I specified it to be Linux only to cover for the fact that I can't test it.

One last point, the error "Class KeyError", there is no such Class in the script, that error must be coming out of the LO script "pythonscript.py" over which I have no control. Perhaps modifying the HotKey from Alt+1 to something else might shed some light on the problem.

Feel free to come back to me with any comments or suggestions.

Regards
RolfofSaxony
Comment 11 Buovjaga 2019-05-14 06:56:33 UTC
Thanks a lot for the comment. I will change the status, but Gábor is free to ask more questions.
Comment 12 rolfofsaxony 2019-05-15 15:55:22 UTC
Created attachment 151445 [details]
screenshot

screenshot of Bookmark toggle functioning
Comment 13 rolfofsaxony 2019-05-15 15:57:14 UTC
(In reply to rolfofsaxony from comment #12)
> Created attachment 151445 [details]
> screenshot
> 
> screenshot of Bookmark toggle functioning

This was taken using LibreOffice Version: 6.2.3.2 the latest released version I can find.
Comment 14 rolfofsaxony 2019-05-15 16:00:27 UTC
(In reply to rolfofsaxony from comment #13)
> (In reply to rolfofsaxony from comment #12)
> > Created attachment 151445 [details]
> > screenshot
> > 
> > screenshot of Bookmark toggle functioning
> 
> This was taken using LibreOffice Version: 6.2.3.2 the latest released
> version I can find.

Please note:
I there are no bookmarks in the document then Bookmark Toggle will appear to do nothing! It does not issue a warning that there are no bookmarks.