Download it now!
Bug 125204 - Not using the theme based icons for .UI of Customize dialogs on Windows builds
Summary: Not using the theme based icons for .UI of Customize dialogs on Windows builds
Status: NEW
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: UI (show other bugs)
Version:
(earliest affected)
unspecified
Hardware: All All
: medium normal
Assignee: Not Assigned
URL:
Whiteboard:
Keywords: topicUI
Depends on:
Blocks: Customise-Dialog Icon-Themes-Code
  Show dependency treegraph
 
Reported: 2019-05-10 11:35 UTC by andreas_k
Modified: 2019-05-11 16:28 UTC (History)
1 user (show)

See Also:
Crash report or crash signature:


Attachments
windows and gtk3 backend (122.11 KB, image/png)
2019-05-10 11:35 UTC, andreas_k
Details

Note You need to log in before you can comment on or make changes to this bug.
Description andreas_k 2019-05-10 11:35:02 UTC
Created attachment 151290 [details]
windows and gtk3 backend

Menubar -> Tools -> customization

at gtk3 and qt5 backend the arrow icons were shown and on the windows backend there were some self rendered images were shown.

please use also on windows the icons from the icon theme.
Comment 1 V Stuart Foote 2019-05-10 18:41:49 UTC
Confirmed on Windows 10 Ent 64-bit en-US with recent master/6.3.0 build
Version: 6.3.0.0.alpha0+
Build ID: 85c0521f01f5c726e9f754b3175a550121e566c8
CPU threads: 8; OS: Windows 10.0; UI render: GL; VCL: win; 
Locale: en-US (en_US); UI-Language: en-US
Calc: CL

Looks like the stock UI icons used on Windows are old Industrial/Galaxy, maybe? Or something earlier...

But IIUC don't think the button's assigned icons (image1 - gtk-go-up, image2 - gtk-go-down, image3 - gtk-go-forward, image4 - gtk-go-back) come from UI [1][2], rather they're linked from source. Where they are mapped to stock SymbolType [3]. And I've no idea how the icon theme for os/DE gets picked up for use there--if it can.


=-refs-=
[1] https://opengrok.libreoffice.org/xref/core/cui/uiconfig/ui
[2] https://opengrok.libreoffice.org/xref/core/cui/source/customize
[3] https://opengrok.libreoffice.org/xref/core/vcl/source/window/builder.cxx?r=ed67b443#90