Bug 125204 - Not using the theme based icons for .UI of Customize dialogs on Windows builds
Summary: Not using the theme based icons for .UI of Customize dialogs on Windows builds
Status: NEW
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: UI (show other bugs)
(earliest affected)
Hardware: All All
: medium normal
Assignee: Not Assigned
Keywords: topicUI
Depends on:
Blocks: Customise-Dialog Icon-Themes-Code
  Show dependency treegraph
Reported: 2019-05-10 11:35 UTC by andreas_k
Modified: 2023-05-12 03:19 UTC (History)
1 user (show)

See Also:
Crash report or crash signature:

windows and gtk3 backend (122.11 KB, image/png)
2019-05-10 11:35 UTC, andreas_k

Note You need to log in before you can comment on or make changes to this bug.
Description andreas_k 2019-05-10 11:35:02 UTC
Created attachment 151290 [details]
windows and gtk3 backend

Menubar -> Tools -> customization

at gtk3 and qt5 backend the arrow icons were shown and on the windows backend there were some self rendered images were shown.

please use also on windows the icons from the icon theme.
Comment 1 V Stuart Foote 2019-05-10 18:41:49 UTC
Confirmed on Windows 10 Ent 64-bit en-US with recent master/6.3.0 build
Build ID: 85c0521f01f5c726e9f754b3175a550121e566c8
CPU threads: 8; OS: Windows 10.0; UI render: GL; VCL: win; 
Locale: en-US (en_US); UI-Language: en-US
Calc: CL

Looks like the stock UI icons used on Windows are old Industrial/Galaxy, maybe? Or something earlier...

But IIUC don't think the button's assigned icons (image1 - gtk-go-up, image2 - gtk-go-down, image3 - gtk-go-forward, image4 - gtk-go-back) come from UI [1][2], rather they're linked from source. Where they are mapped to stock SymbolType [3]. And I've no idea how the icon theme for os/DE gets picked up for use there--if it can.

[1] https://opengrok.libreoffice.org/xref/core/cui/uiconfig/ui
[2] https://opengrok.libreoffice.org/xref/core/cui/source/customize
[3] https://opengrok.libreoffice.org/xref/core/vcl/source/window/builder.cxx?r=ed67b443#90
Comment 2 QA Administrators 2021-05-11 03:51:32 UTC Comment hidden (obsolete)
Comment 3 QA Administrators 2023-05-12 03:19:54 UTC
Dear andreas_k,

To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information from Help - About LibreOffice.
If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not 
appropriate in this case)

If you want to do more to help you can test to see if your issue is a REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword

Feel free to come ask questions or to say hello in our QA chat: https://web.libera.chat/?settings=#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team