Bug 125309 - EDITING XLSX Long Cell-level hyperlink is clickable in neighboring cells
Summary: EDITING XLSX Long Cell-level hyperlink is clickable in neighboring cells
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Calc (show other bugs)
Version:
(earliest affected)
4.2.0.4 release
Hardware: All All
: medium normal
Assignee: Tünde Tóth
URL:
Whiteboard: target:6.4.0 target:6.3.0.1
Keywords:
Depends on:
Blocks: XLSX-Hyperlink
  Show dependency treegraph
 
Reported: 2019-05-15 13:06 UTC by NISZ LibreOffice Team
Modified: 2019-06-20 11:29 UTC (History)
3 users (show)

See Also:
Crash report or crash signature:


Attachments
Screenshot of the original document side by side in Excel and Calc. (70.58 KB, image/png)
2019-05-15 13:08 UTC, NISZ LibreOffice Team
Details
Example file from Excel with long hyperlinks overlapping to neighboring cells. (14.81 KB, application/vnd.openxmlformats-officedocument.spreadsheetml.sheet)
2019-05-15 13:09 UTC, NISZ LibreOffice Team
Details

Note You need to log in before you can comment on or make changes to this bug.
Description NISZ LibreOffice Team 2019-05-15 13:06:31 UTC
Description:
If a long hyperlink target is placed in XLSX, on opening the file in Calc the link is clickable in the neighboring cell too, if it has no custom visible text set or it is a number.

Steps to Reproduce:
1. Create a hyperlink in Excel by inserting it as plain text (I used https://cgit.freedesktop.org/libreoffice/core ), and put some text next to it (Cell A2 and B2)
2. Copy the previous hyperlink to a cell under the previous (cell A3 in the attached example) and leave B3 empty
3. Create a hyperlink with the same target, but set the link text to be a text, and put some text next to it (Cell A6 and B6)
4. Copy the previous hyperlink to a cell under the previous (Cell A7) and leave B7 empty
5. Create a hyperlink with the same target, but set the link text to be a number, and put some text next to it (Cell A9 and B9)
6. Save the file and open it in Calc
7. Hover the cursor on the cells in column B.



Actual Results:
When hovering the cursor on B3 or B10, the “Ctlr-click to follow hyperlink” pops up even if there is no hyperlink in B3 or B10. This happens on the left side of the cell, approximately until the end of the link you can see overlapping from A3 to B3. 
The behavior of cell B3 is specific to the editor, i.e. it happens in a new spreadsheet too (and we can consider it normal), but the behavior of B10 is related to the different handling of hyperlinks with a number as custom text in Excel and Calc, and so bug #79972.

Expected Results:
The Ctrl-click to follow hyperlink popup should not appear in B10, just like it does not appear in B9 where there is text next to a hyperlink similarly to B7 where the visible text of the link is a custom string.


Reproducible: Always


User Profile Reset: No



Additional Info:
Comment 1 NISZ LibreOffice Team 2019-05-15 13:08:57 UTC
Created attachment 151433 [details]
Screenshot of the original document side by side in Excel and Calc.
Comment 2 NISZ LibreOffice Team 2019-05-15 13:09:45 UTC
Created attachment 151434 [details]
Example file from Excel with long hyperlinks overlapping to neighboring cells.
Comment 3 Durgapriyanka 2019-05-15 21:04:45 UTC
Thank you for reporting the bug. I can confirm the bug present in 

Version: 6.3.0.0.alpha0+
Build ID: b6b28931435e44aca92b8c0e1659f701e3ed1a87
CPU threads: 2; OS: Windows 6.1; UI render: default; VCL: win; 
TinderBox: Win-x86@42, Branch:master, Time: 2019-01-30_06:57:04
Locale: en-US (en_US); UI-Language: en-US
Calc: threaded

However, in version 3.3.0.4 I cannot confirm the bug.

There is no hyperlink popup in cell B10.

Also, Links in A9 and B9 doesn't popup as it pops up in version 6.3.0.0
Comment 4 Tünde Tóth 2019-06-17 07:59:40 UTC
Confirmed with:

Version: 6.3.0.0.beta1+ (x86)
Build ID: 5cfac16dbd4af456a7fb6d52c8953c69a72ba2ba
CPU threads: 4; OS: Windows 10.0; UI render: GL; VCL: win; 
Locale: hu-HU (hu_HU); UI-Language: en-US
Calc: threaded
Comment 5 Commit Notification 2019-06-19 14:54:28 UTC
Tünde Tóth committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/+/711ccfbac1ef28fdf03ceea820be8d3e9f8a4009%5E%21

tdf#125309 XLSX editing: fix hyperlink at numeric data

It will be available in 6.4.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 6 Commit Notification 2019-06-20 11:29:35 UTC
Tünde Tóth committed a patch related to this issue.
It has been pushed to "libreoffice-6-3":

https://git.libreoffice.org/core/+/547dfdd56f52e779a795aefc56c78836fdb01ca4%5E%21

tdf#125309 XLSX editing: fix hyperlink at numeric data

It will be available in 6.3.0.1.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.