Bug 125318 - Copy & Paste does not work
Summary: Copy & Paste does not work
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Android Viewer (show other bugs)
Version:
(earliest affected)
6.0.0.0.alpha0+
Hardware: All All
: medium enhancement
Assignee: Michael Weghorn (away)
URL:
Whiteboard: target:7.2.0
Keywords:
: 125784 (view as bug list)
Depends on:
Blocks:
 
Reported: 2019-05-15 23:25 UTC by Jim Avera
Modified: 2021-03-18 15:14 UTC (History)
3 users (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Jim Avera 2019-05-15 23:25:36 UTC
Description:
In other Android apps, a long-press activates a copy/paste feature.  It seems to be a standard mechanism, because the same options (copy, paste, etc.) appear in many different apps.

But this does not happen in Libre Office Viewer for Android.  Long-press on text in an open text document does nothing.

If the experimental (editing) option is enabled, then long-press seems to activate a text selector (two cursors), but the enclosed text is not put into the clipboard and doing 'paste' in another app does not get anything from LO Viewer.

The lack of copy-and-paste support is pretty crippling for users who need to, for example, copy URLs from a text document and paste them into Firefox or another browser.

Steps to Reproduce:
1. Install LO Viewer for Android using the Play Store
2. Open a .odt document
3. pinch-zoom to make the text large enough to see easily
4. long-press on a word

Actual Results:
Nothing happens.

Expected Results:
The standard Android copy/paste dialog should appear, or something equivalent which allows copying text so it can be pasted in another app.


Reproducible: Always


User Profile Reset: No



Additional Info:
Samsung Galaxy s7 running Android 8.0.0

By the way, the "current" version in the Google Play Store is 6.0.0.0.alpha+ which is a little suspicious.
Comment 1 Xisco Faulí 2019-06-10 16:11:02 UTC
it makes sense. Moving to NEW
Comment 2 Michael Weghorn (away) 2019-12-13 10:06:09 UTC
*** Bug 125784 has been marked as a duplicate of this bug. ***
Comment 3 Ilhan Yesil 2021-02-01 11:45:34 UTC
Tested on master, 7.2.0.0 alpha+, it works if experimental (editing) mode is enabled. After long-press two cursors are displayed as described above, but also the toolbar is reloaded to show additional buttons for copy/paste. If in this state the text is short-pressed, only one cursor and the toolbar shows only the paste button.

Tested copy and paste buttons on the toolbar, text can be copied to another app, text from another app can be pasted into LO.
Comment 4 Michael Weghorn (away) 2021-02-01 12:13:26 UTC
(In reply to Ilhan Yesil from comment #3)
> Tested on master, 7.2.0.0 alpha+, it works if experimental (editing) mode is
> enabled. After long-press two cursors are displayed as described above, but
> also the toolbar is reloaded to show additional buttons for copy/paste. If
> in this state the text is short-pressed, only one cursor and the toolbar
> shows only the paste button.
> 
> Tested copy and paste buttons on the toolbar, text can be copied to another
> app, text from another app can be pasted into LO.

Nice. I think supporting copying from the LO Viewer app would also make sense when experimental (editing mode) is disabled.
Comment 5 Michael Weghorn (away) 2021-03-18 13:06:13 UTC
(In reply to Michael Weghorn from comment #4)

> Nice. I think supporting copying from the LO Viewer app would also make
> sense when experimental (editing mode) is disabled.

Pending Gerrit patch https://gerrit.libreoffice.org/c/core/+/112673 implements this
Comment 6 Commit Notification 2021-03-18 15:14:06 UTC
Michael Weghorn committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/88f4b76270c26ab1d99c14f68cdcbea4b6ee9031

tdf#125318 android: Allow copying with editing disabled

It will be available in 7.2.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.