Bug 125327 - Padding to text labels of the tabs on the Format Cells or Character dialogs need a bit more space before and after the label
Summary: Padding to text labels of the tabs on the Format Cells or Character dialogs n...
Status: NEW
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: UI (show other bugs)
Version:
(earliest affected)
6.1.1.2 release
Hardware: All All
: medium minor
Assignee: Not Assigned
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: Cell-Format-Dialog
  Show dependency treegraph
 
Reported: 2019-05-16 20:28 UTC by Roeland
Modified: 2019-05-20 08:56 UTC (History)
3 users (show)

See Also:
Crash report or crash signature:


Attachments
screenshot to describe the tabbed menu we're talking about (25.92 KB, image/png)
2019-05-16 20:28 UTC, Roeland
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Roeland 2019-05-16 20:28:52 UTC
Created attachment 151469 [details]
screenshot to describe the tabbed menu we're talking about

When using the Format Cells option (rightclick on a cell), the Format Cells menu pops up.N
This generates a tabbed interface, with acces to "numbers", "font", "font effects",...

This tabbed interface itself looks very cramped. Maybe it would be a nice visual improvement to give the tabs more space? For example the word "Alignment" inside the Alignment tab is pracically tied to the tab on it's left. The tabs are also very small compared to the other boxes..

On the right side of the tabs there's some space left, so this leaves some room to make the tabs bigger and visually more appealing.
Comment 1 V Stuart Foote 2019-05-17 04:21:28 UTC
Confirmed on a Windows build with current master/6.3.0alpha1+

The dialogs actually size width of the tabs responding to the localization of the labels. The longer the strings the wider the tabs.

IIUC the height of the tabs is fixed by os/DE so not sure those can be adjusted, but the spacing or "padding" before and after text of the labels can probably be increased a little bit to relieve the cramped feel.
Comment 2 Roman Kuznetsov 2019-05-18 20:09:23 UTC
Caolan, you are an expert in this. What do you think?
Comment 3 Caolán McNamara 2019-05-20 08:56:03 UTC
For these "gen" vclplug cases the values that initially control this are in include/vcl/tabctrl.hxx the TAB_TABOFFSET_X value (currently 3) and then mediated by the per-platform theming code i.e. in TabControl::ImplGetItemSize calls GetNativeControlRegion with ControlType::TabItem which for windows will end up in vcl/win/gdi/salnativewidgets-luna.cxx. The Windows one doesn't seem to suggest any extra expansion of the tab so on first glance if someone want to look into increasing this, then TAB_TABOFFSET_X might be the place to go