Bug 125379 - Add a link to FAQ to "JRE missing" message box
Summary: Add a link to FAQ to "JRE missing" message box
Status: NEW
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: LibreOffice (show other bugs)
(earliest affected)
Hardware: All All
: medium enhancement
Assignee: Not Assigned
Keywords: difficultyBeginner, easyHack, skillCpp
Depends on:
Blocks: Dialog-Msgbox
  Show dependency treegraph
Reported: 2019-05-20 05:57 UTC by Mike Kaganski
Modified: 2020-08-05 15:38 UTC (History)
7 users (show)

See Also:
Crash report or crash signature:


Note You need to log in before you can comment on or make changes to this bug.
Description Mike Kaganski 2019-05-20 05:57:26 UTC
When a usable Java/JRE is not found, LibreOffice issues a warning to the user, telling that a suitable JRE needs to be installed, and LO restarted.

The proposal is to include a link to [1] to the dialog.

Code pointers:
1. https://git.libreoffice.org/core/+/506e1396c34bb90c8d2c3679e3e84c3833b18869 is a commit that enhanced the relevant message on Windows.
2. https://git.libreoffice.org/core/+/a1700d52a47184ee07b91b461a846dc5435f0022 is a commit that created a dialog with an optional hyperlink.

[1] https://wiki.documentfoundation.org/Faq/General/InstallJava
Comment 1 Heiko Tietze 2019-05-23 11:16:53 UTC
We should use the help with hub.libreoffice.org for localization instead of the wiki. And even better is just a help button in this dialog, if we agree on the need for it.
Comment 2 Stephan Bergmann 2019-06-04 08:12:09 UTC
(In reply to Mike Kaganski from comment #0)
> The proposal is to include a link to [1] to the dialog.
> [1] https://wiki.documentfoundation.org/Faq/General/InstallJava

Is there a protocol in place to ensure that that URL won't go stale?
Comment 3 Mike Kaganski 2019-06-04 08:16:53 UTC
(In reply to Stephan Bergmann from comment #2)
> Is there a protocol in place to ensure that that URL won't go stale?

Should there be one? I don't think so. The page is a wiki; having it more visible would also promote its update in case of need; but nothing is guaranteed - and no need in these guarantees. In the end, I see stale webpages ~everywhere, including those mentioned from active MS WinAPI documentation ... so what? ;-)
Comment 4 Stephan Bergmann 2019-06-04 08:39:54 UTC
I would assume that such a link goes through a redirecting URL that is managed and kept stable by TDF infra.
Comment 5 Heiko Tietze 2019-06-06 12:13:21 UTC
Simple message boxes should not have a help button because its supposed to be simple and do not need it. So if we introduce such a reference it has to be a link underneath the text. Rather than pointing to the wiki I'd prefer a proper help page, though. And of course accessed via hub.libreoffice.
Comment 6 Abhishek 2020-01-29 13:19:50 UTC
Hi there, I am currently working on this issue. According to me I have made some changes. Please help me with testing part. I tried using svtools/CppunitTest_svtools_dialogs_test.mk for testing but it didn't work.
Comment 7 Heiko Tietze 2020-01-30 15:56:03 UTC
(In reply to Abhishek from comment #6)
> Please help me with testing part.

Please commit your patch so we can do the review.