Bug 125432 - "Help" buttons are non functional in tunneled dialogs
Summary: "Help" buttons are non functional in tunneled dialogs
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: iOS Editor (show other bugs)
Version:
(earliest affected)
unspecified
Hardware: Other iOS
: medium trivial
Assignee: Not Assigned
URL:
Whiteboard: target:7.0.0
Keywords:
Depends on:
Blocks:
 
Reported: 2019-05-21 15:54 UTC by Nicolas Christener
Modified: 2020-04-13 14:53 UTC (History)
2 users (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Nicolas Christener 2019-05-21 15:54:51 UTC
Description:
The "Help" buttons in tunneled dialogs don't work. Taping on them does not result in any action, the button just becomes blue.

Steps to Reproduce:
1. Open a tunneled dialg in the iOS app, e.g. the "hyperlink"-dialog
2. Tap on "Help"

Actual Results:
Nothing happens, the button becomes blue.

Expected Results:
Not sure if pointing a browser to https://help.libreoffice.org is the expected result - as far as I know, there is no help for "Online".

Maybe the "Help" buttons should just be removed in the "iOS" case?


Reproducible: Always


User Profile Reset: No



Additional Info:
There are multiple dialogs showing a "Help" button:
* Edit > Search & Replace...
* Edit > Edit Style...
* Insert > Section...
* Insert > Hyperlink...
* Insert > Special character...
* Insert > Table of contents and index > Index entry...
* Insert > Table of contents and index > Bibliography entry...
* Insert > Table of contents and index > Table of contents, index or bibliography...
* Format > Character...
* Format > Paragraph...
* Format > Bullets and numbering...
* Format > Page...
* Format > Columns...
* Tools > Spelling...
* Tools > Thesaurus...
Comment 1 Xisco Faulí 2019-05-27 11:35:06 UTC
Moving to NEW as agreed in the ESC meeting
Comment 2 Nicolas Christener 2020-04-01 07:34:48 UTC
This issue has been fixed and can be closed. Tested with 4.2.3 (48).

I believe it was done with this commit in the 'online' repository:

Thanks a lot to the Collabora team and especially Andras to take care of this!

commit 87fccc25d2e9b82f79c9babefd6bafe79718210a
Author: Andras Timar <andras.timar@collabora.com>
Date:   Mon Mar 23 20:18:45 2020 +0100

    Disable Help button on dialogs in mobile apps
    
    On mobile UI there should be no tunnelled dialogs. But if there are some,
    by mistake, at least they should not have a non-working Help button.
    
    Change-Id: I88001f560eefd0ac9163dd6893b7f0c4d8e50c3a
Comment 3 Aron Budea 2020-04-13 14:53:34 UTC
Thanks for the feedback, Nicolas! Closing as fixed.