Bug 125533 - Styles are rendered too small in Calc's sidebar
Summary: Styles are rendered too small in Calc's sidebar
Status: NEW
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Calc (show other bugs)
Version:
(earliest affected)
5.3 all versions
Hardware: All All
: medium trivial
Assignee: Not Assigned
URL:
Whiteboard: target:7.3.0
Keywords:
Depends on:
Blocks: Sidebar-Properties-Style
  Show dependency treegraph
 
Reported: 2019-05-27 20:24 UTC by Thorsten Wagner
Modified: 2023-11-02 13:38 UTC (History)
4 users (show)

See Also:
Crash report or crash signature:


Attachments
Screenshot (25.61 KB, image/png)
2019-05-27 20:24 UTC, Thorsten Wagner
Details
Screenshot 2 from Writer with patch (54.45 KB, image/png)
2021-06-28 22:11 UTC, Thorsten Wagner
Details
Screenshot 3 from Calc with patch (41.44 KB, image/png)
2021-06-28 22:11 UTC, Thorsten Wagner
Details
Screenshot 4 from Calc with patch (reduced scope) (39.48 KB, image/png)
2021-07-07 23:13 UTC, Thorsten Wagner
Details
Screenshot 5 from Calc (40.15 KB, image/png)
2021-07-07 23:13 UTC, Thorsten Wagner
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Thorsten Wagner 2019-05-27 20:24:02 UTC
Description:
Compared to Writer styles are rendered too small in Calc's sidebar (see screenshot, "Default" style).

Steps to Reproduce:
(1) Open Calc

(2) Open Sidebar

(3) Open Style dropdown

Actual Results:
Styles are rendered very small

Expected Results:
Styles are rendered in same sizes as in Writer


Reproducible: Always


User Profile Reset: No


OpenGL enabled: Yes

Additional Info:
Issue is not related to LO 6.3. Issue exists since LO 5 at least.
Comment 1 Thorsten Wagner 2019-05-27 20:24:36 UTC
Created attachment 151714 [details]
Screenshot
Comment 2 m_a_riosv 2019-05-27 20:40:17 UTC
Repro
Version: 6.3.0.0.alpha1 (x64)
Build ID: 547edd20e527fb02900f6174973770d26306e2e7
CPU threads: 4; OS: Windows 10.0; UI render: GL; VCL: win; 
Locale: es-ES (es_ES); UI-Language: en-US
Calc: CL
Comment 3 Xisco Faulí 2019-05-30 11:58:03 UTC
Also reproduced in

Version: 5.2.0.0.alpha1+
Build ID: 5b168b3fa568e48e795234dc5fa454bf24c9805e
CPU Threads: 4; OS Version: Linux 4.15; UI Render: default; 
Locale: ca-ES (ca_ES.UTF-8)

@Jim, I thought you could be interested in this issue...
Comment 4 Jim Raykowski 2019-06-21 01:45:16 UTC
 (In reply to Xisco Faulí from comment #3)
> Also reproduced in
> 
> Version: 5.2.0.0.alpha1+
> Build ID: 5b168b3fa568e48e795234dc5fa454bf24c9805e
> CPU Threads: 4; OS Version: Linux 4.15; UI Render: default; 
> Locale: ca-ES (ca_ES.UTF-8)
> 
> @Jim, I thought you could be interested in this issue...

I haven't had much success on this one. I'll keep it in mind though. Thanks for including me.
Comment 5 Thorsten Wagner 2021-06-28 22:07:58 UTC
Submitted patch to Gerrit:

https://gerrit.libreoffice.org/c/core/+/118038

With patch sidebar style dropdowns for Writer and Calc look like in screenshots 2 and 3 attached.

Patch has the following contents:

(1) Font height was limited to line height only. Fonts larger than line height are reduced to line height. This change limits font height to 80% of line height to preserve an inset margin.

(2) There was no lower limit. Too small fonts became unreadable. This change limit font height to 50% of line height at least. Fonts smaller then 50% of line height are enlarged to 50% of line height.

(3) There were changes of Calc default style names. Style names for Calc are updated to current style names. As styles shown by sidebar dropdown are hardcoded Styles Accent 1, Accent 2, and Accent 3 were added to offer a few more options.
Comment 6 Thorsten Wagner 2021-06-28 22:11:26 UTC
Created attachment 173256 [details]
Screenshot 2 from Writer with patch
Comment 7 Thorsten Wagner 2021-06-28 22:11:48 UTC
Created attachment 173257 [details]
Screenshot 3 from Calc with patch
Comment 8 Thorsten Wagner 2021-07-07 23:11:38 UTC
Fonts are rendered smaller in Calc compared to Writer although rendering is done by the same code. Limiting small fonts has been removed from patch as this does not seem to be the root cause.

Scope of submitted patch has been reduced to update Calc style names only (see screenshot 4):

https://gerrit.libreoffice.org/c/core/+/118038

Patch is required because Calc style names have been changed but does not fix the issue addressed here.

Furthermore there are additional issues (see screenshot 5). To reproduce, change background color of a style visible within dropdown window. Background color is not shown correctly but as blue backgound.
Comment 9 Thorsten Wagner 2021-07-07 23:13:08 UTC
Created attachment 173434 [details]
Screenshot 4 from Calc with patch (reduced scope)
Comment 10 Thorsten Wagner 2021-07-07 23:13:33 UTC
Created attachment 173435 [details]
Screenshot 5 from Calc
Comment 11 Commit Notification 2021-07-08 06:34:32 UTC
Thorsten Wagner committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/396ceb05ef2bb75ba5c81b83f443863c485fa0b9

tdf#125533 Update Calc style names for style sidebar dropdown

It will be available in 7.3.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 12 Heiko Tietze 2021-07-08 06:36:58 UTC
(In reply to Commit Notification from comment #11)
> Thorsten Wagner committed a patch related to this issue.

This patch just adds some cells styles to the drop down. It does not tackle the rendering issue, which Thorsten planned for another patch.
Comment 13 J22Gim 2023-04-14 06:27:35 UTC
Can reproduce it. Too small, almost unreadable to me.
_________

Version: 7.5.2.2 (X86_64) / LibreOffice Community
Build ID: 50(Build:2)
CPU threads: 4; OS: Linux 5.15; UI render: default; VCL: gtk3
Locale: en-US (en_US.UTF-8); UI: en-US
Ubuntu package version: 4:7.5.2~rc2-0ubuntu0.22.04.1~lo1
Calc: threaded
Comment 14 J22Gim 2023-11-02 13:38:15 UTC
Still present in Version: 7.6.2.1 (X86_64) / LibreOffice Community
Build ID: 60(Build:1)
CPU threads: 24; OS: Linux 6.2; UI render: default; VCL: qt5 (cairo+xcb)
Locale: en-US (en_US.UTF-8); UI: en-US
Ubuntu package version: 4:7.6.2~rc1-0ubuntu0.22.04.1~lo1
Calc: threaded