Bug 125575 - Saving a file will later lead to unusable app
Summary: Saving a file will later lead to unusable app
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: iOS Editor (show other bugs)
Version:
(earliest affected)
unspecified
Hardware: Other iOS
: medium normal
Assignee: Not Assigned
URL:
Whiteboard: target:6.4.0
Keywords:
Depends on:
Blocks:
 
Reported: 2019-05-29 12:08 UTC by Nicolas Christener
Modified: 2019-10-02 07:06 UTC (History)
1 user (show)

See Also:
Crash report or crash signature:


Attachments
Video demonstrating the issue (973.84 KB, video/mp4)
2019-09-26 12:26 UTC, Nicolas Christener
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Nicolas Christener 2019-05-29 12:08:36 UTC
Description:
After saving a file in the iOS app and closing the file it's not possible to open a new file.

Steps to Reproduce:
1. Open a file in the iOS app
2. Change something and save the file
3. Open the same or an other file

Actual Results:
The app will show the loading indicator but stays at 0%.

Expected Results:
The document should be loaded.


Reproducible: Always


User Profile Reset: No



Additional Info:
Comment 1 Xisco Faulí 2019-05-30 10:42:18 UTC
Moving to NEW as agreed in the ESC meeting
Comment 2 How can I remove my account? 2019-09-26 09:45:28 UTC
I am actually not able to reproduce this at the moment. I remember I used to see it occasionally in the past, but possibly something has changed in iOS 13(.1) so that it doesn't happen so often now? Will keep trying.

The similar problem related to creating documents from templates might still be there, though. That has been much easier to reproduce in the past, too.
Comment 3 Nicolas Christener 2019-09-26 12:23:45 UTC
Hi @tor

It happens for me every time (with iOS 13.1, but also with 12.x) using version 55 of the app.

I have my iPad set to the language "German Switzerland".

How to reproduce:

1.) Create a writer document from the "Blank (A4)" template
2.) Add some text e.g. "Hello World"
3.) Save the document
4.) Go back to the file selection using the "<" icon in the menu
5.) Open the same file again

Now the loader will show the spinning circle and won't load the document.
Comment 4 Nicolas Christener 2019-09-26 12:26:20 UTC
Created attachment 154544 [details]
Video demonstrating the issue
Comment 5 How can I remove my account? 2019-09-26 14:48:12 UTC
OK, so this is about the "create from template" scenario. That indeed I can reproduce. I just fixed it: https://gerrit.libreoffice.org/#/c/79633/
Comment 6 Nicolas Christener 2019-09-28 14:30:31 UTC
Still present in 4.1.61. Do you need more information about how to trigger it?
Comment 7 How can I remove my account? 2019-09-28 15:58:08 UTC
Yes please. Apparently I fixed the wrong bug. I was suspecting that, as what I saw was a crash, but what you described was a hang during the opening of the document. But I had hoped that it was still caused by the same root cause....

Please describe in exact detail. For instance, make clear whether you are talking about opening an existing document (and in that case what type and on what kind of storage), or using a template. I assume you are always using the Swiss German iOS locale.
Comment 8 Nicolas Christener 2019-09-28 17:33:06 UTC
Okay I try to be more precise. Following my setup:

* iOS 13.x (also happens on 12.x)
* iPad language set to "Deutsch" (German)
* iPad region set to "Schweiz" (Switzerland)
* I start with a complet empty folder, no existing odf files
* I don't use specific templates, only the ones shipped by the app

1.) Create an empty document using the "create document" function the app provides, chose "Blank (A4)", document opens automatically
2.) Enter edit mode and add some random text
3.) Save the file
4.) Close the file by navigating back to the file browser using "<" in the menu

From now on the app is in an unusable state it means:
a.) creating an other file using "create document" results in the never ending spinning wheel
b.) opening the previously saved file again results in the never ending spinning wheel
c.) opening any other files results in the never ending spinning wheel

The app needs to be closed/killed before a new document can be opened/created after a "save" operation was triggered.

This can also be triggered w/o invoking the "create document" function - I just describe this to let you know, that the "templates" are not per se involved.

Other scenario w/o templates:

1.) create two docx files either using Apple pages or access such files through e.g. Nextcloud
2.) open the first file using the iOS app
3.) Enter edit mode and add/change some text
4.) Save the file
5.) Close the file by navigating back to the file browser using "<" in the menu
6.) Open the second file

This will again lead to the never ending spinning wheel.
Comment 9 Commit Notification 2019-09-29 11:24:38 UTC
Tor Lillqvist committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/online/commit/908240741daba5e8b9991bc0979a506b62bf1c72

tdf#125575: Must reset the "kit" callback to null when closing document
Comment 10 How can I remove my account? 2019-09-30 08:35:32 UTC
In what storage location ("Speicherorte") is that empty folder? (I have so far mostly tested the app using iCloud Drive and "On My iPad".) Is it an empty subfolder of that, or the top folder of it?
Comment 11 How can I remove my account? 2019-09-30 09:06:04 UTC
Tested with the Nextcloud storage provider, too, and could not reproduce with that either. (I created a new empty folder on the Nextcloud server I am connecting to, and did the test in that.)
Comment 12 Nicolas Christener 2019-09-30 10:23:55 UTC
I usually test with "On My iPad" and only report issues when they happen with that "storage backend" as well.

I'm happy to test with the next release - AFAIK there is no build available that contains the fix you made in:
https://git.libreoffice.org/online/commit/908240741daba5e8b9991bc0979a506b62bf1c72

As soon as there is a build with that fix, I'll test all the bugs that are related to this kind of problems. I suspect, that e.g. #124898 could be related to this as well.
Comment 13 How can I remove my account? 2019-09-30 10:36:11 UTC
Yes, the corresponding commit ee497b873eadfa3ab4ba77793748e83ff649dacf in the distro/collabora/collabora-online-4 branch is included in the 4.1.61 build. Check here: https://gerrit.libreoffice.org/#/q/status:merged+project:online+branch:distro/collabora/collabora-online-4
Comment 14 How can I remove my account? 2019-09-30 12:35:39 UTC
OK, so a short hangouts session demonstrated that it is using the File:Save menu entry that is essential to reproducing the bug. I have always just tapped the save icon, or relied on just closing the document also saving it. Now when I can reproduce it, fixing it should not be too hard.
Comment 15 How can I remove my account? 2019-09-30 21:18:48 UTC
This seems to fix the issue: https://gerrit.libreoffice.org/#/c/79902/ . It is a simple change that just makes the code simpler in the app case. Will submit a new build to TestFlight tomorrow.
Comment 16 How can I remove my account? 2019-10-01 19:59:21 UTC
It seems that the patch is not needed in the master branch, at least in my testing. (The code is somewhat different there.)
Comment 17 Nicolas Christener 2019-10-02 07:04:04 UTC
I can confirm, that the issue is fixed with 4.1.63 (63) on iOS 13.1.2.

Will test on 12.x as well.

Thanks a lot to Tor and Collabora for fixing this!
Comment 18 How can I remove my account? 2019-10-02 07:06:37 UTC
Resolving as fixed.