Bug 125644 - Select marker in filter entry list not correctly set, filter not correctly reset
Summary: Select marker in filter entry list not correctly set, filter not correctly reset
Status: RESOLVED WORKSFORME
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Calc (show other bugs)
Version:
(earliest affected)
6.3.0.0.alpha1+
Hardware: x86-64 (AMD64) All
: medium normal
Assignee: Not Assigned
URL:
Whiteboard:
Keywords: bibisected, bisected, regression
Depends on:
Blocks: AutoFilter
  Show dependency treegraph
 
Reported: 2019-06-02 16:56 UTC by Stefan_Lange_KA@T-Online.de
Modified: 2024-07-06 10:51 UTC (History)
3 users (show)

See Also:
Crash report or crash signature:


Attachments
Test document to show the problem (27.22 KB, application/vnd.oasis.opendocument.spreadsheet)
2019-06-02 16:56 UTC, Stefan_Lange_KA@T-Online.de
Details
Screenshot of the example file in Calc and its xlsx version in Excel (290.78 KB, image/png)
2022-06-29 07:37 UTC, Gabor Kelemen (allotropia)
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Stefan_Lange_KA@T-Online.de 2019-06-02 16:56:08 UTC
Created attachment 151854 [details]
Test document to show the problem

In the attached test document "Testtabelle_Filter_V1a.ods" is a filter defined in column D via Standard Filter with condition "contains" + value.

There are 2 problems:

1. By a click on the blue filter arrow I would expect that only these entries in the filter entry list are marked as selected that correspond the filter condition "contains" + value, but all entries are marked as "selected".
This problem exists in LO 6.1 and LO 6.2 (e.g. release LO 6.1.4.2 and LO 6.2.4.2 and LO dev 6.2.5) and in LO 6.3.0.0.alpha1+.
I think the behavior isn't OK but for me this is the minor problem.

The greater problem is:
2. When all entries in filter entry list are marked as selected I would expect that as result of a click on OK all rows are shown.
This works correctly in LO 6.2, last test was made with
Version: 6.2.5.0.0+ (x64)
Build ID: 474bef8e06ee514c4ff751b64ef395a54987bd7d
CPU threads: 4; OS: Windows 10.0; UI render: GL; VCL: win; 
TinderBox: Win-x86_64@42, Branch:libreoffice-6-2, Time: 2019-05-30_23:49:53
Locale: de-DE (de_DE); UI-Language: en-US
Calc: threaded 
In LO 6.3 after a click on OK the same rows are shown as before means only these rows which values in column D correspond the filter condition.
Last test was made with
Version: 6.3.0.0.alpha1+ (x64)
Build-ID: 2574ce0f2dc711e71b4799bbd76d5d8b6ec04300
CPU-Threads: 4; BS: Windows 10.0; UI-Render: GL; VCL: win; 
TinderBox: Win-x86_64@62-TDF, Branch:master, Time: 2019-05-29_22:36:58
Gebietsschema: de-DE (de_DE); UI-Sprache: de-DE
Calc: threaded
Comment 1 raal 2019-06-17 18:45:18 UTC
Bisected point 2. This seems to have begun at the below commit.
Adding Cc: to Serge Krot ; Could you possibly take a look at this one?
Thanks
 31fbd00c6bccdffb921ec74f745d775e15d105be is the first bad commit
commit 31fbd00c6bccdffb921ec74f745d775e15d105be
Author: Jenkins Build User <tdf@pollux.tdf>
Date:   Fri Apr 12 20:22:22 2019 +0200

    source 4e7e3670c31329d60f5cc782abc4568c2aba33a7
    
author	Serge Krot <Serge.Krot@cib.de>	2019-03-05 17:03:31 +0100
committer	Thorsten Behrens <Thorsten.Behrens@CIB.de>	2019-04-12 11:46:58 +0200
commit 4e7e3670c31329d60f5cc782abc4568c2aba33a7 (patch)
tree 0e962c50607a049634400d32c0d96871427c9fc9
parent 0342562261beede5d3bb2e43c08f6d0f216ff97c (diff)
tdf#117276 sc: autofilter was unexpected reset with OK pressed
Comment 2 Gabor Kelemen (allotropia) 2022-06-29 07:37:27 UTC
Created attachment 181009 [details]
Screenshot of the example file in Calc and its xlsx version in Excel

Excel does not show the checkboxes unchecked in such a situation.
Instead there is a submenu with "Text Filters" and that is checked, then the condition used (if it's a single condition).

Calc does not have an option to show a checkbox in the autofilter menu for submenus, but probably should. This would be useful for the Filter by Color submenu, to indicate there is something set THERE.

At the same time if there is a color filter set (such as for yellow cell background in column G), the checkboxes are also all deleted. So we could do that at the least.
Comment 3 QA Administrators 2024-06-29 03:16:03 UTC Comment hidden (obsolete)
Comment 4 Stefan_Lange_KA@T-Online.de 2024-07-06 10:51:31 UTC
(In reply to QA Administrators from comment #3)
> Dear Stefan_Lange_KA@T-Online.de,
> 
> To make sure we're focusing on the bugs that affect our users today,
> LibreOffice QA is asking bug reporters and confirmers to retest open,
> confirmed bugs which have not been touched for over a year.
> 
> There have been thousands of bug fixes and commits since anyone checked on
> this bug report. During that time, it's possible that the bug has been
> fixed, or the details of the problem have changed. We'd really appreciate
> your help in getting confirmation that the bug is still present.
> 
> If you have time, please do the following:
> 
> Test to see if the bug is still present with the latest version of
> LibreOffice from https://www.libreoffice.org/download/
> 
> If the bug is present, please leave a comment that includes the information
> from Help - About LibreOffice.
>  
> If the bug is NOT present, please set the bug's Status field to
> RESOLVED-WORKSFORME and leave a comment that includes the information from
> Help - About LibreOffice.
> 
> Please DO NOT
> 
> Update the version field
> Reply via email (please reply directly on the bug tracker)
> Set the bug's Status field to RESOLVED - FIXED (this status has a particular
> meaning that is not 
> appropriate in this case)
> 
> 
> If you want to do more to help you can test to see if your issue is a
> REGRESSION. To do so:
> 1. Download and install oldest version of LibreOffice (usually 3.3 unless
> your bug pertains to a feature added after 3.3) from
> https://downloadarchive.documentfoundation.org/libreoffice/old/
> 
> 2. Test your bug
> 3. Leave a comment with your results.
> 4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
> 4b. If the bug was not present in 3.3 - add 'regression' to keyword
> 
> 
> Feel free to come ask questions or to say hello in our QA chat:
> https://web.libera.chat/?settings=#libreoffice-qa
> 
> Thank you for helping us make LibreOffice even better for everyone!
> 
> Warm Regards,
> QA Team
> 
> MassPing-UntouchedBug

Newly tested with
Version: 24.8.0.0.beta1+ (X86_64) / LibreOffice Community
Build ID: 9bb643b18a6c2440b02c71ddb10f713d11448589
CPU threads: 4; OS: Windows 11 X86_64 (10.0 build 22635); UI render: Skia/Raster; VCL: win
Locale: de-DE (de_DE); UI: de-DE
Calc: threaded
and
Version: 24.2.5.1 (X86_64) / LibreOffice Community
Build ID: 2ccb78ad6bdfe3f3356a7a7f294ec388775c5816
CPU threads: 4; OS: Windows 10.0 Build 22635; UI render: Skia/Raster; VCL: win
Locale: de-DE (de_DE); UI: de-DE
Calc: CL threaded

Result:
Problem 1 only exists when an "older" document is opened (created with older LO Version) e.g. the attached document "Testtabelle_Filter_V1a.ods" (created 2019-06-02 with LO 6.x) but not when a document created with LO 24.x is opened.
Problem 2 only exists when an "older" document is opened and filter condition is not changed before OK.

Both is acceptable for me.