Bug 125790 - Setting language via menu and then clearing direct formatting resets paragraph style
Summary: Setting language via menu and then clearing direct formatting resets paragrap...
Status: RESOLVED DUPLICATE of bug 73483
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
6.2.3.2 release
Hardware: All All
: medium normal
Assignee: Not Assigned
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-06-07 16:37 UTC by cybermonktitan
Modified: 2023-11-03 10:36 UTC (History)
2 users (show)

See Also:
Crash report or crash signature:


Attachments
Test document in which the issue occurs (22.04 KB, application/vnd.oasis.opendocument.text)
2019-06-25 16:06 UTC, cybermonktitan
Details

Note You need to log in before you can comment on or make changes to this bug.
Description cybermonktitan 2019-06-07 16:37:36 UTC
Description:
Setting the language for the entire document in OO Writer, or for a partial selection, breaks the behaviour of removing direct formatting for the part that has its language changed: subsequently removing direct formatting from the entire document reset the paragraph style of each paragraph. This destructive operation is only visible on save/reload.

Interestingly this effect only occurs when an already listed language from the menu is chosen and now when the language is selected via the dialog (More... menu option). Changing the language of the selection or the entire document triggers this bug, but changing the paragraph language seems not to be affected.

Steps to Reproduce:
1. Create a simple document with, say, 5 paragraphs of lorem ipsum
2. Assign each paragraph the text body style (Ctrl+A, Ctrl+0)
3. Save, Close, Re-Open
4. Perform either 4a or 4b
4a. Click Tools->Language->For All Text->[A listed language]
4b. Select the mid three paragraphs, click Tools->Language->For Selection->[A listed language]
5. Remove direct formatting from all text: Ctrl+A, Ctrl+M
5a. Observe: no changes
6. Save (Ctrl+S), Close, Re-Open
7. Observe the reset of the styles

Actual Results:
The paragraph style of the paragraphs that have their language 'changed' (even if it's the same as before) are reset to the default style.

Expected Results:
No paragraph styles are affected.


Reproducible: Always


User Profile Reset: No



Additional Info:
Versie: 6.2.4.2 (x64)
Build ID: 2412653d852ce75f65fbfa83fb7e7b669a126d64
CPU-threads: 8; Besturingssysteem: Windows 10.0; UI-render: standaard; VCL: win; 
Locale: nl-NL (nl_NL); UI-taal: nl-NL
Calc: threaded

Version: 6.2.3.2 (x64)
Build ID: aecc05fe267cc68dde00352a451aa867b3b546ac
CPU threads: 4; OS: Windows 10.0; UI render: default; VCL: win; 
Locale: en-US (en_NL); UI-Language: en-GB
Calc: threaded
Comment 1 raal 2019-06-23 08:43:13 UTC
No repro with Version: 6.4.0.0.alpha0+
Build ID: 9712f5d2316fa469b92f2f8092925e2cd4e8dd5b
CPU threads: 4; OS: Linux 4.15; UI render: default; VCL: x11; 

Please send us a sample document, as this makes it easier for us to verify the bug. I have set the bug's status to 'NEEDINFO', so please do change it back to 'UNCONFIRMED' once you have attached a document.
(Please note that the attachment will be public, remove any sensitive information before attaching it.)
How can I eliminate confidential data from a sample document?
https://wiki.documentfoundation.org/QA/FAQ#How_can_I_eliminate_confidential_data_from_a_sample_document.3F
Thank you
Comment 2 cybermonktitan 2019-06-25 16:06:24 UTC
Created attachment 152399 [details]
Test document in which the issue occurs

The Test.odt document is effectively steps 1 through 3 of the reproduction. Opening it and executing steps 4+ should show the problem (it does for me).
Comment 3 cybermonktitan 2019-06-25 16:57:08 UTC
Additional testing under Linux VM (Kubuntu 18.04) gave interesting results.


Reproduction in:

Version: 6.0.7.3
Build ID: 1:6.0.7-0ubuntu0.18.04.6
CPU threads: 1; OS: Linux 4.18; UI render: default; VCL: kde4; 
Locale: en-US (en_US.UTF-8); Calc: group

Version: 6.2.4.2
Build ID: 2412653d852ce75f65fbfa83fb7e7b669a126d64
CPU threads: 1; OS: Linux 4.18; UI render: default; VCL: kde5; 
Locale: en-US (en_US.UTF-8); UI-Language: en-US
Calc: threaded


NO reproduction in:

Version: 6.3.0.0.beta2
Build ID: 6c6edded7133daf2d8d0b2ea7ae25b8109c5c064
CPU threads: 1; OS: Linux 4.18; UI render: default; VCL: kde5; 
Locale: en-US (en_US.UTF-8); UI-Language: en-US
Calc: threaded


But there is nothing in the release notes that indicates any changes to this functionality - or at least none that I can spot.

While this bug seems to have somehow been fixed in 6.3 I feel uncomfortable not knowing the root cause of a data-destructive bug. As a developer I've seen bugs being hidden too often :(
Comment 4 Dieter 2019-06-29 09:04:48 UTC
Result in LO 6.4.5.1

1. Paragraph style is text body
2. I changed language of ducument to latin
3. STRG+A , STRG+M => no changes (paragraph style is still text body)
4. Save, close and reopen
5. Paragraph style changed to Default Style; language is still Latin

Result in Lo 6.4.0.0

1. Paragraph style is text body
2. I changed language of ducument to latin
3. STRG+A , STRG+M => no changes (paragraph style is still text body)
4. Save, close and reopen
5. Paragraph style is still Text Body; language changed back to English

For me both results are not the desired result. So it looks like that the reported bug is fixed in master, but a new bug occurred?
Comment 5 Dieter 2019-10-27 17:02:50 UTC
Reported bug is also not reproducible in

Version: 6.4.0.0.alpha1 (x64)
Build ID: cc57df8f942f239d29cb575ea5a7cb01405db787
CPU threads: 4; OS: Windows 10.0 Build 18362; UI render: GL; VCL: win; 
Locale: de-DE (de_DE); UI-Language: en-US
Calc: threaded

=> RESOLVED WORKSFORME

There is still the change of the language, but that's a different issue.
Comment 6 Mike Kaganski 2023-11-03 10:36:59 UTC
It was initially improved by the change made in bug 47471 (in v.6.3). But the real problem was bug 73483.

*** This bug has been marked as a duplicate of bug 73483 ***