Created attachment 152085 [details] Backtrace of the crash Current master Writer crashes when trying to customize the Data View toolbar (View - Data Sources). 1, Open Writer, select View - Data Sources. The data source browser appears. 2, Right click the toolbar and choose Customize toolbar. 3, Crash. Happens with my current master build: Version: 6.4.0.0.alpha0+ Build ID: 03d33ba9410433d2072364b3afb9dbd6b19c4d0d CPU threads: 4; OS: Linux 4.15; UI render: default; VCL: gtk3; Locale: hu-HU (hu_HU.UTF-8); UI-Language: en-US Calc: threaded Also in bibisect-linux-64-6.3: Version: 6.3.0.0.alpha1+ Build ID: 53325b40b557cc84d8d21c1baa0ef8d3bfc00ab8 CPU threads: 4; OS: Linux 4.15; UI render: default; VCL: gtk3; Locale: hu-HU (hu_HU.UTF-8); UI-Language: en-US Calc: threaded But not with 6.0 on Ubuntu 18.04: Verzió: 6.0.7.3 Build az.: 1:6.0.7-0ubuntu0.18.04.6 CPU szálak: 4; OS: Linux 4.15; Felületmegjelenítés: alapértelmezett; VCL: gtk3; Területi beállítások: hu-HU (hu_HU.UTF-8); Calc: group
Reproduced in Versión: 6.2.4.2 Id. de compilación: 2412653d852ce75f65fbfa83fb7e7b669a126d64 Subprocs. CPU: 1; SO: Windows 6.1; Repres. IU: predet.; VCL: win; Configuración regional: es-ES (es_ES); Idioma de IU: es-ES Calc: threaded
Regression introduced by: https://cgit.freedesktop.org/libreoffice/core/commit/?id=a21744a72637a2e3044f55450df85f94a9fc0bf9 author Muhammet Kara <muhammet.kara@pardus.org.tr> 2018-03-07 12:39:02 +0300 committer Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> 2018-03-12 12:13:27 +0100 commit a21744a72637a2e3044f55450df85f94a9fc0bf9 (patch) tree 7f4aed0967f33de092932129a830fe0e991f5be0 parent 2cc2f9fa4b98eaf47ae1e8fecdfb916ed8038622 (diff) tdf#114260: Add gear button to Customize dialog Bisected with: bibisect-linux64-6.1 Adding Cc: to Muhammet Kara
Weird bug. Could you please confirm that this toolbar was customizable in 6.0? (I don't see it in the Toolbars list on the Customize dialog.)
Created attachment 152093 [details] How it looks in LibreOffice 5.4 This is what is displayed when clicking on customize in LibreOffice 5.4
Muhammet Kara committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/+/b25186b6701f0770127b38ecd7744901d2c5fe72%5E%21 Resolves tdf#125840: Crash when trying to customize Base Data View toolbar It will be available in 6.4.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Muhammet Kara committed a patch related to this issue. It has been pushed to "libreoffice-6-3": https://git.libreoffice.org/core/+/f8a53414c4d0cc7e1077b61a8e8bd55cafe3ac03%5E%21 Resolves tdf#125840: Crash when trying to customize Base Data View toolbar It will be available in 6.3.0.1. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Verified in Version: 6.4.0.0.alpha0+ Build ID: ee4823e16e5fece068ee123b9c3e29834cd38763 CPU threads: 4; OS: Linux 4.15; UI render: default; VCL: gtk3; Locale: ca-ES (ca_ES.UTF-8); UI-Language: en-US Calc: threaded @Muhammet, thanks for fixing this issue!!
@Muhammet, any chance this could be bisected to 6.2 branch ?
(In reply to Xisco Faulí from comment #7) > Verified in > > Version: 6.4.0.0.alpha0+ > Build ID: ee4823e16e5fece068ee123b9c3e29834cd38763 > CPU threads: 4; OS: Linux 4.15; UI render: default; VCL: gtk3; > Locale: ca-ES (ca_ES.UTF-8); UI-Language: en-US > Calc: threaded > > @Muhammet, thanks for fixing this issue!! My pleasure! :) (In reply to Xisco Faulí from comment #8) > @Muhammet, any chance this could be bisected to 6.2 branch ? Do you mean backported? I am afraid it causes a merge conflict. I can take a look to see if I can cook up a quick fix for the 6.2 branch though.
Here is the patch, but I created it directly on Gerrit so it needs to be tested on 6.2 by someone (I don't have time myself atm): https://gerrit.libreoffice.org/#/c/73958/
(In reply to Muhammet Kara from comment #10) > Here is the patch, but I created it directly on Gerrit so it needs to be > tested on 6.2 by someone (I don't have time myself atm): > https://gerrit.libreoffice.org/#/c/73958/ It works. :)
Muhammet Kara committed a patch related to this issue. It has been pushed to "libreoffice-6-2": https://git.libreoffice.org/core/+/c98b7c9e75a951012d6693f5adecb1ff0e1f8f6b%5E%21 Resolves tdf#125840: Crash when trying to customize Base Data View toolbar It will be available in 6.2.5. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.