Bug 126166 - Command labels for Select to Start of Word, select to End of Word need correction
Summary: Command labels for Select to Start of Word, select to End of Word need correc...
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
6.3.0.0.beta1+
Hardware: All All
: medium normal
Assignee: Shubham Jain
URL:
Whiteboard: target:7.2.0 target:7.1.0.0.beta2
Keywords: difficultyBeginner, easyHack, skillDesign, topicUI
Depends on:
Blocks:
 
Reported: 2019-06-30 01:39 UTC by TorrAB
Modified: 2020-11-23 18:53 UTC (History)
4 users (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description TorrAB 2019-06-30 01:39:17 UTC
Under Tools>Customize>Keyboard, Category
	Frame: there are 2 functions named 'In background';
	Insert: there are 2 functions named 'Formula'
	Navigate: functions 'Select to…' have inconsistent names;
'Select to Document Begin' and 'Select to Document end' are consecutive —good (except that 'Begin' should be 'Beginning').
But there is no 'Select to End of Word' to match 'Select to Begin of Word'; one has to go way down to 'Select to Word right'; they should be renamed 'Select to Word Beginning' and 'Select to Word End'.
Comment 1 V Stuart Foote 2019-06-30 02:57:42 UTC
The first issue is being looked at as bug 108458

The Select to Beginning of Word/Select to Ending of Word labels are translatable, and the en-US labels in WriterCommands.xcu could use a tweak.

The commands are 

.uno:WordLeftSel labeled "en-US" as "Select to Begin of Word" [1]

.uno:WordRightSel labeled "en-US" "Select to Word Right" [2]

IIUC the syntax is reversed for RTL scripts, so should probably be WordStartSel and WordEndSel, with a change to command label reflecting start and end.

=-ref-=
[1] https://opengrok.libreoffice.org/xref/core/officecfg/registry/data/org/openoffice/Office/UI/WriterCommands.xcu?r=533dec5a#1105 
[2] https://opengrok.libreoffice.org/xref/core/officecfg/registry/data/org/openoffice/Office/UI/WriterCommands.xcu?r=533dec5a#1100
Comment 2 V Stuart Foote 2019-06-30 13:10:47 UTC
The edit engine commands for word bounded selection linked as .uno from impedit2.cxx here:

https://opengrok.libreoffice.org/xref/core/editeng/source/editeng/impedit2.cxx?&r=a682d129&h=1412#1480

So UNO command name, and command labeling listed in comment 1, should probably reflect that context of Start / End to complement the command for selecting the word.
Comment 3 Heiko Tietze 2019-07-11 18:15:40 UTC
Don't think we need UX input here, it's just a bug. We had a couple of similar issues. 

Thanks for code pointers, Stuart.
Comment 4 Maxim Monastirsky 2019-07-12 09:12:01 UTC
(In reply to V Stuart Foote from comment #2)
> So UNO command name, and command labeling listed in comment 1, should
> probably reflect that context of Start / End to complement the command for
> selecting the word.
Except that .uno command names shouldn't be changed, only the labels. Changing command names will break existing customization and macros.
Comment 5 Commit Notification 2020-11-23 11:52:20 UTC
shubham656 committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/a430547ed6f543fd5f0f5ed6a804f4b7bc976065

tdf#126166 Change the command label for "uno:WordRightSel"

It will be available in 7.2.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 6 Commit Notification 2020-11-23 18:53:19 UTC
shubham656 committed a patch related to this issue.
It has been pushed to "libreoffice-7-1":

https://git.libreoffice.org/core/commit/eae8454462854a95da45e00f84359858be01ab12

tdf#126166 Change the command label for "uno:WordRightSel"

It will be available in 7.1.0.0.beta2.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.