Bug 126179 - Inserting text/table from .pdf (only from Adobe Acrobat Reader) and then pressing Ctrl + Z causes a crash.
Summary: Inserting text/table from .pdf (only from Adobe Acrobat Reader) and then pres...
Status: NEW
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: LibreOffice (show other bugs)
Version:
(earliest affected)
6.1.0.3 release
Hardware: All Windows (All)
: high major
Assignee: Not Assigned
URL:
Whiteboard:
Keywords: bibisected, bisected, regression
: 134693 (view as bug list)
Depends on:
Blocks: Undo-Redo
  Show dependency treegraph
 
Reported: 2019-07-01 15:41 UTC by Aleksandr
Modified: 2021-09-11 02:03 UTC (History)
6 users (show)

See Also:
Crash report or crash signature: ["SwPosition::SwPosition(SwNode const &)"]
Regression By:


Attachments
.pdf with table that caused the crash. (6.92 MB, application/pdf)
2019-07-01 15:43 UTC, Aleksandr
Details
how to select the table (261.85 KB, image/png)
2019-07-01 15:45 UTC, Aleksandr
Details
document with pasted table from pdf (6.00 KB, application/vnd.openxmlformats-officedocument.wordprocessingml.document)
2019-07-03 13:07 UTC, Aleksandr
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Aleksandr 2019-07-01 15:41:54 UTC
Description:
While reading the .pdf file I've decided to insert into the .docx a table from .pdf. The table was inserted and after that, I decided to press Ctrl + Z (undo) and a crash occurred.

Steps to Reproduce:
1. Open .pdf file called "Многопользовательские игры. Разработка сетевых приложений.pdf" which is attached.
2. Go to page 114 and copy table on this page like on the attached screenshot.
3. Paste it in the .docx file (even empty .docx file will be fine) opened in the LibreOffice Writer.
4. Press Ctrl + Z (undo).

Actual Results:
Crash.

Expected Results:
Delete pasted table.


Reproducible: Always


User Profile Reset: Yes



Additional Info:
Crash report link: http://crashreport.libreoffice.org/stats/crash_details/1561e036-3a27-47f1-b5a8-5b40813f3705.

As it says you got EXCEPTION_ACCESS_VIOLATION_READ.
Seems like you guys messed up with indexes or read something out of bounds. I get this exception in C++ after these things but you know your software better than me so...

Help - About LibreOffice:

Версия: 6.2.4.2 (x64)
ID сборки: 2412653d852ce75f65fbfa83fb7e7b669a126d64
Потоков ЦП: 4; ОС:Windows 10.0; Отрисовка ИП: по умолчанию; VCL: win; 
Локаль: ru-RU (ru_RU); Язык UI: ru-RU
Calc: threaded

translating to English would be something like this:

Version: 6.2.4.2 (x64)
ID build: 2412653d852ce75f65fbfa83fb7e7b669a126d64
Threads: 4; OS:Windows 10.0; Отрисовка ИП: default; VCL: win; 
Locale: ru-RU (ru_RU); Language UI: ru-RU
Calc: threaded
Comment 1 Aleksandr 2019-07-01 15:43:41 UTC
Created attachment 152489 [details]
.pdf with table that caused the crash.
Comment 2 Aleksandr 2019-07-01 15:45:59 UTC
Created attachment 152490 [details]
how to select the table
Comment 3 Roman Kuznetsov 2019-07-01 20:22:02 UTC
Alexandr, how do you paste a table in to document? I mean just Ctrl+V or may be Paste Special or anything else?

Can you rename user profile or start LibreOffice in Safe mode (Help->Restart in Safe mode) and then retest your problem?

I can't repro it in

Версия: 6.2.4.2 (x64)
ID сборки: 2412653d852ce75f65fbfa83fb7e7b669a126d64
Потоков ЦП: 4; ОС:Windows 10.0; Отрисовка ИП: GL; VCL: win; 
Локаль: ru-RU (ru_RU); Язык UI: ru-RU
Calc: threaded

I tried to open PDF in Firefox and in PDF-XChange viewer.
Comment 4 Aleksandr 2019-07-02 05:59:47 UTC
Yes, I tried the safe mode, and now, after restarting my laptop, I tried it again (same result).
I just copied the table like on the screenshot pressed Ctrl + V in LibreOffice Writer (empty document) and right after that, I pressed Ctrl + Z.
I use Adobe Acrobat Reader DC for .pdf (version in 'Help - Check for Updates' is: 19.012.20035).
You have "Отрисовка ИП: GL" change it to 'default' because I have it so.
Comment 5 Xisco Faulí 2019-07-02 11:34:51 UTC
Hello Aleksandr,
Does it happen if the pdf is open with another software different than Adobe Acrobat ?
Comment 6 Aleksandr 2019-07-02 12:34:56 UTC
No, apparently this happens only when using Adobe Reader.
Comment 7 Roman Kuznetsov 2019-07-02 13:47:51 UTC
confirm in

Версия: 6.2.4.2
ID сборки: 2412653d852ce75f65fbfa83fb7e7b669a126d64
Потоков ЦП: 4; ОС:Windows 6.1; Отрисовка ИП: по умолчанию; VCL: win; 
Локаль: ru-RU (ru_RU); Язык UI: ru-RU
Calc: threaded

it happens when copy from Adobe Reader and paste to new LO Writer document and undoing with Crt+Z 

I copy/pasted simple text from PDF

crashreport.libreoffice.org/stats/crash_details/f6de3595-420b-4a44-bbdb-0b42ff5cf1e1
Comment 8 Xisco Faulí 2019-07-03 12:47:47 UTC
Hi Aleksandr, Roman,
Could you please save the document once you paste the content from the pdf and share it here ?
Comment 9 Aleksandr 2019-07-03 13:07:41 UTC
Created attachment 152532 [details]
document with pasted table from pdf
Comment 10 Xisco Faulí 2019-07-03 13:57:43 UTC
What happens if you enable Track changes ( Edit - Track Changes - Record ), then you paste the content and finally you reject all changes ( Edit - Track changes - Reject all ), does it crash  as well ?
Comment 11 Aleksandr 2019-07-03 17:10:28 UTC
No, it does not crash. Record, paste, reject all - no crash.
Comment 12 Buovjaga 2019-07-03 17:32:31 UTC
(In reply to Aleksandr from comment #11)
> No, it does not crash. Record, paste, reject all - no crash.

With this, it does not crash. Otherwise it crashes.

Version: 6.4.0.0.alpha0+ (x64)
Build ID: 25bf2c5c0074fbcc162c02593d896705e225b5b5
CPU threads: 4; OS: Windows 10.0; UI render: default; VCL: win; 
TinderBox: Win-x86_64@42, Branch:master, Time: 2019-07-03_06:33:11
Locale: fi-FI (fi_FI); UI-Language: en-US
Calc: threaded
Comment 13 Xisco Faulí 2019-07-04 11:00:07 UTC
I've just tried with foxit reader but it doesn't crash...
Comment 14 Buovjaga 2019-07-11 16:40:54 UTC
Bibisected with win32-6.1 to https://gerrit.libreoffice.org/plugins/gitiles/core/+/deaa16bd24fba4a3a6b072ab2b94542a7dbd41c6%5E!/

tdf#72942 Do not overwrite styles from the inserted doc

During inserting of the text from the external document
we should not change original default styles in
currently opened document.

Adding Cc: to Serge Krot
Comment 15 Buovjaga 2019-07-11 16:41:54 UTC
The difference between the problematic commit and preceding is that in the preceding, the pasted result is a table. With the problematic one, straight up text is pasted.
Comment 16 Justin L 2021-01-15 12:18:47 UTC
This sounds identical to bug 134693 except that it bibisects to a different commit.
Comment 17 Justin L 2021-01-15 12:23:15 UTC
*** Bug 134693 has been marked as a duplicate of this bug. ***