Bug 126189 - Enhance autofill to better sense data blocks with empty cells or columns
Summary: Enhance autofill to better sense data blocks with empty cells or columns
Status: NEW
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Calc (show other bugs)
Version:
(earliest affected)
Inherited From OOo
Hardware: All All
: low enhancement
Assignee: Not Assigned
URL: https://help.libreoffice.org/6.4/en-U...
Whiteboard:
Keywords:
Depends on:
Blocks: AutoFill
  Show dependency treegraph
 
Reported: 2019-07-02 09:36 UTC by Timur
Modified: 2019-08-28 10:10 UTC (History)
5 users (show)

See Also:
Crash report or crash signature:


Attachments
Autofill test ODS (13.34 KB, application/x-vnd.oasis.opendocument.spreadsheet)
2019-08-28 10:10 UTC, Timur
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Timur 2019-07-02 09:36:51 UTC
This is an enhancement request for autofill to better sense data blocks with double click, as seen in MSO since 2013.
See examples in ODS attachment 152498 [details]. 

Double click on H1 fills up to H2, because previous column has some empty cells,  instead of up to H10.
Double click on M1 doesn’t fill to M10, because previous column is empty.
Comment 1 Jacques Guilleron 2019-07-06 15:32:01 UTC
Hi Timur,

Can't verify in Excel, I have 2010 version,
but I agree this enhancement.

Jacques
Comment 2 V Stuart Foote 2019-07-06 17:41:08 UTC
While I can agree the autofill logic and its behavior handling empty cells needs consistency--and so requires ongoing review--it is not clear this "enhancement" (nor that of bug 66890) is merited to try to match MS Office 2013 (or later) nor any other spreadsheet offering.  

IIUC it would require rework of what has been functional autofill logic inherited from OOo, that while conservative protects user sheet data.

Since from the LO perspective, we already do the correct thing, no need to chase other implementations. IMHO => WF
Comment 3 Timur 2019-07-08 06:43:18 UTC
I don't think this enhancement is related to bug 66890 nor that it jeopardizes user sheet data. Per attached example, it simply better fill empty cells. 
Enhancements like this one are better to have because they can be done sometimes and they can be found as noted, in case someone searches. They are still at Low.
Comment 4 Heiko Tietze 2019-07-12 11:18:20 UTC
Right now the autofill functions works transparently on the left column and fills data until the next empty cell (great example, btw). Any modification to this logic makes it hard to understand. For example, "if left column is empty take the next" or "if only one cell is empty take the next down". Users will not understand the logic behind. My take is WFM.
Comment 5 Eike Rathke 2019-07-15 12:02:57 UTC
Just for completeness: if there is no data immediately to the left then autofill looks for data immediately to the right.
Comment 6 Heiko Tietze 2019-07-18 05:30:48 UTC
Double-checked MSO and the logic is simple: fill if either the left cell has content or the cell next to it (and as Eike mentioned right when left is empty).

This would be filled from C1:C4 (3 7):

A B C
1 5
2
  6
3 7

4 8
Comment 7 Eike Rathke 2019-07-18 12:31:43 UTC
Thanks for checking. What does it do if A1 is empty (assuming that we start filling with value x that is missing in your context/layout)

A B C
  5 x
2
  6
3 7

4 8

And what if B1 is empty instead?

A B C
1   x
2
  6
3 7

4 8
Comment 8 Heiko Tietze 2019-07-22 08:40:32 UTC
(In reply to Eike Rathke from comment #7)
> What does it do if A1 is empty...

It's filled from C1:C4

> And what if B1 is empty instead?

No cells are filled in this case. 

So the rule is: a) left (or right) is filled at the starting cell and b1) left (or right) and one more column has a value.

A B C D
    1 x
  2
3
    4
  5
6

is filled from C1:C6. Tested with more columns and it works as well unless there is a gap. So

A B C D
      1
    2
3
  4
    5

is just filled from C1:C2.
Comment 9 Timur 2019-08-28 10:10:17 UTC
Created attachment 153702 [details]
Autofill test ODS

Au lieu of attachment 152498 [details], I attach ODS with all those examples.