Bug 126205 - File format conversion doesn't work with rename workflow
Summary: File format conversion doesn't work with rename workflow
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice Online
Classification: Unclassified
Component: LibreOffice (show other bugs)
Version:
(earliest affected)
unspecified
Hardware: Other other
: medium normal
Assignee: Not Assigned
URL:
Whiteboard: target:6.4.0
Keywords: bibisected, regression
Depends on:
Blocks:
 
Reported: 2019-07-03 08:47 UTC by Andreas Gruhler
Modified: 2020-06-23 15:23 UTC (History)
2 users (show)

See Also:
Crash report or crash signature:


Attachments
loolwsd error log (1.06 KB, text/x-log)
2019-07-03 08:48 UTC, Andreas Gruhler
Details
Video to reproduce document conversion error on Nextcloud16 (335.73 KB, video/mp4)
2019-07-03 08:48 UTC, Andreas Gruhler
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Andreas Gruhler 2019-07-03 08:47:54 UTC
Description:
A *.dotx word template can be converted with Nextcloud15 by:
 1. opening the template file in Collabora Online (read-only)
 2. renaming the file to *.docx in the input field on the top
 3. closing the file

The *.docx file is created from the template and visible in the Nextcloud file list. However, this does not work in combination with Nextcloud16. The file is not created from the template.

Please find the error log and a video attached.

Steps to Reproduce:
1. open a template file in Collabora Online (read-only)
2. rename the file to *.docx in the input field on the top
3. close the template file

Actual Results:
1. the template is opened read-only in Collabora Online
2. the filename changes to "*(2).dotx", but is not actually renamed to .docx
3. no *.docx is created from the template

Expected Results:
1. the template is opened read-only in Collabora Online
2. the filename changes to "*.docx"
3. the *.docx file is created from the template and visible in the Nextcloud file list


Reproducible: Always


User Profile Reset: No



Additional Info:
attached:
- loolwsd error log
- video to reproduce the steps

version information:
- Nextcloud:         16.0.1.1
- loolwsd:           4.0.4 (git hash: 305832f)
- Collabora Office:  6.0-29 (git hash: 5a695a1)
Comment 1 Andreas Gruhler 2019-07-03 08:48:15 UTC
Created attachment 152519 [details]
loolwsd error log
Comment 2 Andreas Gruhler 2019-07-03 08:48:56 UTC
Created attachment 152520 [details]
Video to reproduce document conversion error on Nextcloud16
Comment 3 Aron Budea 2019-08-20 02:24:41 UTC
Indeed, the problem occurs with any kind of format conversion, eg. even when changing the extension of an ODT to DOCX.

Seems what happens is that LOOL treats this as a file rename, too, while it should save the converted file under a new name, but keep the original as well (which was the old behavior).

This started with the introduction of RENAME_FILE support in the following commits:
https://cgit.freedesktop.org/libreoffice/online/commit/?id=0dbf9bcf27155fa846977bdf0b8e990e0bc07211
https://cgit.freedesktop.org/libreoffice/online/commit/?id=e386427639106e6dbe34b70b0ac61aa037bf60bc
https://cgit.freedesktop.org/libreoffice/online/commit/?id=6b0f0432cbf219efb223eb07427ee9b4745a9bd5
+
https://github.com/nextcloud/richdocuments/commit/a710c3cde3d78e8662ef0e9932679f05c1069b8c
Comment 4 Commit Notification 2019-10-04 20:23:50 UTC
merttumer committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/online/commit/efdc5dbc0894edbb3c3bfa1dc61dedaf0ee26a8e

tdf#126205: Fix file format conversion on rename input
Comment 5 Aron Budea 2019-10-10 04:41:17 UTC
This issue is resolved, thanks to Mert Tümer for the fix.