# Steps to reproduce 1. Open `lowriter` or `localc` (reproducible in either) 2. Go to Tools → Macros → Edit Macros 3. Now, a macros editing window should appear. There, click the button that says "New" on it. ## Expected A new empty macro should get created (probably should ask first about the language a user wants to use) ## Actual An empty "lowriter" window gets opened (it works the same even if you followed the steps in "localc")
(In reply to Konstantin Kharlamov from comment #0) > ## Actual > > An empty "lowriter" window gets opened (it works the same even if you > followed the steps in "localc") i can not confirm this with: Version: 6.2.5.2 (x64) Build ID: 1ec314fa52f458adc18c4f025c545a4e8b22c159 CPU threads: 4; OS: Windows 10.0; UI render: default; VCL: win; Locale: de-DE (de_DE); UI-Language: en-US Calc: opens a macro editing window with - My Macros & Dialogs - Standard - Module1 Sub Main End Sub
(In reply to Oliver Brinzing from comment #1) > (In reply to Konstantin Kharlamov from comment #0) > > ## Actual > > > > An empty "lowriter" window gets opened (it works the same even if you > > followed the steps in "localc") > > i can not confirm this with: > > Version: 6.2.5.2 (x64) > Build ID: 1ec314fa52f458adc18c4f025c545a4e8b22c159 > CPU threads: 4; OS: Windows 10.0; UI render: default; VCL: win; > Locale: de-DE (de_DE); UI-Language: en-US > Calc: > > opens a macro editing window with > > - My Macros & Dialogs > - Standard > - Module1 > Sub Main > End Sub Are you sure you followed the steps correctly? I recorded a video over here https://youtu.be/m11cwKqgftc is it not what you see? (P.S.: nvm the broken panel it just glitched out. I'm on my way fixing a local KDE installation)
(In reply to Konstantin Kharlamov from comment #2) > Are you sure you followed the steps correctly? I recorded a video over here > https://youtu.be/m11cwKqgftc is it not what you see? the "New" icon is for creating new documuments, not form macro libs/modules if you want to add a new basic module: - create a new document - Menu Tools/Macros/Organize Macros/Libreoffice Basic... - select "Untitled 1" - press [New] button - enter module name - press [OK]
(In reply to Oliver Brinzing from comment #3) > (In reply to Konstantin Kharlamov from comment #2) > > > Are you sure you followed the steps correctly? I recorded a video over here > > https://youtu.be/m11cwKqgftc is it not what you see? > > the "New" icon is for creating new documuments, not form macro libs/modules > > if you want to add a new basic module: > > - create a new document > - Menu Tools/Macros/Organize Macros/Libreoffice Basic... > - select "Untitled 1" > - press [New] button > - enter module name > - press [OK] I understand that this button does not create a new macro. And this is the gist of the report: it's a window specifically for working with macros, and this button either shouldn't be here, or (which would better) it should create a new macro. Otherwise, why would it open an lowriter window? Why not, for example, localc?
Hello Konstantin Kharlamov, A new major release of LibreOffice is available since this bug was reported. Could you please try to reproduce it with the latest version of LibreOffice from https://www.libreoffice.org/download/libreoffice-fresh/ ? I have set the bug's status to 'NEEDINFO'. Please change it back to 'UNCONFIRMED' if the bug is still present in the latest version.
(In reply to Xisco Faulí from comment #5) > Hello Konstantin Kharlamov, > A new major release of LibreOffice is available since this bug was reported. > Could you please try to reproduce it with the latest version of LibreOffice > from https://www.libreoffice.org/download/libreoffice-fresh/ ? > I have set the bug's status to 'NEEDINFO'. Please change it back to > 'UNCONFIRMED' if the bug is still present in the latest version. Still reproducible in 6.3.4.2. Text from "about" window: Version: 6.3.4.2.0+ Build ID: 6.3.4-2 CPU threads: 4; OS: Linux 5.4; UI render: default; VCL: gtk3; Locale: ru-RU (ru_RU.UTF-8); UI-Language: en-US Calc: threaded
(In reply to Konstantin Kharlamov from comment #0) > # Steps to reproduce > > 1. Open `lowriter` or `localc` (reproducible in either) > 2. Go to Tools → Macros → Edit Macros > 3. Now, a macros editing window should appear. There, click the button that > says "New" on it. > > ## Expected > > A new empty macro should get created (probably should ask first about the > language a user wants to use) That is the general tool for new documents. That exists in all modules. You see it too in the Math-Editor and in the Chart-Editor. It behaves the same in all places. Simple click uses the current preselected kind of action, for other actions open the list by clicking on the triangle and select the action. BTW: It is a BASIC IDE, you cannot use it for other programming languages than BASIC. For to get a new "macro", you simple write it. For getting a new module right-click the tabbar and choose item Insert > Basic-Module.
(In reply to Regina Henschel from comment #7) > (In reply to Konstantin Kharlamov from comment #0) > > # Steps to reproduce > > > > 1. Open `lowriter` or `localc` (reproducible in either) > > 2. Go to Tools → Macros → Edit Macros > > 3. Now, a macros editing window should appear. There, click the button that > > says "New" on it. > > > > ## Expected > > > > A new empty macro should get created (probably should ask first about the > > language a user wants to use) > > That is the general tool for new documents. That exists in all modules. You > see it too in the Math-Editor and in the Chart-Editor. It behaves the same > in all places. Simple click uses the current preselected kind of action, for > other actions open the list by clicking on the triangle and select the > action. If opening a new lowriter/localc window is an intended behavior of this button, then IMO it's better to remove it whatsoever. A user can open a new LO instance for example by clicking File → New inside already opened lowriter/local window. Having this button in IDE (and probably in math-editor and chart-editor) only creates a confusion. I don't know what chart-editor looks like, but from the hearing of that I see no reason why I would expect a "New" button not to create a new chart but rather to create an LO instance. Suppose you clicked "New" button inside localc. Do you expect it to open an lowriter instance or localc? If the latter, then this is because buttons inside any given program window should match the functional that this window is intended to provide. I see no reason why it should hold for localc but not for macros-editor or chart-editor.
Then let's submit this to the UX jury
All modules place the shortcut (and default action) on the current module except the macro editor. How about adding Organize Macros (.uno:ScriptOrganizer) in this case?
(In reply to Heiko Tietze from comment #10) > All modules place the shortcut (and default action) on the current module > except the macro editor. How about adding Organize Macros > (.uno:ScriptOrganizer) in this case? I am not sure what dialog you're referring to. I found a submenu like: Tools → Organize Macros → Basic… → BeanShell… → JavaScript… → Python… Did you mean, showing one of the four dialogs here, depending on what language is currently chosen? If yes, then doesn't sound bad to me. I see the dialogs has a "Create" button. Although I don't like the fact that this "Create" button would duplicate functional of the "New" button in the usecase being discussed (i.e. because a user already showed desire to create a new document by pressing "New", there's no need for them to press "Create" in addition to that), but I guess working around that would requires to create a whole new dialog, lots of work. So, I'd say, while not ideal, this is definitely better than the current behavior.
Let's update menu and toolbar and replace the New/Open functions by something that suits better the Basic IDE. Code pointer are: basctl/uiconfig/basicide/menubar/menubar.xml basctl/uiconfig/basicide/toolbar/standardbar.xml
(In reply to Heiko Tietze from comment #12) > Let's update menu and toolbar and replace the New/Open functions by > something that suits better the Basic IDE. > > Code pointer are: > > basctl/uiconfig/basicide/menubar/menubar.xml > basctl/uiconfig/basicide/toolbar/standardbar.xml We already have .uno:MacroDialog and .uno:MacroOrganizer on Standard toolbar. We can just move it to the left side of the toolbar. And (possibly!) we can hide .uno:AddDirect command there And we can add .uno:MacroDialog and .uno:MacroOrganizer into File main menu for Basic IDE and do some reorganize for File menu too What do you think?
(In reply to Roman Kuznetsov from comment #13) > What do you think? Sounds okay, I'd leave it to the doer to decide what functions are suited best on Basic's standard toolbar and main menu. Set difficulty to medium therefore, the hack itself is simple.
If you have Basic IDE open and an document open, and when you then close the document, you do not get the splash screen, but you have only the Basic IDE. So the Basic IDE needs the options to open and to create new documents. Please keep that in mind, when changing the UI of Basic IDE.
I talked with people who uses Basic IDE every day. They don't have problem with current menu or toolbars. They want just addition useful tools, but it's another topic. And I don't like those menu and toolbar changings that I tried do locally
IMO -> WF. The "New *Document*" button is consistent with all modules. Macros are not documents, and New Document does a correct job. A single complaint in all the LibreOffice history (were some similar requests ever in OOo?) does not justify the change.
One change could still possibly be, if the button tooltip changed dynamically to e.g. "New Text Document", "New Spreadsheet", etc. - so not be simply "New".
(In reply to Mike Kaganski from comment #17) > IMO -> WF. The "New *Document*" button is consistent with all modules. There's no such button though, there's a button with a tooltip "New". > Macros are not documents, and New Document does a correct job. What in the world a "New document" button would do in a macro editor? Assuming there would be such button, that would just sound like a bad naming, where someone thought of a macro as a document, perhaps because the macro IDE is inside the Office suite. > A single > complaint in all the LibreOffice history (were some similar requests ever in > OOo?) does not justify the change. Okay, two things. 1. LO is by far not as popular as MS Office, and the auditory for office suites are mostly non-technical people. Many don't know (or just don't care) that you can go report bug for something that works wrong. And a design flaw in the office suite is not something you'd usually report bug for, because, well, it still works, right? So many people just wouldn't do that. This bug was reported when I was living with my ex-gf who had to use LO because MS Office just wouldn't work on Fedora, and you can't imagine HOW MANY complaints I've heard from her about the LO design being terrible. As a programmer I can distinguish complaints of "habitual" type from legit ones, and I'd say 50% of them were legitimate complaints. How many bugreports she created? Zero. I created a few on her behalf though, but wasn't it for me there would be none at all. 2. Let's not come down to that handwaving reasoning "nobody reported, hence it's untrue". If you are working with a macro in a window wholly dedicated to macro editing, what in the world a button for starting a new Spreadsheet would do there? This is insconsistent. Although, if you really up for some overengineering and want to have such buttons in every possible place, at least please name it accordingly "New Spreadsheet" and not just "New".
(In reply to Konstantin Kharlamov from comment #19) > > A single > > complaint in all the LibreOffice history (were some similar requests ever in > > OOo?) does not justify the change. > > 1. LO is by far not as popular as MS Office, and the auditory for office > suites are mostly non-technical people. Many don't know (or just don't care) > that you can go report bug for something that works wrong. ... This is irrelevant. We have so huge user base, that we see how many actual bug reports any *actual* problem gets multiple reports; one can judge the severity of a problem based on how many duplicates there are. And any "people do not file bugs, that's why there's no duplicates" is wrong. If we had a thousand users, it could be justified, but not when they are hundreds of millions. And my comment 18 suggests just that - make the tooltip more specific.
(In reply to Konstantin Kharlamov from comment #19) > This bug was reported when I was living with my ex-gf... > you can't imagine HOW MANY complaints I've heard from her Good decision to rather stay with LibreOffice than the GF ;-) I can follow her confusion and removing the "New" is pretty simple.
(In reply to Heiko Tietze from comment #21) > (In reply to Konstantin Kharlamov from comment #19) > > This bug was reported when I was living with my ex-gf... > > you can't imagine HOW MANY complaints I've heard from her > Good decision to rather stay with LibreOffice than the GF ;-) lol 😂 > I can follow her confusion and removing the "New" is pretty simple. To be clear, this particular report wasn't created on her behalf but solely my initiative. I mentioned her rather as part of the discussion about design issues reports.