Bug 126433 - Add a confirmation for deleting of target in AutoRedaction dialog
Summary: Add a confirmation for deleting of target in AutoRedaction dialog
Status: NEW
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: UI (show other bugs)
Version:
(earliest affected)
6.4.0.0.alpha1+
Hardware: All All
: medium enhancement
Assignee: Not Assigned
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: Redaction
  Show dependency tree / graph
 
Reported: 2019-07-16 16:53 UTC by Roman Kuznetsov
Modified: 2019-09-08 19:30 UTC (History)
3 users (show)

See Also:
Crash report or crash signature:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Roman Kuznetsov 2019-07-16 16:53:05 UTC 
Description:
Add a confirmation for deleting of target in AutoRedaction dialog

Steps to Reproduce:
1. Open AutoRedaction dialog
2. Add any target
3. Try delete target by Delete button => it just silent deletes a target without any question or messages

Actual Results:
deleting without confirmation

Expected Results:
deleting with confirmation


Reproducible: Always


User Profile Reset: No



Additional Info:
-
Comment 1 Heiko Tietze 2019-07-17 03:58:04 UTC 
Confirmation interrupts the workflow, you can undo. How do we handle this in similar situations?
Comment 2 Roman Kuznetsov 2019-07-17 07:59:06 UTC 
(In reply to Heiko Tietze from comment #1)
> Confirmation interrupts the workflow, you can undo. How do we handle this in
> similar situations?

What do you mean when say "you can undo". Undo what?

I can't undo deleting of item inside AutoRedaction dialog
Comment 3 Heiko Tietze 2019-07-17 08:50:26 UTC 
Okay, within the dialog....

There is too much data manipulation in the dialog, ie. it behaves like a separate application. To make it more lightweight I would go with icon-only buttons. And about the delete thing, undo is better than a confirmation. Users who need to delete some items would hate such a confirmation, so we better go without.
Comment 4 Heiko Tietze 2019-07-25 12:26:38 UTC 
No further input so let's do as suggested. My concerns are rather academically.
Comment 5 Thomas Lendo 2019-08-24 23:04:16 UTC 
I don't understand this bug report. How could be something deleted in a dialog/toolbar?