Bug 126450 - Sidebar Styles get style Icon support
Summary: Sidebar Styles get style Icon support
Status: RESOLVED WONTFIX
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: UI (show other bugs)
Version:
(earliest affected)
6.4.0.0.alpha1+
Hardware: All All
: medium enhancement
Assignee: Not Assigned
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: Sidebar-Styles
  Show dependency treegraph
 
Reported: 2019-07-17 21:10 UTC by andreas_k
Modified: 2023-05-12 08:04 UTC (History)
8 users (show)

See Also:
Crash report or crash signature:


Attachments
Icons at the styles sidebar (22.66 KB, image/png)
2019-07-17 21:12 UTC, andreas_k
Details
styles icons for heading styles 1 through 6 (29.70 KB, image/png)
2023-05-11 09:49 UTC, Jim Raykowski
Details
styles icons scaled to style preview height (29.57 KB, image/png)
2023-05-11 23:29 UTC, Jim Raykowski
Details

Note You need to log in before you can comment on or make changes to this bug.
Description andreas_k 2019-07-17 21:10:20 UTC
In the menubar we highlight stuff by show an icon in addition to the label. when we show in the styles list and treeview also an icon for styles that have an .uno: command it would highlight the styles (like all styles that are in the styles writer menubar has an icon) that are more importend than others.

In addition to highlight specific styles some styles didn't have an preview like table styles or styles in draw. By the posibility to have an icon in the styles sidebar we can have an "preview" icon of an draw style.
Comment 1 andreas_k 2019-07-17 21:12:32 UTC
Created attachment 152839 [details]
Icons at the styles sidebar
Comment 2 BogdanB 2019-07-18 02:49:28 UTC
It would look much nicer.
Comment 3 Heiko Tietze 2019-07-18 05:54:38 UTC
Icons make the item pop out, which is wanted for the more relevant styles. So a clear +1.
Comment 4 Heiko Tietze 2019-07-18 05:55:25 UTC
It might be not so hard to assign an icon to a treeview node, perhaps easy to hack.
Comment 5 Heiko Tietze 2023-05-10 10:56:25 UTC
Jim, is this something for you? We need to somehow enhance the (inbuilt) styles with icons and show this eventually in the Stylist.
Comment 6 Jim Raykowski 2023-05-11 09:49:06 UTC
Created attachment 187195 [details]
styles icons for heading styles 1 through 6

(In reply to Heiko Tietze from comment #5)
> Jim, is this something for you? We need to somehow enhance the (inbuilt)
> styles with icons and show this eventually in the Stylist.
The icons can be drawn when the previews for styles are drawn. This approach will only show the icons when 'Show previews' is checked.
Comment 7 Heiko Tietze 2023-05-11 10:22:22 UTC
(In reply to Jim Raykowski from comment #6)
> Created attachment 187195 [details]
> styles icons for heading styles 1 through 6

LGTM, would be even nicer if the icons stand out from the text. Ultimately I wonder if we really want to add icons to some of the styles.
Comment 8 Roman Kuznetsov 2023-05-11 10:24:51 UTC
I don't think it will useful. Styles pane should show current view of the styles.
Comment 9 Rizal Muttaqin 2023-05-11 10:55:03 UTC
This will make the interface look busier. Then the burden of maintaining the icon file will raise as we need to provide all of them. I think only a few icons can be applied in the toolbar as it is now
Comment 10 Jim Raykowski 2023-05-11 23:29:33 UTC
Created attachment 187213 [details]
styles icons scaled to style preview height

Here is a demo that scales the height of the icon to match the style preview.

I'm good with whatever is decided, even if it's not to do this.
Comment 11 Heiko Tietze 2023-05-12 08:03:47 UTC
Let's leave the Stylist icon free. Styles are just too flexible.
Comment 12 Heiko Tietze 2023-05-12 08:04:32 UTC
(In reply to Jim Raykowski from comment #10)
> I'm good with whatever is decided, even if it's not to do this.

Thanks Jim, hope it was not too much work.