Bug 126461 - Include document name in message box when updating OLE links on open
Summary: Include document name in message box when updating OLE links on open
Status: VERIFIED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: LibreOffice (show other bugs)
Version:
(earliest affected)
4.1 all versions
Hardware: All All
: medium normal
Assignee: Jan-Marek Glogowski
URL:
Whiteboard: target:6.4.0
Keywords:
Depends on:
Blocks:
 
Reported: 2019-07-18 09:30 UTC by Jan-Marek Glogowski
Modified: 2019-07-29 23:44 UTC (History)
1 user (show)

See Also:
Crash report or crash signature:


Attachments
ODT with Calc OLE (8.67 KB, application/vnd.oasis.opendocument.text)
2019-07-18 09:32 UTC, Jan-Marek Glogowski
Details
Referenced ODS dummy table. (7.22 KB, application/vnd.oasis.opendocument.spreadsheet)
2019-07-18 09:33 UTC, Jan-Marek Glogowski
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Jan-Marek Glogowski 2019-07-18 09:30:14 UTC
Description:
If you open a OLE-linked document, LO will ask confirmation to update the linked information on open. But this happens before the document shell has even set the title of the shell, so a user has no way to know, what "This document" really refers to. If you do this from the start center, the message box is displayed even before there was any change to the shell, but you can see at least which document was selected.
    
This is especially problematic if you have multiple open documents restored by a session manager.


Steps to Reproduce:
1. Open the attached writer document from the console, which OLE-links a Calc
or
1. Keep the document open, so it will be restored by the session manager


Actual Results:
You get a confirmation message box to update the links in "This document"

Expected Results:
The message box should include the referenced document name.


Reproducible: Always


User Profile Reset: No



Additional Info:
Also happens on master. The string doesn't contain a reference to the file name.
Comment 1 Jan-Marek Glogowski 2019-07-18 09:32:11 UTC
Created attachment 152856 [details]
ODT with Calc OLE
Comment 2 Jan-Marek Glogowski 2019-07-18 09:33:00 UTC
Created attachment 152857 [details]
Referenced ODS dummy table.
Comment 3 Commit Notification 2019-07-18 15:02:43 UTC
Jan-Marek Glogowski committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/+/d1398fd1cd6957f56992a9239929ccc64fd747f0%5E%21

tdf#126461 incl. document name in link update msg

It will be available in 6.4.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 4 Xisco Faulí 2019-07-29 23:44:29 UTC
Verified in

Version: 6.4.0.0.alpha0+
Build ID: 0d36b32755ac662299e6a8165e9fa57311b74a2f
CPU threads: 4; OS: Linux 4.15; UI render: default; VCL: gtk3; 
Locale: ca-ES (ca_ES.UTF-8); UI-Language: en-US
Calc: threaded

@Jan-Marek Glogowski, thanks for fixing this issue! Unfortunately it can't be backported as there is a string change

Reproduced back to

Version 4.1.0.0.alpha0+ (Build ID: efca6f15609322f62a35619619a6d5fe5c9bd5a)