Bug 126496 - Pivot Table: rename "Page Fields" to "Filter" or "Page Fields To Filter" or…
Summary: Pivot Table: rename "Page Fields" to "Filter" or "Page Fields To Filter" or…
Status: VERIFIED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Calc (show other bugs)
Version:
(earliest affected)
6.2.5.2 release
Hardware: All All
: medium enhancement
Assignee: Heiko Tietze
URL:
Whiteboard: target:6.4.0 target:7.2.0
Keywords: needsUXEval
Depends on:
Blocks:
 
Reported: 2019-07-21 21:56 UTC by Konstantin Kharlamov
Modified: 2021-08-17 01:41 UTC (History)
3 users (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Konstantin Kharlamov 2019-07-21 21:56:26 UTC
While I don't personally work with Office suites, my gf works a lot with MS Excel, with Pivot Tables in particular. She was dissatisfied by the look of pivot table configuration.

About the "Page Fields" she says: the title does not reflect the actual functional it represents. Ideally, it should be called "Filters", because it's a placeholder to filter out Pivot Table results. If you want to stick to "Page Fields" as in "Show results from the given page fields", then at least call it something like "Filtered Page Fields" or "Page Fields To Filter ".

# Steps to reproduce

1. Open localc
2. Go to `Insert → Pivot Table…`. A "Select Source" window should pop up, press enter. A "Pivot Table Layout" window should pop up.
3. Look at the title of the upper-left rectangle.

## Expected

Something more explicit than "Page Fields"

## Actual

"Page Fields"
Comment 1 Konstantin Kharlamov 2019-07-26 00:21:41 UTC
FTR, I can send patches on renaming, but I want to be sure there's an agreement on the naming.

I think, maybe "Page Fields To Filter"? This would retain the "Page Fields" text to cause less confusion, because PageFields is a property in UNO, I guess it can't be as easily renamed.
Comment 2 Heiko Tietze 2019-07-27 09:52:58 UTC
Page Fields might be used as a filter but would be also handy as a function to show only one field per page (aka sheet). OTOH, not opposing to renaming though a bit more than just "Filter" would be nice. Maybe the somewhat lengthy second option.
Comment 3 Cor Nouws 2019-07-31 12:07:47 UTC
I understand what you mean, Konstantin.
However, you can do filtering om more fields that those 'on the page'.
Do you know how other office suites name this?
Comment 4 Konstantin Kharlamov 2019-07-31 19:18:24 UTC
(In reply to Cor Nouws from comment #3)
> I understand what you mean, Konstantin.
> However, you can do filtering om more fields that those 'on the page'.
> Do you know how other office suites name this?

In MS Office it's just "Filters"¹

1: https://www.contextures.com/images/pivot/pivotcreate04.png
Comment 5 Heiko Tietze 2019-08-01 06:53:26 UTC
(In reply to Konstantin Kharlamov from comment #4)
> In MS Office it's just "Filters"

Still in favor of "Page Fields To Filter". What's you GF's opinion? She was the one who runs into trouble with the current label. Maybe none of the terms help her.
Comment 6 Konstantin Kharlamov 2019-08-01 07:03:17 UTC
(In reply to Heiko Tietze from comment #5)
> (In reply to Konstantin Kharlamov from comment #4)
> > In MS Office it's just "Filters"
> 
> Still in favor of "Page Fields To Filter". What's you GF's opinion? She was
> the one who runs into trouble with the current label. Maybe none of the
> terms help her.

She's in favor of "Filters". The "Page Fields to Filter" suggestion was mostly my idea, driven by the fact that the discussed property of pivot tables from POV of UNO is named as PageFields, and I assume that renaming the widget to something without "Page Fields" would introduce discrepancy; and renaming the property along with the widget may introduce confusion too, since UNO tutorials/forums/docs on the internet still refer to "PageFields".
Comment 7 Commit Notification 2019-08-01 14:27:49 UTC
Heiko Tietze committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/+/f38717a8025a37d1d7bf0c040df4fe9aca88b6f3%5E%21

Resolves: tdf#126496 - "Page Fields" in pivot table unclear

It will be available in 6.4.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 8 Commit Notification 2021-06-03 15:55:34 UTC
Stanislav Horacek committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/bbb167de2a3d9396ee94574c63e8a5822cb0c0be

Related tdf#126496

It will be available in 7.2.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 9 Stéphane Guillou (stragu) 2021-08-17 01:41:17 UTC
Verified as fixed in:

Version: 7.3.0.0.alpha0+ / LibreOffice Community
Build ID: adf65471e889676a600a9c6d0454c75cbd549ad3
CPU threads: 8; OS: Linux 4.15; UI render: default; VCL: gtk3
Locale: en-AU (en_AU.UTF-8); UI: en-US
TinderBox: Linux-rpm_deb-x86_64@86-TDF, Branch:master, Time: 2021-08-13_04:44:18
Calc: threaded

and:

Version: 7.2.0.3 / LibreOffice Community
Build ID: 2a7ea282da28d665a7dc086360567b4aea27bf08
CPU threads: 8; OS: Linux 4.15; UI render: default; VCL: gtk3
Locale: en-AU (en_AU.UTF-8); UI: en-US
Calc: threaded

The name is now "Filters". Help page for 7.2 and 7.3 looks good too.