Bug 126512 - Open pptx and save as odp, handle of shape is visible but cannot be moved
Summary: Open pptx and save as odp, handle of shape is visible but cannot be moved
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Impress (show other bugs)
Version:
(earliest affected)
3.4 all versions
Hardware: x86-64 (AMD64) Windows (All)
: medium normal
Assignee: Regina Henschel
URL:
Whiteboard: target:6.4.0
Keywords:
Depends on:
Blocks:
 
Reported: 2019-07-22 19:20 UTC by Regina Henschel
Modified: 2019-08-16 12:59 UTC (History)
2 users (show)

See Also:
Crash report or crash signature:


Attachments
Shape with handle (15.01 KB, application/vnd.openxmlformats-officedocument.presentationml.presentation)
2019-07-22 19:20 UTC, Regina Henschel
Details
XSLT to extract the handle references from OOXML preset shape definition (6.81 KB, text/xml)
2019-08-02 19:27 UTC, Regina Henschel
Details
OOXML preset shapes with handle (35.01 KB, application/vnd.openxmlformats-officedocument.presentationml.presentation)
2019-08-09 09:58 UTC, Regina Henschel
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Regina Henschel 2019-07-22 19:20:39 UTC
Created attachment 152946 [details]
Shape with handle

Open attached file. It was produced by PowerPoint365. It has a shape with handle. Make sure, that the handle is moveable. Save the presentation to odp format and close it. Open the odp file. Try to move the handle. The handle is visible, but you can not move it.

This is no regression, but the error exists from the beginning.
Comment 1 Jacques Guilleron 2019-07-25 15:56:25 UTC
Hi Regina,

I reproduce this behavoir from 
LO 5.3.0.0.beta1 Build ID: 690f553ecb3efd19143acbf01f3af4e289e94536
CPU Threads: 2; OS Version: Windows 6.1; UI Render: default; Layout Engine: new; 
Locale: en-US (fr_FR); Calc: CL
to
LO 6.4.0.0.alpha0+ (x86) Build ID: 719f4a93e46a6b397356dbb605d2867639ca3942
CPU threads: 2; OS: Windows 6.1; UI render: default; VCL: win; 
Locale: en-US (fr_FR); UI-Language: en-US Calc: CL
In those versions, yellow handle is moveable. With older versions, this is not the case. Handle monipulation give a form reduiced to a line.
Do you agree?
Comment 2 Regina Henschel 2019-07-25 17:15:20 UTC
(In reply to Jacques Guilleron from comment #1)
> In those versions, yellow handle is moveable.

Not for me. To be clear, I do not speak about the pptx file, but about the odp file.

 With older versions, this is
> not the case. Handle monipulation give a form reduiced to a line.
> Do you agree?

Reduce to a line happens with the pptx file. That has been fixed in newer versions. But the issue here is about the odp-file.
Comment 3 Jacques Guilleron 2019-07-26 10:01:37 UTC
I confirm the handle is not moveable when test File is saved to odt format,
Verified from LO LibreOffice 3.5.3.2 
Version ID : 235ab8a-3802056-4a8fed3-2d66ea8-e241b80
to
LO 6.4.0.0.alpha0+ (x86) Build ID: 719f4a93e46a6b397356dbb605d2867639ca3942
CPU threads: 2; OS: Windows 6.1; UI render: default; VCL: win; 
Locale: en-US (fr_FR); UI-Language: en-US Calc: CL

Jacques
Comment 4 Regina Henschel 2019-08-02 19:27:24 UTC
Created attachment 153112 [details]
XSLT to extract the handle references from OOXML preset shape definition

The XSLT was used to generate the text for the array initializing in the code in my patch. It is not good enough to use the generated text directly in the code. You have to correct the first and last line of the output manually. But for use with copy&paste in a one-time task, it is sufficient.
Comment 5 Regina Henschel 2019-08-09 09:58:04 UTC
Created attachment 153254 [details]
OOXML preset shapes with handle

This is a collection of all preset shapes, which have got handles. Shapes with XY-handles have orange filling, shapes with at least one angle or radius handle have green filling. Shape, which are not available in the UI of PowerPoint 365 have red stroke. The connector shapes are inserted as simple shapes, so that they will not be automatically converted, when you open the file in LibreOffice. The name of the shapes equals their internal preset name. They will show sorted by name in the selection pane of PowerPoint, but are not sorted on the slide.
Comment 6 Commit Notification 2019-08-10 10:07:44 UTC
Regina Henschel committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/+/ba61c3174bc24bc03e3f72fbc8d102b3312b5ff6%5E%21

tdf#126512 make handle of ooxml-shapes usable in odp

It will be available in 6.4.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 7 Johnny_M 2019-08-10 12:15:09 UTC
This sounds like an ODF issue. Maybe it could be reported to OASIS for inclusion in future ODF versions, so that other office apps can create compatible documents?
Comment 8 Regina Henschel 2019-08-10 23:13:42 UTC
(In reply to Johnny_M from comment #7)
> This sounds like an ODF issue. Maybe it could be reported to OASIS for
> inclusion in future ODF versions, so that other office apps can create
> compatible documents?

Simple "reporting to OASIS" will not work. You need to write down a detailed proposal. Best would be, to have an implementation in private namespace as example. And to get it implemented in LibreOffice, you need a developer.
Comment 9 Regina Henschel 2019-08-16 12:59:34 UTC
Fix is in Version: 6.4.0.0.alpha0+ (x64)
Build ID: 69e5360ce5b403bdd36e977cd1c3fb778272d5fe
CPU threads: 8; OS: Windows 10.0; UI render: default; VCL: win; 
TinderBox: Win-x86_64@62-TDF, Branch:master, Time: 2019-08-14_22:53:07
Locale: de-DE (en_US); UI-Language: en-US
Calc: CL