Description: At least two of the tests in vcl_pdfexport are currently failing on master for a macOS debug build. Output of test where it fails is attached. Steps to Reproduce: 1.attempt to build debug enabled from master on macOS 10.14.5 2.watch build fail in vcl_pdfexport unit test 3.build progression stops and fails to complete Actual Results: See above Expected Results: test should succeed and build finish to completion without error Reproducible: Always User Profile Reset: No Additional Info:
Created attachment 152998 [details] Build output
Jan-Marek: I noticed 3f7e8ddea89f6340cd18b5b34f5a7c5f503962be which has enabled testTdf107868 for MacOS whereas there was: "FIXME: Why does this fail on macOS?" Any thoughts here? Should we put avoid to test this one on MacOS for the moment?
There's also this failing test: PdfExportTest::testSofthyphenPos /Users/Shared/LO/core/vcl/qa/cppunit/pdfexport/pdfexport.cxx:668:(anonymous namespace)::PdfExportTest::testSofthyphenPos double equality assertion failed - Expected: 11.05 - Actual : 1 - Delta : 1e-06 Delta is quite strange... This test has also been reenabled for MacOS in the same commit 3f7e8ddea89f6340cd18b5b34f5a7c5f503962be
(In reply to Julien Nabet from comment #2) > Jan-Marek: I noticed 3f7e8ddea89f6340cd18b5b34f5a7c5f503962be which has > enabled testTdf107868 for MacOS whereas there was: > "FIXME: Why does this fail on macOS?" > Any thoughts here? Should we put avoid to test this one on MacOS for the > moment? As I wrote in my mail to the dev-list: -------- Weitergeleitete Nachricht -------- Betreff: Re: vcl_pdfexport test failing on master with MacOS Datum: Mon, 22 Jul 2019 16:59:53 +0200 Von: Jan-Marek Glogowski <glogow@fbihome.de> An: libreoffice@lists.freedesktop.org Am 22.07.19 um 13:16 schrieb Alexander Thurgood: > Test name : (anonymous namespace)::PdfExportTest::testTdf107868 > pdfexport.cxx:668 (anonymous namespace)::PdfExportTest:testSoftHyphenPos Not AFAIK. But I enabled many tests in commit 3f7e8ddea89f ("Enable many more unit tests on all archs"). These were included and had a "// FIXME: Why does this fail on macOS?" in front of the #ifndef. If you can't debug the problem, you might want to re-disable these on MACOSX. Jenkins and tinderboxes seemed to be fine. Jan-Marek P.S.: > As from today, or at earliest from Thurs or Fri last week, commit 3f7e8ddea89f6340cd18b5b34f5a7c5f503962be Author: Jan-Marek Glogowski <glogow@fbihome.de> Date: Tue Jun 25 19:56:13 2019 +0000 Enable many more unit tests on all archs That doesn't match your claimed dates, so probably something really broke just now. Maybe bisect? and: -------- Weitergeleitete Nachricht -------- Betreff: Re: vcl_pdfexport test failing on master with MacOS Datum: Mon, 22 Jul 2019 17:18:58 +0200 Von: Jan-Marek Glogowski <glogow@fbihome.de> An: libreoffice@lists.freedesktop.org Replying to myself, as the commit was a bit later: Am 22.07.19 um 16:59 schrieb Jan-Marek Glogowski: > commit 3f7e8ddea89f6340cd18b5b34f5a7c5f503962be > Author: Jan-Marek Glogowski <glogow@fbihome.de> > Date: Tue Jun 25 19:56:13 2019 +0000 > > Enable many more unit tests on all archs > Commit: Jan-Marek Glogowski <glogow@fbihome.de> CommitDate: Fri Jul 5 20:05:59 2019 +0200 Still more then a few days ago. -------- I can't investigate or fix this, so decide whatever you want to do.
Julien Nabet committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/+/236593a0544ea41e37d35b8fac83b31d0e7c5b67%5E%21 tdf#126559: vcl_pdfexport unit test failure It will be available in 6.4.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
@Alex, Could you please try to build again including Julien's commit ?
(In reply to Xisco Faulí from comment #6) > @Alex, Could you please try to build again including Julien's commit ? Sure, when I'm next in front of my build machine, later on this week.
Thanks to everyone for their input and for fixing this ! Closing as RESOLVED FIXED
Fixed in the sense that I can at least get a completed build ;-)
This is not fixed. Disabling a unit test is no fix! I'm not sure that having an open bug will help fixing the underlying problem, but personally I would just leave it open.
(In reply to Jan-Marek Glogowski from comment #10) > This is not fixed. Disabling a unit test is no fix! I'm not sure that having > an open bug will help fixing the underlying problem, but personally I would > just leave it open. I agree. The summary needs to be adapted though
(In reply to Xisco Faulí from comment #11) > (In reply to Jan-Marek Glogowski from comment #10) > > This is not fixed. Disabling a unit test is no fix! I'm not sure that having > > an open bug will help fixing the underlying problem, but personally I would > > just leave it open. > > I agree. The summary needs to be adapted though Also the status: resolved fixed not to ideal either :D
Corrected summary and set to new
Just to say that I'm also seeing this trying to build on Slackware Linux "current", 64 bit; on an AMD Ryzen 7 2700X system: [CUT] oox_drawingml (anonymous namespace)::PdfExportTest::testTdf106059 finished in: 865ms (anonymous namespace)::PdfExportTest::testTdf105461 finished in: 537ms (anonymous namespace)::PdfExportTest::testTdf107868 finished in: 256ms (anonymous namespace)::PdfExportTest::testTdf105093 finished in: 1061ms (anonymous namespace)::PdfExportTest::testTdf106206 finished in: 273ms (anonymous namespace)::PdfExportTest::testTdf106693 finished in: 264ms (anonymous namespace)::PdfExportTest::testForcePoint71 finished in: 1688ms (anonymous namespace)::PdfExportTest::testTdf106972 finished in: 417ms (anonymous namespace)::PdfExportTest::testTdf106972Pdf17 finished in: 329ms /home/marc/git/core/vcl/qa/cppunit/pdfexport/pdfexport.cxx:680:(anonymous namespace)::PdfExportTest::testSofthyphenPos double equality assertion failed - Expected: 11.05 - Actual : 10.9499998092651 - Delta : 1e-06 (anonymous namespace)::PdfExportTest::testSofthyphenPos finished in: 244ms (anonymous namespace)::PdfExportTest::testTdf107013 finished in: 429ms (anonymous namespace)::PdfExportTest::testTdf107018 finished in: 341ms (anonymous namespace)::PdfExportTest::testTdf107089 finished in: 282ms (anonymous namespace)::PdfExportTest::testTdf99680 finished in: 235ms (anonymous namespace)::PdfExportTest::testTdf99680_2 finished in: 567ms (anonymous namespace)::PdfExportTest::testTdf108963 finished in: 413ms (anonymous namespace)::PdfExportTest::testTdf118244_radioButtonGroup finished in: 356ms (anonymous namespace)::PdfExportTest::testTdf115117_1 finished in: 357ms (anonymous namespace)::PdfExportTest::testTdf115117_1a finished in: 242ms (anonymous namespace)::PdfExportTest::testTdf115117_2 finished in: 288ms (anonymous namespace)::PdfExportTest::testTdf115117_2a finished in: 269ms (anonymous namespace)::PdfExportTest::testTdf66597_1 finished in: 239ms (anonymous namespace)::PdfExportTest::testTdf66597_2 finished in: 378ms (anonymous namespace)::PdfExportTest::testTdf66597_3 finished in: 307ms (anonymous namespace)::PdfExportTest::testTdf109143 finished in: 202ms (anonymous namespace)::PdfExportTest::testTdf105954 finished in: 280ms (anonymous namespace)::PdfExportTest::testTdf128630 finished in: 334ms (anonymous namespace)::PdfExportTest::testTdf106702 finished in: 443ms (anonymous namespace)::PdfExportTest::testTdf113143 finished in: 588ms (anonymous namespace)::PdfExportTest::testTdf115262 finished in: 707ms (anonymous namespace)::PdfExportTest::testTdf121962 finished in: 417ms (anonymous namespace)::PdfExportTest::testTdf115967 finished in: 321ms (anonymous namespace)::PdfExportTest::testTdf121615 finished in: 230ms (anonymous namespace)::PdfExportTest::testTocLink finished in: 265ms (anonymous namespace)::PdfExportTest::testPdfImageResourceInlineXObjectRef finished in: 181ms pdfexport.cxx:680:Assertion Test name: (anonymous namespace)::PdfExportTest::testSofthyphenPos double equality assertion failed - Expected: 11.05 - Actual : 10.9499998092651 - Delta : 1e-06 Failures !!! Run: 35 Failure total: 1 Failures: 1 Errors: 0 Error: a unit test failed, please do one of: make CppunitTest_vcl_pdfexport CPPUNITTRACE="gdb --args" # for interactive debugging on Linux make CppunitTest_vcl_pdfexport VALGRIND=memcheck # for memory checking make CppunitTest_vcl_pdfexport DEBUGCPPUNIT=TRUE # for exception catching You can limit the execution to just one particular test by: make CPPUNIT_TEST_NAME="testXYZ" ...above mentioned params... make[1]: *** [/home/marc/git/core/solenv/gbuild/CppunitTest.mk:114: /home/marc/git/core/workdir/CppunitTest/vcl_pdfexport.test] Error 1 make[1]: *** Waiting for unfinished jobs.... make: *** [Makefile:282: build] Error 2
Dear Alex Thurgood, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://web.libera.chat/?settings=#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug
I'm not building on macOS anymore so let's close this.