Bug 126574 - description of macro security level settings is misleading or wrong
Summary: description of macro security level settings is misleading or wrong
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Documentation (show other bugs)
Version:
(earliest affected)
6.2.5.2 release
Hardware: All All
: medium trivial
Assignee: BogdanB
URL:
Whiteboard: target:7.5.0
Keywords:
Depends on:
Blocks:
 
Reported: 2019-07-27 14:37 UTC by Toni Dietze
Modified: 2022-11-06 18:05 UTC (History)
3 users (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Toni Dietze 2019-07-27 14:37:19 UTC
Description:
Short version:

Correct the macro security level description of the High level. Current text:

> Only signed macros from trusted sources are allowed to run.
> Unsigned macros are disabled.

Proposal:

> Only macros from trusted sources and signed macros (from any source) are allowed to run.
> Macros that are neither from a trusted source nor signed are disabled.

(Please check the correctness.)


--------


Long version:

The macro security level settings of Libre Office provide the following options:

> _Low (not recommended).
> All macros will be executed without confirmation.
> Use this setting only if you are certain that all documents that will be opened are safe.
> 
> _Medium.
> Confirmation required before executing macros from untrusted sources.
> 
> H_igh.
> Only signed macros from trusted sources are allowed to run.
> Unsigned macros are disabled.
> 
> _Very high.
> Only macros from trusted file locations are allowed to run.
> All other macros, regardless whether signed or not, are disabled.

(cf. Tools/Options…/LibreOffice/Security/Macro Security…/Security Level; text copied from xmlsecurity/uiconfig/ui/securitylevelpage.ui commit 67950f00989dff4640ba83e540673375a2c60a13)

The descriptions of some settings appear to be contradictory:

- The formulation of the High setting suggests that macros need to be signed _and_ from a trusted source. Especially the second sentence “Unsigned macros are disabled” strengthens the need of a signature.
- Also the text for Very high setting demands that macros come from a trusted source, however, signing is not mentioned.

Looking at the help (https://help.libreoffice.org/6.2/en-US/text/shared/optionen/macrosecurity_sl.html), it seems to be the case that the High setting actually accepts macros that are signed _or_ come from a trusted source. There we find the following description:

> Only signed macros from a trusted source are allowed to run. In addition, any macro from a trusted file location is allowed to run.

(In my opinion, it is not good style to give a statement in a first sentence but then alter the meaning of the statement in a second sentence, but that is another issue.)

I propose to change the description of the High setting to:

> Only macros from trusted sources and signed macros (from any source) are allowed to run.
> Macros that are neither from a trusted source nor signed are disabled.

Note that I am only guessing here.

I strongly suggest to accurately recheck if the descriptions of each security level matches the actual effect of that setting. Translations for localization maybe have to be adapted as well.

Steps to Reproduce:
Read the settings at Tools/Options…/LibreOffice/Security/Macro Security…/Security Level.

Actual Results:
The descriptions of the macro security levels seem contradictory.

Expected Results:
The descriptions shall be accurate.


Reproducible: Always


User Profile Reset: No



Additional Info:
Comment 1 Oliver Brinzing 2019-07-28 17:25:38 UTC
> Only signed macros from trusted sources are allowed to run.
> Unsigned macros are disabled.

i agree, this is misleading.

according to help:
https://help.libreoffice.org/6.2/en-US/text/shared/optionen/macrosecurity_sl.html

"trusted sources" refers to "Trusted Sources tab page"
Comment 2 QA Administrators 2021-07-28 04:05:53 UTC Comment hidden (noise)
Comment 3 Toni Dietze 2022-09-25 14:33:26 UTC
The issue is still present on current master:

https://git.libreoffice.org/core/+/567b4281b96f56ce48d3feb57522255b06816f9b/xmlsecurity/uiconfig/ui/securitylevelpage.ui

I also checked that it is still present in the packaged version on Arch Linux:

Version: 7.3.6.2 / LibreOffice Community
Build ID: 30(Build:2)
CPU threads: 8; OS: Linux 5.19; UI render: default; VCL: kf5 (cairo+xcb)
Locale: de-DE (de_DE.UTF-8); UI: en-US
7.3.6-2
Calc: threaded
Comment 4 Commit Notification 2022-11-06 17:43:04 UTC
Bogdan B committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/help/commit/4f1d8245e409f5df7ca88c83a573cb07f181d0a5

tdf#126574 Macro security high level description