Bug 126631 - [REGRESSION] Iterating objects in a slide with an image fails
Summary: [REGRESSION] Iterating objects in a slide with an image fails
Status: RESOLVED WORKSFORME
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Impress (show other bugs)
Version:
(earliest affected)
6.4.0.0.alpha1+
Hardware: All All
: high major
Assignee: Not Assigned
URL:
Whiteboard:
Keywords: bibisected, bisected, regression
Depends on:
Blocks:
 
Reported: 2019-07-30 21:26 UTC by Konstantin Kharlamov
Modified: 2022-02-24 19:26 UTC (History)
3 users (show)

See Also:
Crash report or crash signature:


Attachments
Script that simply connects to Impress and iterates over 1st slide objects (819 bytes, text/x-python)
2019-07-30 21:26 UTC, Konstantin Kharlamov
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Konstantin Kharlamov 2019-07-30 21:26:39 UTC
Created attachment 153060 [details]
Script that simply connects to Impress and iterates over 1st slide objects

On current master, if a slide has an image (tested with PNG and JPG), iterating over slide objects and accessing ShapeType property results in

    __main__.RuntimeException: Binary URP bridge disposed during call

# Steps to reproduce:

1. Run `soffice.bin --impress --accept="socket,host=localhost,port=2002;urp;StarOffice.ServiceManager"` (an Impress window should appear)
2. Copy this image to the new presentation https://wiki.documentfoundation.org/images/8/8c/BHS_large_6.3_RC2.png
3. Run the attached script as `python test.py`

## Expected

No output

## Actual

Script fails as:

    $ python test.py
    Traceback (most recent call last):
    File "test.py", line 30, in <module>
        [item for item in slide if item.ShapeType == 'com.sun.star.drawing.TableShape']
    File "test.py", line 30, in <listcomp>
        [item for item in slide if item.ShapeType == 'com.sun.star.drawing.TableShape']
    __main__.RuntimeException: Binary URP bridge disposed during call

# Additional information

Info for a version without the problem

    Version: 6.2.5.2
    Build ID: 6.2.5-1
    CPU threads: 4; OS: Linux 5.2; UI render: default; VCL: gtk3;
    Locale: ru-RU (ru_RU.UTF-8); UI-Language: en-US
    Calc: threaded

Info for a version where the problem is present:

    Version: 6.4.0.0.alpha0+
    Build ID: 236593a0544ea41e37d35b8fac83b31d0e7c5b67
    CPU threads: 4; OS: Linux 5.2; UI render: default; VCL: gtk3;
    Locale: ru-RU (ru_RU.UTF-8); UI-Language: en-US
    Calc: threaded
Comment 1 Xisco Faulí 2019-07-31 13:48:40 UTC
Regression introduced by:

https://cgit.freedesktop.org/libreoffice/core/commit/?id=2de42b53b7c23223c38e64a75eae248d8a0cd4ec

author	Shubham Goyal <22shubh22@gmail.com>	2019-07-03 12:15:08 +0530
committer	Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>	2019-07-25 07:15:10 +0200
commit 2de42b53b7c23223c38e64a75eae248d8a0cd4ec (patch)
tree dc4b2fc96a0569b7c0ebfdc80446181c842a9964
parent 5ccc8124a03cffca3a1848f754524a06a063cb51 (diff)
QRCode Dialog Box feature

Bisected with: bibisect-linux64-6.4

Adding Cc: to Shubham Goyal
Comment 2 shubhamgoyal 2019-08-02 03:44:48 UTC
Hi,
I am unable to generate the error, for me the script runs fine ?
Comment 3 Samuel Mehrbrodt (allotropia) 2019-08-02 06:55:08 UTC
@Konstantin can you retry with current master?
Comment 4 Konstantin Kharlamov 2019-08-02 07:08:22 UTC
(In reply to Samuel Mehrbrodt (CIB) from comment #3)
> @Konstantin can you retry with current master?

Hmm. I don't know if it's because I enabled debug symbols upon rebuild, but current master fails to build for me with 

/home/constantine/Projects/libreoffice/external/firebird/ExternalPackage_firebird.mk:21: *** file /home/constantine/Projects/libreoffice/workdir/UnpackedTarball/firebird/gen/Debug/firebird/lib/libfbclient.so.3.0.0 does not exist in the tarball.  Stop.

Will try to look at it later then.
Comment 5 Xisco Faulí 2019-08-02 08:44:26 UTC
(In reply to Konstantin Kharlamov from comment #4)
> (In reply to Samuel Mehrbrodt (CIB) from comment #3)
> > @Konstantin can you retry with current master?
> 
> Hmm. I don't know if it's because I enabled debug symbols upon rebuild, but
> current master fails to build for me with 
> 
> /home/constantine/Projects/libreoffice/external/firebird/
> ExternalPackage_firebird.mk:21: *** file
> /home/constantine/Projects/libreoffice/workdir/UnpackedTarball/firebird/gen/
> Debug/firebird/lib/libfbclient.so.3.0.0 does not exist in the tarball.  Stop.
> 
> Will try to look at it later then.

Maybe you can use --disable-firebird-sdbc to not build Firebird and don't face that problem ( just a temporally workaround )
Comment 6 Xisco Faulí 2019-08-02 08:47:20 UTC
Still failing for me

Version: 6.4.0.0.alpha0+
Build ID: 620fff54ca9cd04459cc5d963ef94d4438129fe4
CPU threads: 4; OS: Linux 4.15; UI render: default; VCL: gtk3; 
Locale: ca-ES (ca_ES.UTF-8); UI-Language: en-US
Calc: threaded

@shubhamgoyal since you are still working on the QR code feature, might it be possible you have some commits we don't have which fix this issue ?
Comment 7 Konstantin Kharlamov 2019-08-02 17:21:49 UTC
(In reply to Xisco Faulí from comment #6)
> Still failing for me
> 
> Version: 6.4.0.0.alpha0+
> Build ID: 620fff54ca9cd04459cc5d963ef94d4438129fe4
> CPU threads: 4; OS: Linux 4.15; UI render: default; VCL: gtk3; 
> Locale: ca-ES (ca_ES.UTF-8); UI-Language: en-US
> Calc: threaded
> 
> @shubhamgoyal since you are still working on the QR code feature, might it
> be possible you have some commits we don't have which fix this issue ?

Same for me. FTR, I just recorded a video, just to double-check, @Samuel is it not what you see? https://youtu.be/WL58LR03068
Comment 8 Konstantin Kharlamov 2019-08-02 17:25:23 UTC
(In reply to Xisco Faulí from comment #5)
> (In reply to Konstantin Kharlamov from comment #4)
> > (In reply to Samuel Mehrbrodt (CIB) from comment #3)
> > > @Konstantin can you retry with current master?
> > 
> > Hmm. I don't know if it's because I enabled debug symbols upon rebuild, but
> > current master fails to build for me with 
> > 
> > /home/constantine/Projects/libreoffice/external/firebird/
> > ExternalPackage_firebird.mk:21: *** file
> > /home/constantine/Projects/libreoffice/workdir/UnpackedTarball/firebird/gen/
> > Debug/firebird/lib/libfbclient.so.3.0.0 does not exist in the tarball.  Stop.
> > 
> > Will try to look at it later then.
> 
> Maybe you can use --disable-firebird-sdbc to not build Firebird and don't
> face that problem ( just a temporally workaround )

Btw, thanks, that helped with that error. But then I stumbled upon something another, and in the end I just did `make clean`, and rebuild everything from scratch. That helped.
Comment 9 shubhamgoyal 2019-08-19 14:27:13 UTC
Someone may need to step in as I am unable to produce the crash. I am unaware why it is so.
Comment 10 Samuel Mehrbrodt (allotropia) 2019-08-19 14:33:46 UTC
(In reply to shubhamgoyal from comment #9)
> Someone may need to step in as I am unable to produce the crash. I am
> unaware why it is so.

Did you follow the same steps as seen in the video? Did your presentation have an image in the first slide?
Comment 11 shubhamgoyal 2019-09-16 16:42:38 UTC
(In reply to Samuel Mehrbrodt (CIB) from comment #10)
> (In reply to shubhamgoyal from comment #9)
> > Someone may need to step in as I am unable to produce the crash. I am
> > unaware why it is so.
> 
> Did you follow the same steps as seen in the video? Did your presentation
> have an image in the first slide?

yes.
Comment 12 Xisco Faulí 2020-02-17 10:55:04 UTC
Dear shubham goyal,
This bug has been in ASSIGNED status for more than 3 months without any
activity. Resetting it to NEW.
Please assign it back to yourself if you're still working on this.
Comment 13 QA Administrators 2022-02-17 03:39:57 UTC Comment hidden (obsolete)
Comment 14 Konstantin Kharlamov 2022-02-24 19:26:10 UTC
I can no longer reproduce it with LibreOffice 7.3.0.3