Bug 126671 - remove images_helpimg.zip from build
Summary: remove images_helpimg.zip from build
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: framework (show other bugs)
Version:
(earliest affected)
6.4.0.0.alpha1+
Hardware: All All
: medium normal
Assignee: Olivier Hallot
URL:
Whiteboard: target:6.4.0
Keywords:
: 124288 (view as bug list)
Depends on:
Blocks:
 
Reported: 2019-08-02 08:19 UTC by andreas_k
Modified: 2019-11-21 13:10 UTC (History)
5 users (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description andreas_k 2019-08-02 08:19:24 UTC
As fare as I know you have to install help with an additional package, but if you download and install LibreOffice the images_helpimg.zip file which is 19,7 mb in file size (contain 1690 png files)is installed on the hard disk.

I suggest to remove images_helpimg.zip from installation and save 19,7 mb download and installation size.
Comment 1 Alex Thurgood 2019-08-02 08:48:50 UTC
Would such a removal have any effect on :

- documentation writers ? Currently, much of the LO documentation uses images from the help content ;

- are there any issues with adding this to the lang-packs / validation / authentication on certain OSes, e.g. macOS ? - currently help and localization are in a single bundle for macOS per language, what if any, impact would that have if the zip was moved into that bundle ?
Comment 2 Olivier Hallot 2019-08-02 11:38:20 UTC
The current Help-exclusive images were brought to the helpcontent2/ sub module, and new help images are created in the submodule.

The current Help does not use any image from the helpimg inside the icon-themes/ folder. I don't know if other modules use these images.
Comment 3 andreas_k 2019-08-02 14:05:13 UTC
thanks for the feedback Olivier. If I search in opengrok I don't see where the image files were used in core. result = 0
Comment 4 Olivier Hallot 2019-08-06 22:57:53 UTC
*** Bug 124288 has been marked as a duplicate of this bug. ***
Comment 5 Commit Notification 2019-08-07 10:46:00 UTC
Olivier Hallot committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/help/+/7b926418c11225c6605a39fdf9a6db7401a14a6c%5E%21

tdf#126671 Do not pack screenshots in old Help
Comment 6 Xisco Faulí 2019-11-21 12:33:31 UTC
A polite ping to Olivier Hallot:
Is this bug fixed? if so, could you please close it as RESOLVED FIXED ? Otherwise, Could you please explain what's missing?
Thanks
Comment 7 andreas_k 2019-11-21 12:37:40 UTC
The images_helpimg.zip is available in the install folder, but the zip file is now only 879 kb small.