Bug 126701 - FILEOPEN Date picker can have an extra line break
Summary: FILEOPEN Date picker can have an extra line break
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
6.4.0.0.alpha1+
Hardware: All All
: medium normal
Assignee: Tamás Zolnai
URL:
Whiteboard: target:6.4.0
Keywords: filter:docx, implementationError
Depends on:
Blocks: DOCX-Content_Control
  Show dependency treegraph
 
Reported: 2019-08-04 21:48 UTC by Aron Budea
Modified: 2019-08-05 10:47 UTC (History)
2 users (show)

See Also:
Crash report or crash signature:


Attachments
Sample DOCX (22.16 KB, application/vnd.openxmlformats-officedocument.wordprocessingml.document)
2019-08-04 21:48 UTC, Aron Budea
Details
Screenshot (37.00 KB, image/png)
2019-08-04 21:50 UTC, Aron Budea
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Aron Budea 2019-08-04 21:48:11 UTC
Created attachment 153130 [details]
Sample DOCX

The attached DOCX was created in Word, it's just a piece of text, and a date picker in the next line.
Open it in Writer.

=> The date picker appears to have an extra line break at the end.

Observed using LO 6.4.0.0.alpha0+ (d05b2b91952927ec40d6ea2f482f76c7ccd25ed3) / Windows 7.
Comment 1 Aron Budea 2019-08-04 21:50:34 UTC
Created attachment 153131 [details]
Screenshot
Comment 2 m_a_riosv 2019-08-04 23:08:50 UTC
Repro
Version: 6.4.0.0.alpha0+ (x64)
Build ID: b9b7df5f558eb79533622df5f3390f79a1e5aa79
CPU threads: 4; OS: Windows 10.0; UI render: GL; VCL: win; 
TinderBox: Win-x86_64@62-TDF, Branch:master, Time: 2019-07-31_17:15:25
Locale: es-ES (es_ES); UI-Language: en-US Calc: CL

Fine with
Version: 6.3.1.0.0+ (x64)
Build ID: f27e33eb981d1c8dbae2b52985c847b6a6923a30
CPU threads: 4; OS: Windows 10.0; UI render: GL; VCL: win; 
TinderBox: Win-x86_64@42, Branch:libreoffice-6-3, Time: 2019-07-26_13:07:30
Locale: es-ES (es_ES); UI-Language: en-US
Calc: CL
Comment 3 Aron Budea 2019-08-05 01:59:12 UTC
Thanks for confirming!
There was no proper date picker control corresponding to Word's in the past, it was added in July by Tamás Zolnai, see commits from the corrsponding time period:
https://cgit.freedesktop.org/libreoffice/core/log/?qt=grep&q=msforms
Comment 4 m_a_riosv 2019-08-05 09:39:48 UTC
Please try, picker on the attached file works in 6.2.5
Comment 5 Commit Notification 2019-08-05 10:42:20 UTC
Tamás Zolnai committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/+/b36ef83ea59eeaca239e58b95aa0b1acdcb99efc%5E%21

tdf126701: MSForms: Fix import of date field at the end of the paragraph.

It will be available in 6.4.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.