Bug 126722 - Remove unused defines
Summary: Remove unused defines
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: LibreOffice (show other bugs)
Version:
(earliest affected)
6.4.0.0.alpha1+
Hardware: All All
: medium normal
Assignee: Not Assigned
URL:
Whiteboard: target:6.4.0
Keywords: difficultyBeginner, easyHack, skillCpp, skillScript, topicCleanup
Depends on:
Blocks:
 
Reported: 2019-08-06 09:07 UTC by Samuel Mehrbrodt (allotropia)
Modified: 2019-08-09 13:38 UTC (History)
2 users (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Samuel Mehrbrodt (allotropia) 2019-08-06 09:07:05 UTC
include/svx/svxcommands.h has a lot of defines which are never used in the code.

Find out which are unused and remove them.

Use "git grep <name>" to see where it is used.
Comment 1 Commit Notification 2019-08-07 12:05:29 UTC
Szabolcs Toth committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/+/5bb6c1bdef28de0e30326b13161f681e1d58a032%5E%21

tdf#126722 All unnecessary defines are removed.

It will be available in 6.4.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 2 Commit Notification 2019-08-08 10:46:54 UTC
Szabolcs Toth committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/+/5349e558cf60c6d124fc9a5a4aa41578a3903088%5E%21

tdf#126722 Deleted svxcommands.h file and replaced defines by their values

It will be available in 6.4.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 3 Commit Notification 2019-08-09 13:38:57 UTC
Szabolcs Toth committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/+/24f609b51243b052f38930fbc902c4a95f0e94a0%5E%21

tdf#126722 Deleted svxcommands.h

It will be available in 6.4.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.