Created attachment 153269 [details] Chart Wizard showing wrong Percent Stacked illustration In Chart Wizard when using icon styles Breeze, Colibre, Sifr and Tango, the illustration of Column and Bar Percent Stacked chart types is incorrect. The image in Icon styles Elementary (default) and Karasa Jaga is correct
Created attachment 153270 [details] Chart Wizard showing expected Percent Stacked illustration
Just verified that the Automatic (or Default) icon style under the Windows OS is Colibre which has the wrong illustration. Even worse: the Tango icon style which had the correct illustration (e.g. in version 5.4.6) now uses the wrong images from Colibre Tagged this is a regression
Hi Pedro, Could you please explain why it's wrong ?
Percent stacked always adds up to 100%. That should be represented in the image likewise it's good for the other themes. I'm a bit surprised that Tango is wrong as well. Andreas, could you please fix it?
Would like to have the correct image for documentation :)
(In reply to Cathy Crumbley from comment #5) > Would like to have the correct image for documentation :) The second attachment provided on the first post is the expected image
Oh, I wasn't clear. I meant that I am writing documentation and would like to have the image corrected so I can use it in a screenshot of the Chart Wizard. It needs to be a current LO version. I imagine that fixing this should be easy and just want to encourage someone to do so.
(In reply to Cathy Crumbley from comment #7) > Oh, I wasn't clear. I meant that I am writing documentation and would like > to have the image corrected so I can use it in a screenshot of the Chart > Wizard. It needs to be a current LO version. > I imagine that fixing this should be easy and just want to encourage someone > to do so. I see what you mean and yes, any of the Icon themes' authors who have the original images (hopefully in vector format) should be able to fix this quite easily. Curiously the Area Percent Stacked image is correct in Colibre :)
Created attachment 154915 [details] Hacked Colibre Stacked Column Chart SVG Actually because LibreOffice includes the same Icon themes in SVG it takes about 1 minute to fix each chart type. As an example I attached the fixed Stacked Column Chart in SVG format. Exporting to PNG is also trivial.
andreas kainz committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/0c59826811f98ed77270fd4c2a58bd875753008e tdf#126796 percent stacked image fixed for breeze It will be available in 6.4.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
andreas kainz committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/dedf1e7ff1714188f4e18e93de8ea537897377d4 tdf126796 percent stacked image fixed for colibre It will be available in 6.4.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Andreas, thank you for fixing this in Colibre! I'm Reopening the Bug since it has not been Fixed in Breeze and Sifr (as well as in the Dark variants of these two Themes)
no worry it's fixed everywhere. please verify with an daily build and close than the bug.
I just noticed that Andreas also fixed it for Breeze, but not for Breeze Dark(?) Correct?
breeze dark fix (there was something more wrong) https://gerrit.libreoffice.org/80867
Hi Andreas Just loaded 6.4 Alpha 1 All icon themes except for the SIFRs are fixed! SIFR SVG is using the Colibre SVG chart icons SIFR and SIFR dark still have the wrong Column and Bar Percent Stacked icons
(In reply to Pedro from comment #16) > Hi Andreas > > Just loaded 6.4 Alpha 1 > > All icon themes except for the SIFRs are fixed! > > SIFR SVG is using the Colibre SVG chart icons > SIFR and SIFR dark still have the wrong Column and Bar Percent Stacked icons https://gerrit.libreoffice.org/#/c/81747/ Sifr fix would be landed lately
rizmut committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/5d0bfad6c9e8200f90e02da749b71eff04a0794d Breeze & Sifr: fix for tdf#126796 wrong percent stacked chart images It will be available in 6.4.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
(In reply to Rizal Muttaqin from comment #17) > Sifr fix would be landed lately Verified Fixed in Version: 6.4.0.0.alpha1+ (x64) Build ID: 188bdbaf19241cd51820832fdb4522747534bec6 Could you please cherry pick this fix to the 6.3 branch? Thank you Andreas and Rizal!
> Could you please cherry pick this fix to the 6.3 branch? Failed to cherry pick with following message: "Cherry pick failed: merge conflict" I don't know how to get rid off the error
(In reply to Rizal Muttaqin from comment #20) > I don't know how to get rid off the error You local version of the code differs from the latest sources. You can purge everything locally with "git reset --hard origin/master && git fetch --all".
(In reply to Heiko Tietze from comment #21) > (In reply to Rizal Muttaqin from comment #20) > > I don't know how to get rid off the error > > You local version of the code differs from the latest sources. You can purge > everything locally with "git reset --hard origin/master && git fetch --all". I means cherry-picking through the gerrit web interface from master branch to libreoffice-6-3 one.