Bug 126960 - EDITING: Firebird: Table editor instead of view editor
Summary: EDITING: Firebird: Table editor instead of view editor
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Base (show other bugs)
Version:
(earliest affected)
6.3.0.4 release
Hardware: All All
: medium normal
Assignee: Julien Nabet
URL:
Whiteboard: target:7.4.0 target:7.3.1
Keywords:
: 116953 (view as bug list)
Depends on:
Blocks: Database-Firebird-Default
  Show dependency treegraph
 
Reported: 2019-08-16 07:30 UTC by avsharapov
Modified: 2022-02-05 10:03 UTC (History)
5 users (show)

See Also:
Crash report or crash signature:


Attachments
Select operation Edit (10.30 KB, image/jpeg)
2019-08-16 15:38 UTC, avsharapov
Details
Actual Result Table Designer (for Base View) (20.47 KB, image/jpeg)
2019-08-16 15:40 UTC, avsharapov
Details
Expected Result - View Designer (46.89 KB, image/jpeg)
2019-08-16 15:41 UTC, avsharapov
Details

Note You need to log in before you can comment on or make changes to this bug.
Description avsharapov 2019-08-16 07:30:47 UTC
Description:
Call the table editor instead of editor views

Steps to Reproduce:
1.Create View from Menu
2.Create any view
3.Save view
4.Try Edit View.


Actual Results:
See table editor instead of view editor

Expected Results:
I expected to see the view editor


Reproducible: Always


User Profile Reset: No



Additional Info:
Comment 1 Julien Nabet 2019-08-16 08:29:43 UTC
On pc Debian x86-64 with master sources updated today, I could reproduce this.
(I created an embedded Firebird db from scratch).
Comment 2 avsharapov 2019-08-16 15:38:12 UTC
Created attachment 153439 [details]
Select operation Edit
Comment 3 avsharapov 2019-08-16 15:40:21 UTC
Created attachment 153440 [details]
Actual Result Table Designer (for Base View)
Comment 4 avsharapov 2019-08-16 15:41:45 UTC
Created attachment 153441 [details]
Expected Result - View Designer
Comment 5 avsharapov 2019-08-16 15:45:14 UTC
I decided to add screenshots to show the selected menu item, the resulting actual mode and the mode I was expecting to see
Comment 6 Robert Großkopf 2020-03-13 15:47:39 UTC
Have opened the view editor for an internal Firebird database in LO 6.4.2.1. on OpenSUSE 15.1 64bit rpm Linux. No problem to open the editor here (but a new while saving views).

Could you confirm the bug has gone in LO 6.4.2.1?
Comment 7 trowelandmattock 2020-04-24 02:52:14 UTC
6.4 Base + Firebird (emb) /Win10 = no 'edit in SQL view" for views
6.4 Base + HSQLDB (emb) /Win10 = 'edit in SQL view' is available for views, as in previous LO versions...

:/  ...possibly 'edit in sql view' has never been available with firebird(embeded) as suggested here: https://ask.libreoffice.org/en/question/240210/where-did-edit-view-in-sql-option-go/?answer=240217#post-id-240217
Comment 8 Robert Großkopf 2020-04-24 07:17:17 UTC
Tested this again with a fresh created view in Firebird. Right mouseclick on the view and there is the possibility "Edit". But it opens only the tableeditor.

There is possible to create a view in the Tasks-pane of Tables. It will work as expected, but you can't edit the view for Firebird after you have saved and closed this editor.

This isn't only a Firebird problem. Have heard of the same problem, for example, in MySQL/MariaDB.

Tested all in LO 6.4.3.2 on OpenSUSE 15.1
Comment 9 Julien Nabet 2022-01-26 22:10:49 UTC
I gave a try here:
https://gerrit.libreoffice.org/c/core/+/129011
Comment 10 Commit Notification 2022-01-27 16:36:24 UTC
Julien Nabet committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/0adff3f2476f797843fb62d6810de90bfb333e10

tdf#126960, tdf#131330: FB make views editable+refresh auto after creation

It will be available in 7.4.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 11 Julien Nabet 2022-01-27 16:46:05 UTC
For 7.3, patch waiting for review here:
https://gerrit.libreoffice.org/c/core/+/129067

Robert: To respond comment 8 about Mysql part, I did some work on Mysql/Mariadb, it should be ok now to edit views. However, since there were lots of changes, it won't be backported in 7.3 branch.
Comment 12 Robert Großkopf 2022-01-27 17:03:09 UTC
(In reply to Julien Nabet from comment #11)
> For 7.3, patch waiting for review here:
> https://gerrit.libreoffice.org/c/core/+/129067
> 
> Robert: To respond comment 8 about Mysql part, I did some work on
> Mysql/Mariadb, it should be ok now to edit views. However, since there were
> lots of changes, it won't be backported in 7.3 branch.

Thanks Julien, will test it next Monday.
Comment 13 Julien Nabet 2022-01-27 20:36:52 UTC
The patch doesn't build on 7.3 branch and don't want to dig so I abandoned it.
If someone wants to try, don't hesitate.
Comment 14 Commit Notification 2022-01-31 09:40:49 UTC
Julien Nabet committed a patch related to this issue.
It has been pushed to "libreoffice-7-3":

https://git.libreoffice.org/core/commit/e7c652b90c44d9615a89e88ad3aa195b1fa6fbf7

tdf#126960, tdf#131330: FB make views editable+refresh auto after creation

It will be available in 7.3.1.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 15 Julien Nabet 2022-01-31 19:30:09 UTC
*** Bug 116953 has been marked as a duplicate of this bug. ***
Comment 16 Julien Nabet 2022-02-05 10:03:24 UTC
(In reply to Commit Notification from comment #14)
> Julien Nabet committed a patch related to this issue.
> It has been pushed to "libreoffice-7-3":
> 
> https://git.libreoffice.org/core/commit/
> e7c652b90c44d9615a89e88ad3aa195b1fa6fbf7
> 
> tdf#126960, tdf#131330: FB make views editable+refresh auto after creation
> 
> It will be available in 7.3.1.
> 
> The patch should be included in the daily builds available at
> https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
> information about daily builds can be found at:
> https://wiki.documentfoundation.org/Testing_Daily_Builds
> 
> Affected users are encouraged to test the fix and report feedback.

Thank you Xisco for having fixed the pb!