Description: It's currently not possible to resize objects such as pictures, draw objects, with a finger in the iOS app. Steps to Reproduce: 1. Insert a picture into a writer document on iOS 2. Try to resize the picture Actual Results: It's not possible to resize the picture. Expected Results: It should be possible to resize the picture. Reproducible: Always User Profile Reset: No Additional Info: This worked at some point and is a regression.
Been looking into this for some days. I tried cherry-picking more JS commits from the other branch but that did not help. Continuing.
Sigh, why did I not use bisection earlier to figure out when the regression happened? Firstly, bisecting using the TestFlight builds, I see that it happened between builds 43 and 44. Secondly, then using git bisect for that interval (in the online repo only), I find that it is this commit that causes it: commit e0e89427a1b14e4672b0b58949b413feb1941b31 Author: Henry Castro <hcastro@collabora.com> Date: Tue Jun 11 11:59:51 2019 -0400 loleaflet: mobile: create Map.CalcTap handler when initialize L.Map So now I just need to read through that commit and see if there is some part of it that should not be done in the case of touch clients, or something like that.
Oops, sorry, I mean this is the commit that introduced the regression: commit e0e89427a1b14e4672b0b58949b413feb1941b31 (HEAD, refs/bisect/bad) Author: Henry Castro <hcastro@collabora.com> Date: Tue Jun 11 11:59:51 2019 -0400 loleaflet: mobile: create Map.CalcTap handler when initialize L.Map
OK, figured out a solution. Two more side-ports from the internal collabora-online-4 branch were needed.
Fix is in the branch from which the iOS app is built, new TestFlight build is in review.