Bug 127094 - Bottom toolbar isn't displayed on mobile
Summary: Bottom toolbar isn't displayed on mobile
Status: RESOLVED WORKSFORME
Alias: None
Product: LibreOffice Online
Classification: Unclassified
Component: LibreOffice (show other bugs)
Version:
(earliest affected)
unspecified
Hardware: All All
: medium normal
Assignee: Not Assigned
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-08-22 07:15 UTC by OrangeDev
Modified: 2020-10-02 19:33 UTC (History)
2 users (show)

See Also:
Crash report or crash signature:


Attachments
Toolbar-down in the new version (32.45 KB, image/png)
2019-08-26 09:37 UTC, OrangeDev
Details
Bottom toolbar isn't displayed after click some toolbar icon (1.08 MB, video/mp4)
2019-08-29 02:33 UTC, OrangeDev
Details

Note You need to log in before you can comment on or make changes to this bug.
Description OrangeDev 2019-08-22 07:15:40 UTC
Description:
I'm using Libeoffice Online via docker image "libreoffice/online:master"
In old image version(5months ago), a bottom toolbar displays in Android browser but in latest image It don't display.
In safari, it occurs both old and latest image version.

Steps to Reproduce:
1. Access libeoffice online via Android browser or Safari
2. Click icon edit

Actual Results:
Don't display bottom toolbar

Expected Results:
Display button toolbar


Reproducible: Always


User Profile Reset: No



Additional Info:
Libeoffice Online via docker image "libreoffice/online:master"
Comment 1 Aron Budea 2019-08-25 04:01:33 UTC
If you scroll down with the v / ^ buttons on top of iOS virtual keyboard, does the toolbar appear then?
Comment 2 OrangeDev 2019-08-26 02:44:40 UTC
I don't have iPhone simulator. 
But i scroll down in the below devices but the toolbar doesn't appear:
- iPhone 7, iOS v12.3.1, Safari
- iPhone X, iOS v13.0, Safari
- Galaxy Note 8, Android9, SamSung Internet Browser v9.4.00.45
- Change user-agent of Firefox on Mac-OS to iPhone/Safari 12.1.1
- Change user-agent of Firefox on Mac-OS to Android phone/Firefox 68
- Change user-agent of Firefox on Mac-OS to Android phone/Chrome 76
Comment 3 OrangeDev 2019-08-26 09:37:14 UTC
Created attachment 153656 [details]
Toolbar-down in the new version
Comment 4 OrangeDev 2019-08-26 09:41:55 UTC
In my debug in old version of bundle.js, createToolbar() method has the following code:
        if (_inMobileMode()) {
            $("#mobile-edit-button").show();
            initMobileToolbar(toolItems)
        } else {
            $("#toolbar-down").show();
            initNormalToolbar(toolItems)
        }

But in the latest image, It become the followng code 
        function createToolbar() {
            if (_inMobileMode()) {
                $("#mobile-edit-button").show()
            } else {
                $("#toolbar-down").show();
                initNormalToolbar()
            }
        }
The initMobileToolbar() method have been removed.
So, if i add "$("#toolbar-down").show();" code into click event of #mobile-edit-button.
                if (L.Browser.mobile) {
                    var button = $("#mobile-edit-button");
                    button.show();
                    button.off("click");
                    var that = this;
                    button.on("click", function() {
                        button.hide();
                        that._enterEditMode("edit");
                        that.fire("editorgotfocus");
                        if (!(window.ThisIsTheiOSApp || window.ThisIsTheAndroidApp)) that.focus();
                        $("#toolbar-down").show();
                    });
                    this._enterReadOnlyMode("readonly")
                }

#toolbar-down will be displayed as attached file in the previous comment.

This is a non-related question, save icon in the toolbar-down was removed?
Comment 5 OrangeDev 2019-08-29 02:33:11 UTC
Created attachment 153726 [details]
Bottom toolbar isn't displayed after click some toolbar icon

After i used above method, bottom toolbar is shown in the edit screen.
But when i use some icon in the bottom, screen auto zoom-out and the toolbar isn't displayed.
Please check attached LOOL_toolbar.mp4 file.
Comment 6 Aron Budea 2019-09-13 06:38:51 UTC
Let's set the issue to confirmed. There are potentially multiple bugs together (eg. when LOOL is integrated into an app like Nextcloud/ownCloud, it can also cause the view to extend below the end of screen, and hide some content in the bottom).

LOOLWSD master (git hash: f7079c96)
LOKit   LibreOfficeDev 6.4.0.0.alpha0 (git hash: 61b757f)
Comment 7 Marco Marinello 2020-03-02 14:58:34 UTC
Just tried with LOOLwsd 6.4.0 and LOkit 6.4.1.1.0: Safari on iPad won't show both the bottom toolbar and the keyboard. Almost all buttons remain grey.
Comment 8 Aron Budea 2020-10-02 19:33:19 UTC
This should be working fine in recent builds.