Bug 127342 - Form Control toolbar icons in Tango set are from Colibre
Summary: Form Control toolbar icons in Tango set are from Colibre
Status: RESOLVED NOTABUG
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: UI (show other bugs)
Version:
(earliest affected)
6.1.0.3 release
Hardware: All All
: medium normal
Assignee: Not Assigned
URL:
Whiteboard:
Keywords: bibisected, bisected, regression
Depends on:
Blocks: Icon-Theme-Tango
  Show dependency treegraph
 
Reported: 2019-09-04 16:25 UTC by Aron Budea
Modified: 2019-09-10 01:28 UTC (History)
3 users (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Aron Budea 2019-09-04 16:25:53 UTC
- Switch icon set to Tango.
- Open View -> Toolbars -> Form Controls.

=> Most of the toolbar icons are from the Colibre icon set.

Observed using LO 6.4.0.0.alpha0+ (a40fbd031de042b0181dc5570164ae8ce0abb0f1) & 6.1.0.3 / Ubuntu 19.04 & Windows 7.
Icons are (presumably) from Tango in 6.0.0.3.
=> regression

Bibisected to the following commit using repo bibisect-linux-64-6.1. Adding Cc: to Heiko Tietze, please take a look sometimes.

https://cgit.freedesktop.org/libreoffice/core/commit/?id=8bdd059a1d64a1818ee0093d7a512fe38c4e2b20
author		heiko tietze <tietze.heiko@gmail.com>	2018-05-12 12:00:25 +0200
committer	Heiko Tietze <tietze.heiko@gmail.com>	2018-05-13 08:37:15 +0200

Icon themes clean-up
Comment 1 Heiko Tietze 2019-09-05 12:32:31 UTC
We don't have a maintainer for Tango and switch slowly towards Colibre as default (plus Elementary, Karasa Jaga, Sifr etc.). Therefore the fallback strategy has changed with https://gerrit.libreoffice.org/#/c/53092 and Colibre icons are now used as the last resort. So it's a NAB to expect Tango icons for new functions.
Comment 2 Aron Budea 2019-09-07 15:20:22 UTC
The functions aren't new, this is the good old Form Controls toolbar (though new functions may have been added to it over time). However since then I noticed the Tango toolbar icons were indeed not from the Tango icon set, and were fallbacks (already since 3.3), not sure why...

The Tango set has plenty of fitting icons in the cmd dir, eg. lc_insertfixedtext.png, lc_insertedit.png, lc_insertformcheck.png etc., but they aren't used, except the one for date picker: lc_insertdatefield.png.

A question is, would it be worth using the Tango assets for the toolbar? (even if not all functions have a corresponding icon... I definitely don't mean creating any new icons) Or is it completely left for dead?
Comment 3 Heiko Tietze 2019-09-08 07:52:54 UTC
Andreas, Rizal: What do you think?
Comment 4 Rizal Muttaqin 2019-09-10 01:26:30 UTC
(In reply to Aron Budea from comment #2)
> The functions aren't new, this is the good old Form Controls toolbar (though
> new functions may have been added to it over time). However since then I
> noticed the Tango toolbar icons were indeed not from the Tango icon set, and
> were fallbacks (already since 3.3), not sure why...
> 
> The Tango set has plenty of fitting icons in the cmd dir, eg.
> lc_insertfixedtext.png, lc_insertedit.png, lc_insertformcheck.png etc., but
> they aren't used, except the one for date picker: lc_insertdatefield.png.

Tango is the theme of old GNOME era. With the new Adwaita icons theme iteration, Tango turns to be not relevant, we have elementary for GNOME family based OS now. The icons you mentioned here does have similarities with another one so to keep the icon size small and reduce maintain burden we have defined them in the links.txt. I have checked them all one by one to avoid what Galaxy did.

> A question is, would it be worth using the Tango assets for the toolbar?
> (even if not all functions have a corresponding icon... I definitely don't
> mean creating any new icons) Or is it completely left for dead?

An icon could be a matter of subjective choice, but we lack of man power to keep it up beside no upstream which could be followed.
Comment 5 Rizal Muttaqin 2019-09-10 01:28:20 UTC
More than similarities, they are basically the same icons with different name.