Bug 127410 - Mail merge only correctly uses "Print empty pages" if doc is unmodified
Summary: Mail merge only correctly uses "Print empty pages" if doc is unmodified
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
6.4.0.0.alpha1+
Hardware: All All
: medium normal
Assignee: Michael Weghorn
URL:
Whiteboard: target:6.4.0 target:6.3.3
Keywords:
Depends on:
Blocks: Mail-Merge
  Show dependency treegraph
 
Reported: 2019-09-06 13:27 UTC by Michael Weghorn
Modified: 2019-09-17 10:04 UTC (History)
2 users (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Weghorn 2019-09-06 13:27:39 UTC
(found while looking at tdf#127409, so steps are the same as there + a few more)

Sample steps to reproduce:

0) delete existing user profile (e.g.'instdir/user' for dev build)
1) start Writer
2) make sure the following options are set like this in "Tools" -> "Options":
  * "Load/Save" -> "General" -> "Load user-specific settings with the document" is enabled (default)
  * "Load/Save" -> "General" -> "Load printer settings with the document" is enabled (default)
3) disable option "LibreOfficeDev Writer" -> "Print" -> "Print automatically inserted pages"
4) open attache attachment 153988 [details] "test_mailmerge.odt" from bug 127409 (which has "PrintEmptyPages" set to "true" in settings.xml)
5) run mail merge wizard and set "2.ods" (attachment attachment 153989 [details] from bug 127409) as data source to use (it has 2 records)
6) save the document
7) select "Print merged documents" from the mailmerge toolbar
8) select to print all pages
9) check printout
10) type some more text, e.g. so that "Hello world" is in the document
11) print again and check printout

Results:

* The printout in step 9 contains the following two pages (which is bug 127409):
  * The first page contains the printout for the first data record (a page with the word "Hello" on it)
  * The second page is blank
* The printout in step 11 contains the following two pages:
  * The first page contains the printout for the first data record (a page with the word "Hello" on it)
  * The second page contains the printout for the second data record (e.g. a page with the text "Hello world" on it for the above steps)

Expected results:

The printout shouldn't be dependent on whether the document was saved or not and be the same for steps 9 and 11 (s. bug 127409 for what is the expected result)

Version: 6.4.0.0.alpha0+
Build ID: 111cf7ee0b26a831577c7c03089f9de159aef16d
CPU threads: 4; OS: Linux 5.2; UI render: default; VCL: kf5; 
Locale: en-GB (en_GB.UTF-8); UI-Language: en-US
Calc: threaded
Comment 1 Michael Weghorn 2019-09-06 13:28:49 UTC
I've come across this while looking into bug 127409 and plan to submit fixes for both of them sometime soon.
Comment 2 Commit Notification 2019-09-08 07:20:01 UTC
Michael Weghorn committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/+/481166337b8187add77c9b2be9f6e2009692f90b%5E%21

tdf#127410 Reliably copy doc print settings for MM

It will be available in 6.4.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 3 Michael Weghorn 2019-09-08 07:22:55 UTC
Fixed on master; pending backport for 6.3: https://gerrit.libreoffice.org/#/c/78758/
Comment 4 Commit Notification 2019-09-17 10:04:40 UTC
Michael Weghorn committed a patch related to this issue.
It has been pushed to "libreoffice-6-3":

https://git.libreoffice.org/core/+/87f6c93541eb2360f07c942cf11ec2d9ac36fa17%5E%21

tdf#127410 Reliably copy doc print settings for MM

It will be available in 6.3.3.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.