Bug 127424 - Rework fix for Bug 63955 in ViewInformation per Armin's Suggestion
Summary: Rework fix for Bug 63955 in ViewInformation per Armin's Suggestion
Status: NEW
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: graphics stack (show other bugs)
Version:
(earliest affected)
6.1.0.0.alpha0+
Hardware: All All
: medium enhancement
Assignee: Not Assigned
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-09-07 15:24 UTC by Luke
Modified: 2019-09-24 03:11 UTC (History)
5 users (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Luke 2019-09-07 15:24:23 UTC
The fix for Bug 63955l introduced regressions. Armin Le Grand from bug 63955, comment #18 said:

"Why was this fixed *in the primitive creation* ? Primitive creation should always represent the 'truth' about the geometry. If decomposition takes too long, the fix should be where it gets decomposed. Each decomposition implementation at the primitive level *has* ViewInformation exactly for that purpose (!)
Did I mention that for dashed lines when *clipping* against *something* the dash *will move* and not be the same as when started from the line's start?

The fix also does not prevent a 18km long line be fed to rendering from other sources, only one source is eliminated. That's why it should be fixed where it gets visualized/discretized."

The regressions were worked around in Bug 120350 with a note suggesting to perform clipping elsewhere: 
https://cgit.freedesktop.org/libreoffice/core/commit/?id=1dccd6814f1f
Comment 1 Xisco Faulí 2019-09-23 11:17:03 UTC
Moving to NEW