Created attachment 154138 [details] Sample dialog that uses the uncommon "D" instead of "n" to choose "Don't Save". In Windows usually a button that reads "No" or that has the meaning of no (e.g. "Don't Save") always use the "n" as hotkey. Please change any button translation from "&Don't..." to "Do&n't...". (Assuming the hotkey is flagged by an ampersand) Thank you.
The actual gtk widget used is "discard" [1] and its .UI labeling here of "_Don't Save" is translatable for l10n needs. While "_Discard" would be equally acceptable label, no compelling reason to change from the "_Don't Save" nor to adjust the accelerator for "en" locales. The other place where "_Discard" is used is in the Document Recovery dialog, but where the label and accelerator is _Discard, but the gtk widget is actually to "cancel" the recovery. Its use is also translatable for l10n. So, IMHO here => NAB and WF -- the effort is up to the dev that writes the core en-US source and then the respective translators working l10n. =-ref-= [1] https://opengrok.libreoffice.org/xref/core/sfx2/uiconfig/ui/querysavedialog.ui?r=95e9f791#24 [2] https://opengrok.libreoffice.org/xref/core/svx/uiconfig/ui/docrecoveryrecoverdialog.ui?r=ed0c1bc4#40
The "_Don't" (with accelerator on the D) appears twice, once in the mentioned querysavedialog.ui and the other at the crashreportdlg.ui. Searching for "Do_n't" returns zarro results. So no objection but also no excitement from my side. @Christoph: We are happy to get more people into the project. So why don't you "hack" this patch yourself? It means to set-up the build environment [1a] (or just git [1b, 1c]), change the one accelerator [2, 3], and upload the patch). [1a] https://design.blog.documentfoundation.org/2018/02/22/easyhacking-set-environment/ [1b] https://blog.documentfoundation.org/blog/2019/06/03/start-developing-libreoffice-registering-with-git-and-gerrit-and-local-settings/ [1c] https://wiki.documentfoundation.org/Development/gerrit [2] https://design.blog.documentfoundation.org/2018/02/28/easyhacking-all-about-terminology/ [3] https://opengrok.libreoffice.org/xref/core/sfx2/uiconfig/ui/querysavedialog.ui?r=95e9f791#25
I have submitted a patch for this bug. https://gerrit.libreoffice.org/#/c/80558
shameempk committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/4c9cf046be055affee94a533f9db67f6fb0702cb tdf#127525 Replaces hotkeys for "Don't Save" button from "D" to "n". It will be available in 6.4.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Thanks for your patch, Muhammed. Do you want to do more of those easy hacks?
Thanks Heiko. I am not a UI developer per se. This was my first patch to understand the build process. I am open to more easy hacks. With a little mentoring I can look into some intermediate level bugs as well.
Verified with Version: 7.0.0.0.alpha1+ (x64) Build ID: 99c337d1d3831ce9d2c7dc1cbff713f4ac49d6ac CPU threads: 4; OS: Windows 10.0 Build 18363; UI render: Skia/Raster; VCL: win; Locale: en-GB (de_DE); UI: en-GB Calc: CL Shameen, thanks for fixing it!