Created attachment 154381 [details] patch to fix this bug The attached patch fixes sending documents to claws-mail. The problem was apparent when attempting to send a document which has spaces in its name.
i was told on irc to include a license statement for the patch. It has the same license as the file it patches.
Hello Paul, Thank you for providing the patch. Could you please upload to gerrit as described here < https://wiki.documentfoundation.org/Development/gerrit/SubmitPatch > ?
Hi, That sounds very convoluted for just a simple one-line patch. Can it not just be pushed by you or someone else?
Paul: I can submit your patch on gerrit after my day time job but at least, could you provide required licence information as described at https://wiki.documentfoundation.org/Development/GetInvolved ?
Julien, my patch doesn't not include any original code. The patch only replicates some code from the same file and re-uses it. Therefore, it's MPLv2, same as the file it patches.
> doesn't not I meant "does not".
Patch submitted here: https://gerrit.libreoffice.org/#/c/79423/
Hi Paul; thanks for the patch, I agree it's not necessary - but hopefully its ~trivial to send an E-mail to the list too (or privately to me if you have some privacy concern) - to keep our records in order. And thank againn for the fix =) No problem with you merging it as-is Julien; thanks for the ping.
(In reply to Michael Meeks from comment #8) > Hi Paul; thanks for the patch, I agree it's not necessary - but hopefully > its ~trivial to send an E-mail to the list too (or privately to me if you > have some privacy concern) - to keep our records in order. > > And thank againn for the fix =) No problem with you merging it as-is Julien; > thanks for the ping. Thank you Michael for your feedback. So I'll wait for Paul's license statement before pushing the patch.
license statement has been sent to the list
Julien Nabet committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/1c03df6e82e4bf30294fc0b9e64de5cc39efc5c4 tdf#127710: fix sending documents to Claws Mail It will be available in 6.4.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Thank you Paul for the patch and your license statement! I cherry-picked the patch for 6.3 branch, see https://gerrit.libreoffice.org/#/c/79460/
Julien Nabet committed a patch related to this issue. It has been pushed to "libreoffice-6-3": https://git.libreoffice.org/core/commit/95ddf1f58919608e29fdbe78080fbce4e5277f85 tdf#127710: fix sending documents to Claws Mail It will be available in 6.3.3. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.