Bug 127753 - Handle line attributes like area fill when merging shapes
Summary: Handle line attributes like area fill when merging shapes
Status: NEW
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Draw (show other bugs)
Version:
(earliest affected)
Inherited From OOo
Hardware: All Linux (All)
: medium normal
Assignee: Not Assigned
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: Shapes
  Show dependency treegraph
 
Reported: 2019-09-25 08:12 UTC by jlmerciers
Modified: 2023-04-02 06:07 UTC (History)
5 users (show)

See Also:
Crash report or crash signature:


Attachments
before the merge (31.93 KB, image/png)
2019-09-25 08:16 UTC, jlmerciers
Details
After the merge (25.30 KB, image/png)
2019-09-25 08:16 UTC, jlmerciers
Details
example (11.01 KB, application/vnd.oasis.opendocument.graphics)
2019-09-26 10:17 UTC, jlmerciers
Details

Note You need to log in before you can comment on or make changes to this bug.
Description jlmerciers 2019-09-25 08:12:27 UTC
Description:
When I merge forms the line on the forms disappear and the attribute doesn't exist any more.

Steps to Reproduce:
1. draw 2 forms
2. merge these 2 forms
3. the line and the line attibute disappear for the combined form

Actual Results:
same as the "Steps to Reproduce"

Expected Results:
Have the lines and the line attribute


Reproducible: Always


User Profile Reset: No


OpenGL enabled: Yes

Additional Info:
Comment 1 jlmerciers 2019-09-25 08:16:11 UTC
Created attachment 154468 [details]
before the merge
Comment 2 jlmerciers 2019-09-25 08:16:48 UTC
Created attachment 154469 [details]
After the merge
Comment 3 Xisco Faulí 2019-09-26 08:52:52 UTC
Thank you for reporting the bug.
it seems you're using an old version of LibreOffice.
Could you please try to reproduce it with the latest version of LibreOffice
from https://www.libreoffice.org/download/libreoffice-fresh/ ?
I have set the bug's status to 'NEEDINFO'. Please change it back to
'UNCONFIRMED' if the bug is still present in the latest version.
Comment 4 jlmerciers 2019-09-26 10:05:13 UTC
HI,

I installed version 6.3.1.2 (last)

The issue seems the same.

With combine function I have the line attribute and the line still on my drawing
With merge function I don't have the line attribute and the line desapear.

Thank you for your help.
Comment 5 Xisco Faulí 2019-09-26 10:06:27 UTC
Please attach a sample document, as this makes it easier for us to verify the bug. 
(Please note that the attachment will be public, remove any sensitive information before attaching it. 
See https://wiki.documentfoundation.org/QA/FAQ#How_can_I_eliminate_confidential_data_from_a_sample_document.3F for help on how to do so.)
Comment 6 jlmerciers 2019-09-26 10:17:27 UTC
Created attachment 154534 [details]
example

Attached the example file
Comment 7 QA Administrators 2019-09-27 03:05:43 UTC Comment hidden (obsolete)
Comment 8 jlmerciers 2019-09-28 06:28:04 UTC
HI,

the line disappear because the "no line" is set for the form after the merge.
The issue is solved when I set "no line" to a type of line.
it would be nice if the line attribute was kept after the merge.

Thank you for your help.
Comment 9 Gerhard Weydt 2019-11-20 19:29:30 UTC
Merging is a complicate process: the forms to be merged, which are custom shapes, are transformed into one closed Bézier shape, consisting obviously of may Bézier curves. In my test, which looked much like yours, I got, for example, 41 coordinates for the rectangle and 97 for the ellipse (if I interpret the fact correctly that there are two arrays). I think there are as much as 41 for the rectangle because if you look closely at it, you see its corners are rounded; for the ellipse agreat number of segments is no surprise. And there still is a so-called metafile having 36564 lines, I assume it contains information about the Bézier curves used, but I don't really know.
Now in your example both shapes had the same attributes, but the general case is that they may differ. The result of merging is one object, having one field for each attribute, so the solution to set the attribute to the default value seems logical.
On the other hand, area fill is handled differently: it seems that the colour of the object lying farthest back (menu item : Send to Back, Send Backward, as a default set in order of creation) is used to set the colour of the new object. So one could argue that the same procedure should apply to the line attributes, which in your example would exactly what you wish.
But then I would regard it as an enhancement request (set Importance: enhancement). If you do so, I will confirm the bug.
Comment 10 Buovjaga 2020-04-27 17:41:24 UTC
(In reply to Gerhard Weydt from comment #9)
> Now in your example both shapes had the same attributes, but the general
> case is that they may differ. The result of merging is one object, having
> one field for each attribute, so the solution to set the attribute to the
> default value seems logical.
>
> On the other hand, area fill is handled differently: it seems that the
> colour of the object lying farthest back (menu item : Send to Back, Send
> Backward, as a default set in order of creation) is used to set the colour
> of the new object. So one could argue that the same procedure should apply
> to the line attributes, which in your example would exactly what you wish.
> But then I would regard it as an enhancement request (set Importance:
> enhancement). If you do so, I will confirm the bug.

Let's ping UX
Comment 11 Heiko Tietze 2020-04-28 08:09:36 UTC
Merging takes the color of the first object, no line color/size but shape (try with a large dotted line). Drawing style preserves area fill settings but not what's defined for lines, the style has to be applied again.

As Gerhard pointed out, the merge process transforms the shapes into a bezier curve. And this object can have lines, makes sense to take the property from the first object.
Comment 12 QA Administrators 2022-04-29 03:44:48 UTC Comment hidden (obsolete)
Comment 13 jlmerciers 2022-04-29 08:09:02 UTC
Hello,

same on version 7.3.2.2.

When I merge two objects with a line the new object have no line.

Thank you for your help.