Bug 127770 - Freeze/crash on a cell formatted with rotation 180° and dashed borders
Summary: Freeze/crash on a cell formatted with rotation 180° and dashed borders
Status: VERIFIED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Calc (show other bugs)
Version:
(earliest affected)
6.0.0.3 release
Hardware: All All
: high major
Assignee: Not Assigned
URL:
Whiteboard: target:7.3.0
Keywords: bibisected, bisected, perf, regression
Depends on:
Blocks: Cell-Border
  Show dependency treegraph
 
Reported: 2019-09-26 06:35 UTC by Mike Kaganski
Modified: 2021-09-09 20:21 UTC (History)
5 users (show)

See Also:
Crash report or crash signature:


Attachments
Cell formatted 180° text rotation and dashed borders (7.80 KB, application/vnd.oasis.opendocument.spreadsheet)
2019-09-26 06:35 UTC, Mike Kaganski
Details
strange things (2.08 MB, video/mp4)
2021-06-19 15:14 UTC, BogdanB
Details
this is 7.3 strange behaviour (2.71 MB, video/mp4)
2021-06-19 15:19 UTC, BogdanB
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Mike Kaganski 2019-09-26 06:35:01 UTC
Created attachment 154509 [details]
Cell formatted 180° text rotation and dashed borders

Formatting a spreadsheet cell to have dashed borders and text orientation set to 180° makes Calc freeze and/or crash (it crashes fast with 32-bit builds, and freezes in 64-bit builds, but eventually would also crash).

This is a regression from https://git.libreoffice.org/core/+/e32c12a444e5bd0c6735db8e8008340c29a7e25e (CCing Armin Le Grand).

The freeze happens in basegfx::utils::applyLineDashing, where fEdgeLength (in "simple edge" branch) gets a really huge value because of insanely slanted polygon (in my 64-bit build, it is greater than 30000000000000000).

The attachment has A1 formatted like that (the file was created with a pre-6.0 version). Opening it with 6.0+ shows the problem.
Comment 1 Roman Kuznetsov 2019-09-26 06:41:36 UTC
confirm in

Версия: 6.4.0.0.alpha0+ (x86)
ID сборки: b1dd4244b60948a6dd84872799e508effa164cba
Потоков ЦП: 4; ОС:Windows 6.1; Отрисовка ИП: по умолчанию; VCL: win; 
TinderBox: Win-x86@62-TDF, Branch:MASTER, Time: 2019-09-25_07:01:29
Локаль: ru-RU (ru_RU); Язык интерфейса: ru-RU
Calc: threaded

It took over 1,5Gb of memory, then Windows killed soffice.bin
Comment 2 Noel Grandin 2021-06-13 14:36:38 UTC
I can't reproduce this with current master
Comment 3 Mike Kaganski 2021-06-13 17:11:44 UTC
Yes, also doesn't freeze using Version: 7.1.4.1 (x64) / LibreOffice Community
Build ID: f67b1ddedeb24fca1c5938e7cebfab73d708b35b
CPU threads: 12; OS: Windows 10.0 Build 19043; UI render: Skia/Raster; VCL: win
Locale: ru-RU (ru_RU); UI: en-US
Calc: threaded

WORKSFORME.
Comment 4 Xisco Faulí 2021-06-14 08:40:31 UTC
Issue fixed by

author	Armin Le Grand <Armin.Le.Grand@me.com>	2020-02-14 16:47:14 +0100
committer	Armin Le Grand <Armin.Le.Grand@me.com>	2020-02-14 19:19:49 +0100
commit 62ac8333999c661432adb0a18245a399daa89dcb (patch)
tree 9199e1e920765cc343646f472d7491f63d438a37
parent fd7749fddc5a767461dfced55369af48e5a6d561 (diff)
tdf#130655 callback interface for 3D and secure dash
Comment 5 BogdanB 2021-06-19 15:14:52 UTC
Created attachment 173016 [details]
strange things

Something is still strange here. See my video
Comment 6 BogdanB 2021-06-19 15:19:27 UTC
Created attachment 173017 [details]
this is 7.3 strange behaviour

I am not sure the previous video was 7.1.4 or 7.3, so I did this last video with 7.3.

Version: 7.3.0.0.alpha0+ / LibreOffice Community
Build ID: 51754ca5349d7bf655d57ded37381188d0bc4bcf
CPU threads: 4; OS: Linux 5.8; UI render: default; VCL: gtk3
Locale: ro-RO (ro_RO.UTF-8); UI: en-US
Calc: threaded
Comment 7 Mike Kaganski 2021-06-19 16:43:03 UTC
(In reply to BogdanB from comment #6)

Indeed, the drawing of this kind of A1 border is not fixed; but this bug was about freeze/crash, and it is FIXED. The problem that is left should be tracked separately.
Comment 8 BogdanB 2021-06-19 16:44:15 UTC
No crash
Comment 9 Commit Notification 2021-09-09 20:21:57 UTC
Caolán McNamara committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/e5ced8a0e875226152ceae2ad84bac0292e20c4f

crashtesting: assert making thumbnail on reexport of tdf127770-1.ods to ods

It will be available in 7.3.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.