Created attachment 154569 [details] border dialog 01 Main issues of the boarders tab is: - shadow group is not together in one group (one column) - Labels are top align only at padding group the labels are left align Change request - Shadow Style is together in one group so it's clear that the three settings are for shadow - Labels should be according to the HIG or the config dialog left align. The benefit is better readability and better alignment between the different groups. The issue is that you need more horizontal width, which is not really an issue, cause of widescreen's AND the minimal size of dialogues in general.
While the proposal follows the rules it looks less balanced than before. One problem is the labeling of multiple controls similar to single elements. You never do things like Option 1 (o) Another Option 2 ( ) Whatever Option 3 ( ) (radio buttons) but Options: (o) First ( ) Another Second ( ) Whatever Third So we should do the same perhaps for those combined controls here. Meaning Presets, User-defined, and Position are to be placed above the set. Might work for the first two but not for Position (I like the grouping for Shadow options). Ultimately, a guideline is nothing you have to follow strictly without exception. "Merge with..."/Properties in the middle column looks displaced. I would put it at bottom left. And last but not least it's desirable to have equally sized columns, if possible.
Created attachment 154664 [details] border dialog 02 thanks for the feedback heiko. what do you think?
(In reply to andreas_k from comment #2) > Created attachment 154664 [details] Presets and User-defined content has too much indentation. And it looks like padding is related to the shadow.
I share the opinion of Heiko in comment 3. Maybe it helps if you change the arrangements of the sections: Line Arrangement Padding Line Shadow Style Properties On the current arrangement of the border tab I like that it's good readable for Western LTR users: Line Arrangement -> Line -> Padding The other sections are less important and in the bottom part of the dialog (Shadow Style, Properties). What I don't like in the current dialog is that Shadow Style is streched over 3 rows what it shouldn't. This is better realized in your proposal, Andreas. I'm not sure if the height of the dialog is too large. In my current LibreOffice installation on Ubuntu the dialog is more wide than high. In your proposal it's more like a square.
I would position "Merge Adjacent line styles" above Shadow Styles. It is related to the settings above there.
UX input given, removing the keyword.
Created attachment 155135 [details] border dialog 03 Line Arrangement - No change - labels are on top Line group - labels are left align like in Padding (or in most groups) Shadow Style - one compact group in the second column Properties - group on the left Padding - no change
(In reply to andreas_k from comment #7) > Shadow Style > - one compact group in the second column Not a fan of those random columns but the shadow group is an advantage.
I saw that Shadow is in Border but the property is table related (you can't shadow an specific selection) so the question is should the shadow items be located in border or better in table.
Created attachment 155325 [details] border dialog 04 Now I'm fine with the dialog. It's compact has only two columns and the groups are related to each other Line Arrangement - > Line Shadow Style and Padding are secondary settings Properties are aditonal settings.
In principle it's good. But the right columns seems to align at the right border (without sufficient margins). I would place it right of the left column with some spacing. And we talked at another dialog about textual controls (dropdowns) and numeric (spinner) that shouldn't resize equally.
04 looks good except Heiko's hint in his last comment. The option columns should align to the left and should be arranged in equally widths with a spacing between columns. Is this defined somewhere?
(In reply to Thomas Lendo from comment #12) > Is this defined somewhere? The guideline is in draft.
andreas kainz committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/6c4e6fc1d3a74c2840bf5a41ce1cde1debb07f24 tdf#127807 Border Dialog update It will be available in 6.5.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
andreas kainz committed a patch related to this issue. It has been pushed to "libreoffice-6-4": https://git.libreoffice.org/core/commit/427b4303ffe2d39a5fa554f537c5d4be4d2a14e4 tdf#127807 Border Dialog update It will be available in 6.4.0.1. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.