Bug Hunting Session
Bug 127807 - Make Border in Writer dialog Table Properties HIG conform
Summary: Make Border in Writer dialog Table Properties HIG conform
Status: NEW
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: UI (show other bugs)
Version:
(earliest affected)
unspecified
Hardware: All All
: medium normal
Assignee: Not Assigned
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: Borders-Tab
  Show dependency treegraph
 
Reported: 2019-09-27 06:38 UTC by andreas_k
Modified: 2019-11-04 09:33 UTC (History)
6 users (show)

See Also:
Crash report or crash signature:


Attachments
border dialog 01 (78.29 KB, image/png)
2019-09-27 06:38 UTC, andreas_k
Details
border dialog 02 (36.64 KB, image/png)
2019-10-01 08:11 UTC, andreas_k
Details
border dialog 03 (96.53 KB, image/png)
2019-10-18 22:19 UTC, andreas_k
Details
border dialog 04 (39.58 KB, image/png)
2019-10-26 12:47 UTC, andreas_k
Details

Note You need to log in before you can comment on or make changes to this bug.
Description andreas_k 2019-09-27 06:38:23 UTC
Created attachment 154569 [details]
border dialog 01

Main issues of the boarders tab is:
- shadow group is not together in one group (one column)
- Labels are top align only at padding group the labels are left align

Change request
- Shadow Style is together in one group so it's clear that the three settings are for shadow
- Labels should be according to the HIG or the config dialog left align. The benefit is better readability and better alignment between the different groups. The issue is that you need more horizontal width, which is not really an issue, cause of widescreen's AND the minimal size of dialogues in general.
Comment 1 Heiko Tietze 2019-10-01 07:10:02 UTC
While the proposal follows the rules it looks less balanced than before. One problem is the labeling of multiple controls similar to single elements. You never do things like

Option 1          (o)
Another Option 2  ( )
Whatever Option 3 ( )
(radio buttons)

but

Options:
 (o) First
 ( ) Another Second
 ( ) Whatever Third

So we should do the same perhaps for those combined controls here. Meaning Presets, User-defined, and Position are to be placed above the set. Might work for the first two but not for Position (I like the grouping for Shadow options).
Ultimately, a guideline is nothing you have to follow strictly without exception.

"Merge with..."/Properties in the middle column looks displaced. I would put it at bottom left. And last but not least it's desirable to have equally sized columns, if possible.
Comment 2 andreas_k 2019-10-01 08:11:40 UTC
Created attachment 154664 [details]
border dialog 02

thanks for the feedback heiko. what do you think?
Comment 3 Heiko Tietze 2019-10-01 08:18:37 UTC
(In reply to andreas_k from comment #2)
> Created attachment 154664 [details]

Presets and User-defined content has too much indentation. And it looks like padding is related to the shadow.
Comment 4 Thomas Lendo 2019-10-08 19:47:24 UTC
I share the opinion of Heiko in comment 3.

Maybe it helps if you change the arrangements of the sections:

Line Arrangement             Padding

Line                         Shadow Style

Properties


On the current arrangement of the border tab I like that it's good readable for Western LTR users:

Line Arrangement   ->   Line   ->    Padding

The other sections are less important and in the bottom part of the dialog (Shadow Style, Properties).

What I don't like in the current dialog is that Shadow Style is streched over 3 rows what it shouldn't. This is better realized in your proposal, Andreas.

I'm not sure if the height of the dialog is too large. In my current LibreOffice installation on Ubuntu the dialog is more wide than high. In your proposal it's more like a square.
Comment 5 Cor Nouws 2019-10-09 19:13:35 UTC
I would position "Merge Adjacent line styles" above Shadow Styles.
It is related to the settings above there.
Comment 6 Heiko Tietze 2019-10-10 07:35:32 UTC Comment hidden (off-topic)
Comment 7 andreas_k 2019-10-18 22:19:41 UTC
Created attachment 155135 [details]
border dialog 03

Line Arrangement
- No change
- labels are on top

Line group
- labels are left align like in Padding (or in most groups)

Shadow Style
- one compact group in the second column

Properties
- group on the left

Padding
- no change
Comment 8 Heiko Tietze 2019-10-21 09:42:37 UTC
(In reply to andreas_k from comment #7)
> Shadow Style
> - one compact group in the second column

Not a fan of those random columns but the shadow group is an advantage.
Comment 9 andreas_k 2019-10-21 12:51:15 UTC
I saw that Shadow is in Border but the property is table related (you can't shadow an specific selection) so the question is should the shadow items be located in border or better in table.
Comment 10 andreas_k 2019-10-26 12:47:40 UTC
Created attachment 155325 [details]
border dialog 04

Now I'm fine with the dialog.

It's compact has only two columns and the groups are related to each other

Line Arrangement - > Line

Shadow Style and Padding are secondary settings Properties are aditonal settings.
Comment 11 Heiko Tietze 2019-10-28 10:12:05 UTC
In principle it's good. But the right columns seems to align at the right border (without sufficient margins). I would place it right of the left column with some spacing. And we talked at another dialog about textual controls (dropdowns) and numeric (spinner) that shouldn't resize equally.
Comment 12 Thomas Lendo 2019-11-03 00:27:25 UTC
04 looks good except Heiko's hint in his last comment.

The option columns should align to the left and should be arranged in equally widths with a spacing between columns. Is this defined somewhere?
Comment 13 Heiko Tietze 2019-11-04 09:33:34 UTC Comment hidden (off-topic)