Bug Hunting Session
Bug 127934 - Make Cell Format dialog HIG conform
Summary: Make Cell Format dialog HIG conform
Status: NEW
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: UI (show other bugs)
Version:
(earliest affected)
unspecified
Hardware: All All
: medium normal
Assignee: Not Assigned
URL:
Whiteboard: target:6.4.0
Keywords:
Depends on:
Blocks: Cell-Format-Dialog
  Show dependency treegraph
 
Reported: 2019-10-02 19:13 UTC by andreas_k
Modified: 2019-10-18 09:55 UTC (History)
4 users (show)

See Also:
Crash report or crash signature:


Attachments
Cell Format 01 (153.28 KB, image/png)
2019-10-02 19:13 UTC, andreas_k
Details
Screenshot with the patch applied (56.45 KB, image/png)
2019-10-10 09:44 UTC, Heiko Tietze
Details

Note You need to log in before you can comment on or make changes to this bug.
Description andreas_k 2019-10-02 19:13:03 UTC
Created attachment 154715 [details]
Cell Format 01

Top: Master
Bottm: Proposal

Tab Numbers:
- Language Section is in Font tab so I don't see an reason to have it at Numbers tab too.
- Options are related to Category -> Format so it is left to Format (also at Excel)
- Preview is on bottom like in Font tab (next one)
- Format code (I don't know what are the 3 buttons and the User-defined label for)

Tab Alignment:
- Text Alignment items in different rows (like in Excel and ordinary in most LibO groups)
- text Orientation labels and options left and "preview" right, cause preview is ordinary right
- Text direction I don't know if this should be visible cause ordinary LTR <-> RTL options are only visible when selected in global LibO options dialog.
Comment 1 Heiko Tietze 2019-10-08 12:08:15 UTC
Missing Language at Numbers tab (affects the list of formats, see Hebrew for example). Alternative layout would be to show the preview on the right column and options below the lists.

Regarding Alignment, the Indent(ation) relates to the Horizontal alignment (only for Left). Would place it next to this dropdown. No hard feelings about the rest.
Comment 2 Cor Nouws 2019-10-09 19:00:31 UTC
Thanks - looks good in general. Apart - as Heiko said - skipping language. That definitely is needed here.
Comment 3 Heiko Tietze 2019-10-10 07:40:06 UTC
UX input given, removing the keyword.
Comment 4 Heiko Tietze 2019-10-10 09:44:09 UTC
Created attachment 154894 [details]
Screenshot with the patch applied

Commenting on Gerrit...
Comment 5 Thomas Lendo 2019-10-10 20:05:44 UTC
Was the Numbers tab also changed now?

Alignment tab:
I don't like that the text alignment drop-down buttons are so long.
And I also don't like that the text orientation degree +/- field and the degree wheel are visually detached. They must stay together and it's not only a preview image, it can be used to change the degrees by mouse.
Comment 6 Commit Notification 2019-10-18 09:55:58 UTC
andreas kainz committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/9ab51f7aead713516b7e9a30aa64190d80517cbc

tdf#127934 Make Cell Format Align Dialog HIG conform

It will be available in 6.4.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.