Description: Moving a slide up/down doesn't work in 4.1.63 anymore. It used to work in 4.1.61. This seems to be a regression betweend those two versions. Steps to Reproduce: 1. Open a slidedeck using the iOS app version 4.1.63 2. Create multiple slides 3. Try to move slides up or down Actual Results: It's not possible to move slides. Expected Results: It should be possible to change the slide order. Reproducible: Always User Profile Reset: No Additional Info: This can easily be tested with "testflight" where one can simply install different version of the app.
Moving to NEW as agreed in the ESC meeting
If I install the 4.1.61 build on my iPad, it doesn't work in that either. Could it be that it was some of the recent iOS upgrades that broke this functionality? Does it still work in iOS 12?
Sorry, I forgot to mention it: it's a regression on iOS 12.x But I have in mind that it's broken in iOS 13.x as well (but since longer) - I'll add a separate bug for that.
Created attachment 154753 [details] screenshot Actually, it is possible to reorder slides in 4.1.63 on iOS 13, it is just very picky how to do it. If you press too long on a slide preview in the left-side pane, the system causes the slide preview image to "pops up" with a dialog that offers you to "Share...", "Add to Photos" or "Copy" the image. See this screenshot. Ideally we should figure out a way to prevent this from happening. It is very confusing. (More comments coming up.)
Created attachment 154754 [details] screenshot Bit if you press long but not too long on a slide preview image, you can drag a "ghost" image of it around, see this screenshot. This is presumably functionality offered by our JavaScript code.
Created attachment 154756 [details] screenshot And if you then let go of it at the right spot between two slides, the dragged slide will be placed there, voilà.
So what needs to be done is, I think, to make the area where the dragged slide preview can be dropped larger so that it is easier to use. Also, should figure out a way to prevent that system functionality from interfering.
Created attachment 154758 [details] screenshot The drop target area can be enlarged with a single-line change in a css file, it seems. It's the red thing in this screenshot. (In 4.1.63 it is only two pixels high and hard to see.) When that is visible it is possible to drop the slide and it will go below the slide indicated with the red Nicolas, would this be a good enough solution for now?
There is, however, a different bug in the slider reordering functionality. It is always the selected slide that is moved to the drop position, not the one you are dragging.
Thanks for looking into this Tor! I'm aware of the issues you described and think (also on iOS 13.x) this is an area where a bit of work is needed. The following things are usually a problem: * (on iOS 13.x) when pressing long on a slide preview the system causes the slide preview image to "pop up" with a dialog that offers you to "Share...", "Add to Photos" or "Copy" the image * it's very hard to move the first slide (also in iOS 12.x IIRC) * the selected slide will be moved, not the one a user is dragging Maybe having two buttons "move slide up" / "move slide down" would be simpler to implement?
Making the dropsite visual indication larger: https://gerrit.libreoffice.org/#/c/80203/ (An iPad counts as a "large display" here. Our code uses 768 pixels as a limit when deciding how the UI should look.)
The system pop-up thing is avoided by: https://gerrit.libreoffice.org/#/c/80208/
The remaining major problem is that it is the selected slide that gets moved, not the one the user had dragged. This might be a somewhat more complex problem to solve. What is your preference, Nicolas, should I produce and upload a new build of the app as it is now, and then it hopefully will be reviewed and accepted during the weekend? Or wait until I have fixed that remaining issue, too?
An easy-ish way would perhaps be to make starting a drag of a slide also make it the selected slide. Then no changes to the LibreOfficeKit API and the C++ parts of Online would be needed. Would that be acceptable?
Yes, I think "... make starting a drag of a slide also make it the selected slide." would be a good solution. Thanks Tor!
Done in https://gerrit.libreoffice.org/80214
Tor Lillqvist committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/online/commit/ef98d92cb9fb4e0d31e0843d26153cdc05657f83 tdf#127942: Make the slide preview image dropsite larger on larger displays
Tor Lillqvist committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/online/commit/0e49800418d26c0a213638bc693b3d01aa58909e tdf#127942: Avoid the WKWebView popup with "Share...", "Add to Photos" etc
Tor Lillqvist committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/online/commit/bf5ca0b1fcd6b03078fa8e90b2c9cc945b189048 tdf#127942: Make a slide that is being dragged (for re-ordering) the selected
Fixed. Tested in 4.1.64. The issue can be closed. Thanks a lot to the Collabora team for fixing this!
OK, resolving.