Bug 128095 - Improve EditEngine look when not editing.
Summary: Improve EditEngine look when not editing.
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Impress (show other bugs)
Version:
(earliest affected)
6.4.0.0.alpha1+
Hardware: All All
: medium major
Assignee: Not Assigned
URL:
Whiteboard:
Keywords: needsUXEval
Depends on:
Blocks:
 
Reported: 2019-10-11 14:27 UTC by Michael Meeks
Modified: 2019-10-14 10:24 UTC (History)
2 users (show)

See Also:
Crash report or crash signature:


Attachments
patch (1.03 KB, patch)
2019-10-11 14:27 UTC, Michael Meeks
Details
Field variants (12.66 KB, image/png)
2019-10-14 10:24 UTC, Heiko Tietze
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Meeks 2019-10-11 14:27:19 UTC
Created attachment 154938 [details]
patch

We had a complaint from a customer about field-marks being visible when not editing. This (trivial) patch essentially removes the grey field-mark background from the view when you are not editing a text.

	eg. a hyperlink in Impress or Calc.

When you edit it is still there - to show how it behaves (as a big block rather than text you can navigate through).

Thoughts from UX people as to whether to include it are much appreciated.

Thanks.
Comment 1 Eike Rathke 2019-10-11 15:32:29 UTC
Similar is already done since
https://gerrit.libreoffice.org/plugins/gitiles/core/+/1b8886ad7744fc48e09bb7379d8ad8e75bb3084d%5E%21/
with the extra that it differentiates between URL fields and non-URL fields.
The field shading is only shown in the Input Line, not the cell grid view.
Comment 2 Michael Meeks 2019-10-11 18:26:07 UTC
Ah - sounds like we can close this then - thanks Eike ! =)
Comment 3 Heiko Tietze 2019-10-13 12:24:11 UTC
I don't see the point of highlighting in edit mode only. Maybe to indicate that editing is applied to the whole block, but I understand this as a secondary use case. More relevant is to see what cells in the sheet hold such special cases, meaning the field shading is needed exactly the opposite way. And if users don't need this information, it should be possible to switch it off. Like it's handled in Writer. OTOH, if we talk about only URLs...
Comment 4 Eike Rathke 2019-10-14 10:00:10 UTC
Please take a look at how things are implemented now. Date, Sheet Name and Document Title fields that can be inserted via context menu while editing a cell (and will be "recalculated") are shaded; URL fields (including mailto et all) that result of input detection are not shaded in the grid view, but are shaded in the Input Line (regardless whether editing or not) or when editing the cell inline.
Comment 5 Heiko Tietze 2019-10-14 10:24:00 UTC
Created attachment 154992 [details]
Field variants

Current situation is a bit complex.

I would recommend to have an option "Field Shadings" (Ctrl+F8) that highlights all dynamic fields, URLs, and variable data (streams and xml source, data provider if those data are updated) in view mode. The edit mode should remain with highlighting.

Bike shedding: The gray colors for URL and fields look different.