Bug 128105 - Asymmetric closing cross on toolbars on Windows
Summary: Asymmetric closing cross on toolbars on Windows
Status: RESOLVED WORKSFORME
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: UI (show other bugs)
Version:
(earliest affected)
6.3.2.2 release
Hardware: All Windows (All)
: medium normal
Assignee: Not Assigned
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-10-12 11:40 UTC by Mike Kaganski
Modified: 2022-01-29 15:44 UTC (History)
3 users (show)

See Also:
Crash report or crash signature:


Attachments
Toolbar with an asymmetric closing cross (1.80 KB, image/png)
2019-10-12 11:40 UTC, Mike Kaganski
Details
The closing X clipped from attachement 154951 to try to identify font (888 bytes, image/png)
2019-10-12 15:43 UTC, V Stuart Foote
Details
redaction toolbar from 6.4.0.3 Windows OpenGL rendering (1.81 KB, image/png)
2020-01-29 14:51 UTC, V Stuart Foote
Details
Cross in master toward 7.4 (5.37 KB, image/png)
2022-01-29 09:54 UTC, Mike Kaganski
Details
toolbar (Redaction) closing cross 7.2.5 vs recent master - 7.4.0 (155.56 KB, image/png)
2022-01-29 15:05 UTC, V Stuart Foote
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Mike Kaganski 2019-10-12 11:40:20 UTC
Created attachment 154951 [details]
Toolbar with an asymmetric closing cross

The attached screenshot shows the closing cross in toolbar's top right corner, which has shorter top-right and bottom-right legs than their left counterparts.

Tested with Version: 6.3.2.2 (x64)
Build ID: 98b30e735bda24bc04ab42594c85f7fd8be07b9c
CPU threads: 12; OS: Windows 10.0; UI render: GL; VCL: win; 
Locale: ru-RU (ru_RU); UI-Language: en-US
Calc: threaded
Comment 1 V Stuart Foote 2019-10-12 12:45:39 UTC
That looks like the 0x2717 Ballot X
Comment 2 V Stuart Foote 2019-10-12 15:43:09 UTC
Created attachment 154958 [details]
The closing X clipped from attachement 154951 to try to identify font

Can not confirm with clean profile on Windows 10 Home 64-bit en-US (1903) with
Version: 6.3.2.2 (x64)
Build ID: 98b30e735bda24bc04ab42594c85f7fd8be07b9c
CPU threads: 4; OS: Windows 10.0; UI render: default; VCL: win; 
Locale: en-US (en_US); UI-Language: en-US
Calc: threaded

For the Redaction dialog app frame, the font used for the glyph appears to be Segoe UI, with well formed X.

I hunted (Fontsquirrel, BableMap) for what font might be substituted shown in your clip--but could no luck. I thought maybe 0x0058 from Segoe Print or Mistral but no.
Comment 3 Xisco Faulí 2020-01-23 12:34:13 UTC
Hi Mike,
is this issue still reproducible with a master build ?
Comment 4 Mike Kaganski 2020-01-23 13:53:39 UTC
(In reply to Xisco Faulí from comment #3)
> is this issue still reproducible with a master build ?

No, cannot repro with Version: 6.5.0.0.alpha0+ (x64)
Build ID: 5b6881df2018647b6a5f7ff72631680c5f6a1988
CPU threads: 12; OS: Windows 10.0 Build 18363; UI render: GL; VCL: win; 
Locale: ru-RU (ru_RU); UI-Language: en-US
Calc: CL

(I'm using skia now, so didn't see if it was still there in OpenGL)
Comment 5 V Stuart Foote 2020-01-29 14:51:12 UTC
Created attachment 157501 [details]
redaction toolbar from 6.4.0.3 Windows OpenGL rendering

So this affects Windows builds with OpenGL rendering (and Skia/Vulkan on master). Undocked floating toolbars use and odd font to decorate the icon for the 'close' button.

Dialog frames use the correct font, just floating toolbars.

CPU only or Hardware Accelerated mode is not affected, just OpenGL

Version: 6.4.0.3 (x64)
Build ID: b0a288ab3d2d4774cb44b62f04d5d28733ac6df8
CPU threads: 4; OS: Windows 10.0 Build 18362; UI render: GL; VCL: win; 
Locale: en-US (en_US); UI-Language: en-US
Calc: threaded

also against recent master
Version: 7.0.0.0.alpha0+ (x64)
Build ID: a22de0aacc9fb4197e9051f572b1a9298b2472e2
CPU threads: 4; OS: Windows 10.0 Build 18362; UI render: GL; VCL: win; 
Locale: en-US (en_US); UI-Language: en-US
Calc: threaded


See also bug 130253, and bug 125798 suggest not just Windows builds
Comment 6 V Stuart Foote 2020-01-29 15:04:31 UTC
@Mike, found Skia is also affected could you have another look. And, the see alsos are against the dialog frame decorations, coincidence or related? Are the icons for button decoration being built from system fonts, or do we package them ready made?
Comment 7 Mike Kaganski 2020-01-29 15:08:52 UTC
OMG. Of course it's still there both in 6.4.0.3 and in current master. It seems I looked in a different place last time I checked, sorry.

(tested now with OpenGL, since lately a change has been made into Skia that disables it on my non-Vulkan-capable graphics).
Comment 8 QA Administrators 2022-01-29 03:54:32 UTC Comment hidden (obsolete)
Comment 9 Mike Kaganski 2022-01-29 09:54:03 UTC
Created attachment 177897 [details]
Cross in master toward 7.4

The left on the screenshot is Version: 7.4.0.0.alpha0+ (x64) / LibreOffice Community
Build ID: a4348ec796e6efe0edce7bb8bfa47b1fa95d0e34
CPU threads: 12; OS: Windows 10.0 Build 19044; UI render: Skia/Raster; VCL: win
Locale: ru-RU (ru_RU); UI: en-US
Calc: CL

The right is the same version, with UI render: default

So I can't exactly repro. The cross now looks OK in non-Skia mode; it is a bit deformed in Skia. It is not centered.
Comment 10 V Stuart Foote 2022-01-29 15:05:24 UTC
Created attachment 177904 [details]
toolbar (Redaction) closing cross 7.2.5 vs recent master - 7.4.0

Asymmetry was still present with Skia Vulkan rendering through 7.2.4 builds, but is gone with resent master against 7.4.0

=-testing-=

RenderMethod: vulkan
Vendor: 0x8086
Device: 0x8a52
API: 1.2.195
Driver: 0.404.1069
DeviceType: integrated
DeviceName: Intel(R) Iris(R) Plus Graphics
Denylisted: no


Version: 7.4.0.0.alpha0+ (x64) / LibreOffice Community
Build ID: 52443996eff721e612ac4afc1eb1a53bb8a3e06f
CPU threads: 8; OS: Windows 10.0 Build 19044; UI render: Skia/Vulkan; VCL: win
Locale: en-US (en_US); UI: en-US
Calc: threaded

Version: 7.2.5.1 (x64) / LibreOffice Community
Build ID: 6d497ff5e83a906a307eb25cce314d40c0b8624f
CPU threads: 8; OS: Windows 10.0 Build 19044; UI render: Skia/Vulkan; VCL: win
Locale: en-US (en_US); UI: en-US
Calc: threaded
Comment 11 V Stuart Foote 2022-01-29 15:44:35 UTC
IIRC like Chris S. and Mark H. have reworked some of the font handling of late, with recent master against 7.4 we no longer are getting an odd font being used for the toolbars. And the asymmetry of the cross with Skia Vulkan (or previous OpenGL) does seem to be gone.

So, => WFM