I can confirm with Version: 6.4.0.0.alpha0+
Build ID: 9b5dad13b56bdde7c40970351af3da3a2c3c9350
CPU threads: 4; OS: Linux 4.15; UI render: default; VCL: x11; 

use
print ccur(str("75,50"))
print ccur(cdbl("75,50"))

I don't think it's a bug, because ccur should be compatible with VBA (or it's VBA function).

So then the manual is wrong (”The locale settings are used for decimal separators and currency symbols”, but they are clearly not). Should I report that in a separate bug report for the documentation?

This bug report could be qualified as difficultyInteresting, since it requests the usage of the numberformatter including the locale settings with additional testing of the function itself.

sourcecode pointer:

https://opengrok.libreoffice.org/xref/core/basic/source/runtime/methods1.cxx?r=0505a00a#253
https://opengrok.libreoffice.org/xref/core/include/basic/sbxvar.hxx?r=60ac2acd#146
https://opengrok.libreoffice.org/xref/core/basic/source/sbx/sbxvalue.cxx?r=35e471bb#356
https://opengrok.libreoffice.org/xref/core/basic/source/sbx/sbxvalue.cxx?r=35e471bb#267
https://opengrok.libreoffice.org/xref/core/basic/source/sbx/sbxvalue.cxx?r=35e471bb#299
https://opengrok.libreoffice.org/xref/core/basic/source/sbx/sbxcurr.cxx?r=7ddedd25&fi=ImpGetCurrency#269
https://opengrok.libreoffice.org/xref/core/basic/source/sbx/sbxcurr.cxx?r=7ddedd25&fi=ImpGetCurrency#88

[just for comparison]

https://opengrok.libreoffice.org/xref/core/basic/source/sbx/sbxdate.cxx?r=0505a00a#97

Imho, it is clearly a malfunction of the ccur-function, since all of the conversion are hard coded and not locale dependent: https://opengrok.libreoffice.org/xref/core/basic/source/sbx/sbxcurr.cxx?r=7ddedd25&fi=ImpGetCurrency#88

Tested with MS-Excel using a German locale, where the group separator is "." and the decimal separator is "," respectively:

MsgBox CCur("75,50 €") ' 75.5
MsgBox CCur("75.50 €") ' 7550
MsgBox CCur("75,50") ' 75.5
MsgBox CCur("75.50") ' 7550

Same examples in LO using a German locale:

MsgBox CCur("75,50 €") ' Illegal value or data type. Wrong data type.
MsgBox CCur("75.50 €") ' Illegal value or data type. Wrong data type.
MsgBox CCur("75,50") ' 7550.0000
MsgBox CCur("75.50") ' 75.5000

Code pointer: SvNumberFormatter::IsNumberFormat is used to convert strings to numbers.

FTR, regarding VBA's CCur locale dependence:

VBA CCur documentation [1] tells:

> You should use the data-type conversion functions instead of Val to provide
> internationally aware conversions from one data type to another. For example,
> when you use CCur, different decimal separators, different thousand separators,
> and various currency options are properly recognized depending on the locale
> setting of your computer.

So indeed CCur is documented to take locale into account when converting strings.

[1] https://docs.microsoft.com/en-us/office/vba/language/concepts/getting-started/type-conversion-functions

Hi! I would like to work on this issue.

If possible can someone tell me how to generate the error ( how to change the locale to german) 
Thanks!

”If possible can someone tell me how to generate the error ( how to change the locale to german)”

I think it depends on your operating system.

(In reply to Arpit Bandejiya from comment #14)
> If possible can someone tell me how to generate the error ( how to change
> the locale to german) 

At least on Linux, you can first generate the German locale https://wiki.archlinux.org/index.php/Locale

So in /etc/locale.gen you want to uncomment the line with de_DE.UTF-8 UTF-8 and generate with locale-gen

Then you can launch LibreOffice from the command line with

LC_ALL=de_DE.UTF-8 libreoffice

(or point to where your soffice is in case of self-built version)

(In reply to Johnny Rosenberg from comment #15)
> ”If possible can someone tell me how to generate the error ( how to change
> the locale to german)”
> 
> I think it depends on your operating system.

I have debian based Linux system

(In reply to Buovjaga from comment #16)
> (In reply to Arpit Bandejiya from comment #14)
> > If possible can someone tell me how to generate the error ( how to change
> > the locale to german) 
> 
> At least on Linux, you can first generate the German locale
> https://wiki.archlinux.org/index.php/Locale
> 
> So in /etc/locale.gen you want to uncomment the line with de_DE.UTF-8 UTF-8
> and generate with locale-gen
> 
> Then you can launch LibreOffice from the command line with
> 
> LC_ALL=de_DE.UTF-8 libreoffice
> 
> (or point to where your soffice is in case of self-built version)

Sure will look into it...

Hi, I looked into the issue, the ImpStringToCurrency is hard coded which is causing the issue, as per now I think it is there for only for one standard. If possible can I get some references where a more generic string parser is written or to the struct or library I should use to handle this problem. Thanks! 

Link for the ImpStringToCurrency
https://opengrok.libreoffice.org/xref/core/basic/source/sbx/sbxcurr.cxx?r=7ddedd25&fi=ImpGetCurrency#88

You may start with the number formatter:

LanguageType eLangType = Application::GetSettings().GetLanguageTag().getLanguageType();
std::shared_ptr<SvNumberFormatter> pNumberFormatter =
    std::make_shared<SvNumberFormatter>( comphelper::getProcessComponentContext(), eLangType );

double fResult = 0;
sal_uInt32 nIndex = pNumberFormatter->GetStandardIndex( eLangType );
bool bSuccess = pNumberFormatter->IsNumberFormat( rStr, nIndex, fResult );
if ( bSuccess )
{
    SvNumFormatType nType = pNumberFormatter->GetType( nIndex );
    bSuccess = nType & SvNumFormatType::CURRENCY || nType & SvNumFormatType::NUMBER;
}

Hi, sorry for the late response got some unpredicted work. Thanks for the help earlier.

Can someone help me with how to find the library to get the class in the file. As in our case, we need SvNumberFormatter, SvNumFormatType, Application, and LanguageType as of now, I figured that most of the files in which there is a call to the LanguageType had the following header included:
      #include <vcl/settings.hxx>  though it didn't work

later I figured that #include <i18nlangtag/lang.h> is the main header for the LanguageType. Is there a general way to find the header? or Is it by exploration only? Please do let me know. Sry for asking a basic doubt, I'm fairly new to the code base so I'm not much aware of it.

Thanks!

Also if there is any other communication method in the Org please do let me know.. any mailing list or any other medium to get generally asked questioned resolved. It will be of great help.

(In reply to Arpit Bandejiya from comment #22)
> Also if there is any other communication method in the Org please do let me
> know.. any mailing list or any other medium to get generally asked
> questioned resolved. It will be of great help.

https://wiki.documentfoundation.org/Development/Mailing_List
https://wiki.documentfoundation.org/Website/IRC

Jonathan Clark committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/9cc8457abcae57c7f9de6e0fbca1fbc2a0cc9892

tdf#128122 Updated BASIC CCur to reuse SvNumberFormatter

It will be available in 24.8.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

@Jonathan: Thanks for the patch!

The change works correctly for some locales, but not all. Specifically, it does not work for some RTL/CTL languages, as described here:

The changed worked correctly with Germany (German) locale on Windows 11:

MsgBox CCur("123.456.789,00 €")
MsgBox CCur("-123.456.789,00 €")

This is the version information:

Version: 24.8.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: cee019927fe3beaf20653e1a98beb85147d14aad
CPU threads: 20; OS: Windows 10.0 Build 22621; UI render: Skia/Raster; VCL: win
Locale: de-DE (de_DE); UI: en-US
Calc: CL threaded

I changed the locale to "Persian (Iran)" on Windows 11, the currency symbol for this locale is "ریال" (Rial). These are the two examples (slightly modified Windows examples):

123,456,789/00 ريال
-123,456,789/00 ريال

None of them worked with the similar BASIC code:

MsgBox CCur("123,456,789/00 ريال")
MsgBox CCur("-123,456,789/00 ريال")

In both cases, the "Error" dialog box with the text: "Inadmissible value or data type. Data type mismatch." appears.

This is the version information:

Version: 24.8.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: cee019927fe3beaf20653e1a98beb85147d14aad
CPU threads: 20; OS: Windows 10.0 Build 22621; UI render: Skia/Raster; VCL: win
Locale: fa-IR (fa_IR); UI: en-US
Calc: CL threaded

For "Arabic (Saudi Arabia)" on Windows 11 with the currency symbol "ر.س." (Saudi Rial), these are the two examples provided by Windows:

123,456,789.00 ر.س.‏
-123,456,789.00 ر.س.‏

None of them worked in similar BASIC code:

MsgBox CCur("123,456,789.00 ر.س.‏")
MsgBox CCur("-123,456,789.00 ر.س.‏")

This is the version information:

Version: 24.8.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: cee019927fe3beaf20653e1a98beb85147d14aad
CPU threads: 20; OS: Windows 10.0 Build 22621; UI render: Skia/Raster; VCL: win
Locale: ar-SA (ar_SA); UI: en-US
Calc: CL threaded

You can access these settings on Windows in:

"Control Panel\Clock and Region", then "Region > Change date, time, or number formats > "Additional settings > Currency". Two examples for positive and negative values are visible on the top.

(In reply to Hossein from comment #25)
Bug 73242 is related. It is only expected to do the same as, e.g., Calc when entering currencies.

(In reply to Hossein from comment #25)
> @Jonathan: Thanks for the patch!
> 
> The change works correctly for some locales, but not all. Specifically, it
> does not work for some RTL/CTL languages, as described here:

On Gerrit you asked me to weigh in on this discussion:

I've only investigated the failure you identified for the Iranian Farsi locale (fa_IR.UTF-8). The root cause appears to be that the locale database doesn't agree with the example formats you've given. In particular, the fa_IR.xml file doesn't provide ',' as a thousands separator, '/' as a decimal separator, or 'ريال' as a currency symbol; when I manually tested CCur("﷼123٬456"), however, I got the result I expected. (Bugzilla doesn't seem to handle RTL languages correctly - so to be clear, the string I used was "[CurrencySymbol]123[ThousandSeparator]456", with the relevant characters copied and pasted from fa_IR.xml.)

The locale data for Farsi could be incorrect; I'm not qualified to make that determination. However, SvNumberFormatter/CCur does seem to be working correctly relative to the provided locale data.

If the locale does need to be updated, I feel strongly that this should be tracked as a separate issue. Locale data is a cross-cutting concern with potential user impact. Tracking that work separately would increase visibility in the short term, and make bisect more useful if issues are found later on.

(In reply to Jonathan Clark from comment #27)

You are absolutely correct. The issue that Hossein mentioned in not about CCur, but about general locale handling in LibreOffice.

Please don't forget to mark this bug as fixed. Thank you!

Thanks for the reminder. Marking as fixed.