Bug 128146 - FORMATTING: Page Number field inserts without its proper character style
Summary: FORMATTING: Page Number field inserts without its proper character style
Status: RESOLVED NOTABUG
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
unspecified
Hardware: All All
: medium normal
Assignee: Not Assigned
URL:
Whiteboard:
Keywords: needsUXEval
Depends on:
Blocks: Writer-Styles-Character
  Show dependency treegraph
 
Reported: 2019-10-15 01:25 UTC by John
Modified: 2019-10-24 08:59 UTC (History)
4 users (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description John 2019-10-15 01:25:15 UTC
Description:
The description is very short.

1. Put the mouse in the footer.
2. Click menu > Insert > Page Number. The page number field will be inserted with Default Style character style, instead of Page number character style (expected).

The expected behavior is also described in the wiki:

> The default setting is for it to use the Page Number character style.
> -- https://help.libreoffice.org/Writer/Page_Number_1


Steps to Reproduce:
-

Actual Results:
-

Expected Results:
-


Reproducible: Always


User Profile Reset: Yes



Additional Info:
Comment 1 Dieter 2019-10-17 06:26:30 UTC
(In reply to John from comment #0)

I confirm that behaviour, but let's ask design team, if this is a bug or not sure about it.
 
> The expected behavior is also described in the wiki:
> 
> > The default setting is for it to use the Page Number character style.
> > -- https://help.libreoffice.org/Writer/Page_Number_1

This is outdated. For actual help see https://help.libreoffice.org/6.3/en-US/text/swriter/guide/footer_pagenumber.html?DbPAR=WRITER#bm_id3155624
Comment 2 Heiko Tietze 2019-10-17 10:03:11 UTC
The footer content gets the Footer paragraph style, and I don't see a reason why the character style has to be changed. The Page Number character style is by the way identical to Default. Do we really have to modify the appearance of page numbers in the footer? Wouldn't say so.
Comment 3 John 2019-10-17 14:51:47 UTC
(In reply to Heiko Tietze from comment #2)

> Do we really have to modify the appearance of page numbers in the footer? Wouldn't say so.

I don't mean to change the appearance - I mean to change the applied character style. I.e. the change in the semantics.
Comment 4 QA Administrators 2019-10-18 02:42:08 UTC Comment hidden (obsolete)
Comment 5 Heiko Tietze 2019-10-18 07:16:31 UTC
(In reply to John from comment #3)
> I don't mean to change the appearance - I mean to change the applied
> character style. I.e. the change in the semantics.

Sure, you want to change the Default character style to Page Number. What I mean is when you apply a character style it is done with the intention to modify this part of the paragraph (which has a dedicated style). I don't see any need for that.
Comment 6 John 2019-10-18 13:13:03 UTC
(In reply to Heiko Tietze from comment #5)

> when you apply a character style it is done with the intention to
> modify this part of the paragraph

Well, it is just a different school :-)
Comment 7 John 2019-10-18 13:13:55 UTC
edit: school of thought.
Comment 8 Heiko Tietze 2019-10-21 09:28:30 UTC
(In reply to John from comment #6)
> Well, it is just a different school :-)

So my KISS school would rather remove the obsolete character styles. I vote for WF. Other opinions?
Comment 9 Dieter 2019-10-21 10:35:54 UTC
(In reply to Heiko Tietze from comment #8)
> So my KISS school would rather remove the obsolete character styles. I vote
> for WF. Other opinions?

I must admit, that I don't understand the combination of paragraph style and character style at all. When Iinsert a footnote it has paragraph style "Footnote" and character style "Default Style". Can "Default Style" be understood as "Style defined by paragraph style"? If this is the case I agree we can remove the character style "Footnote". But it also should become more clear, what "Default style" of a character style means.
Comment 10 Heiko Tietze 2019-10-21 12:02:41 UTC
(In reply to Dieter Praas from comment #9)
> I must admit, that I don't understand the combination of paragraph style and
> character style at all. 

The paragraph is all text until the next break. Typically a sematic unit like an idea or a citation. The character style applies to a section of text within the paragraph for example to highlight words.

> Can "Default Style" be understood as "Style defined by paragraph style"? 

Default (character style) means no character style is applied. So it takes all formatting from the paragraph style.

> If this is the case I agree we can remove the character style "Footnote".

It is Page Number - and could also be applied to the actual content in some weird scenarios. But I don't see a reason to keep this as well as several other character styles. OTOH, there is not much need to delete item except usability concerns.
Comment 11 John 2019-10-21 12:12:41 UTC
(In reply to Heiko Tietze from comment #8)

> So my KISS school would rather remove the obsolete character styles. I vote
> for WF. Other opinions?

It seems that there are many other character styles which does not differ from the default one:

* Caption Characters
* Definition
* Drop Caps
* Endnote Characters
* Footnote Characters
* Index Link
* Line Numbering
* Numbering Symbols
Comment 12 Dieter 2019-10-21 12:28:19 UTC
(In reply to Heiko Tietze from comment #10)
> Default (character style) means no character style is applied. So it takes
> all formatting from the paragraph style.

Would be perhaps more clear, if it would be named "Paragraph style" (or something similar). Of course that's out of the scope of this bug report.

> 
> > If this is the case I agree we can remove the character style "Footnote".
> 
> It is Page Number - and could also be applied to the actual content in some
> weird scenarios.

Of course you're right. Sorry for confusion (but I think it might be the same with "Footnote")
Comment 13 John 2019-10-21 14:13:06 UTC
(In reply to Dieter Praas from comment #12)

> Would be perhaps more clear, if it would be named "Paragraph style" (or
> something similar). Of course that's out of the scope of this bug report.

Character style named "Paragraph style"? I don't think this idea is really good :-). Personally, I like the logic of Writer styles - much better then Word.

It seems there are 3 points to think about in the context of this discussion:

1. should "Page number" style be applied automatically?
2. should "Page number" style be removed completely?
2.1. should another character styles (the above-mentioned ones which doesn't have any visual properties) be removed as well.
Comment 14 Thomas Lendo 2019-10-22 20:24:17 UTC
Just my 2 cents: People that don't know how a feature works shouldn't argue for or against it. So if the entire concept of style formatting isn't understood, please don't try to change it. The lack of information may lead to the false direction of decisions.

To the "empty" character styles:
It would be interesting to know why they were added to the list and if they always had no difference to Default character style. I see no sense in having styles that are identical to the default especially because many people complain about too many styles in the sidebar.
Comment 15 Thomas Lendo 2019-10-22 20:43:54 UTC
Some character styles may be used in other features. For example the "Numbering Symbols" character style is used in the "Bullets and Numbering" dialog. If a style will be deleted, we must ensure that such side effects will be detected and solved.
Comment 16 John 2019-10-22 21:35:01 UTC
> It would be interesting to know why they were added to the list
> and if they always had no difference to Default character style.
> I see no sense in having styles that are identical to the default
> especially because many people complain about too many styles in
> the sidebar.

For the sake of justice, I should say that the list of character styles is not very large. I believe, the complaining about "too many styles" ir related to the paragraph styles.
Comment 17 Cor Nouws 2019-10-23 17:56:36 UTC
pls leave as NotABug
It might well be that the mentioned character style is used in certain situations? In any case I would not bother about something that I do not understand right away  but doesn't hurt me either.
Comment 18 Heiko Tietze 2019-10-24 08:59:17 UTC
We talked about this topic in the design meeting. Character styles are usually not applied automatically neither needed for the page number at the footer => NAB.

We also decided to not remove items from the list because the list is not too long and some might be needed. And updating the list to have different types is a laborious task with not much benefit.