Bug 128189 - configure.ac has a couple issues (patch attached)
Summary: configure.ac has a couple issues (patch attached)
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Installation (show other bugs)
Version:
(earliest affected)
6.3.2.2 release
Hardware: All All
: medium normal
Assignee: David L. Craig
URL:
Whiteboard: target:6.4.0
Keywords: patch
Depends on:
Blocks:
 
Reported: 2019-10-17 03:32 UTC by David L. Craig
Modified: 2019-10-18 18:42 UTC (History)
3 users (show)

See Also:
Crash report or crash signature:


Attachments
Patch against configure.ac (3.06 KB, patch)
2019-10-17 03:35 UTC, David L. Craig
Details

Note You need to log in before you can comment on or make changes to this bug.
Description David L. Craig 2019-10-17 03:32:11 UTC
Description:
several test commands use '==' ops where '=' is needed, qmake-qt5 locating code adds a blank to the $PATH string which prevents finding qmake-qt5 if its in the last directory.  These defects are all in configure.ac, and the patch will be attached immediately after filing.

Steps to Reproduce:
1.  Run autogen.sh
2.
3.

Actual Results:
Depends on the system, but can throw test command messages to stderr, fail to find qmake-qt5 when it's actually in the PATH, and possibly other misbehavior.

Expected Results:
No error messages, qmake-qt5 is found if it's in the PATH.


Reproducible: Sometimes


User Profile Reset: No



Additional Info:
Patch to configure.ac attached, works for 6.3.2.2 and 6.3.3.1.
Comment 1 David L. Craig 2019-10-17 03:35:02 UTC
Created attachment 155047 [details]
Patch against configure.ac
Comment 2 Xisco Faulí 2019-10-17 08:23:19 UTC
Hello David,
Thanks for filling this bug.
Could you please submit the patch to gerrit so developers can review it ? < https://wiki.documentfoundation.org/Development/gerrit/SubmitPatch >
Comment 3 Julien Nabet 2019-10-17 08:31:31 UTC
Michael: thought you might be interested in this one since it concerns kde/qt.

David: I didn't see the patch but the first prerequisite is license part. We can't integrate your patch if you don't provide required license statement.
Comment 4 David L. Craig 2019-10-17 21:16:08 UTC
This patch, already attached, is against 1 file, 8 lines, 10 character deletions/replacements.  Do I really need to jump through these hoops?
Comment 5 Julien Nabet 2019-10-17 21:26:08 UTC
(In reply to David L. Craig from comment #4)
> This patch, already attached, is against 1 file, 8 lines, 10 character
> deletions/replacements.  Do I really need to jump through these hoops?

I can understand you don’t want to bother about gerrit account so i may submit the patch myself but IMHO at least you should do the license part since i’ll quote you in the commit.
Comment 6 David L. Craig 2019-10-17 21:38:06 UTC
Sigh.  Very well, in my copious free time--I'll start now (maybe it's more trivial than I'm thinking)...
Comment 7 Julien Nabet 2019-10-17 21:46:00 UTC
it’s just about sending an email to a specific address with:
- a specific subject
- a block of text in object
 details here: see https://wiki.documentfoundation.org/Development/Developers

I’d be quite astonished it takes more than 5 min.
Comment 8 David L. Craig 2019-10-17 21:57:08 UTC
So what is the developer's list email address?
Comment 9 David L. Craig 2019-10-17 21:59:56 UTC
libreoffice@lists.freedesktop.org ?
Comment 10 David L. Craig 2019-10-17 22:07:36 UTC
Okay, I sent it to that list, signed with my PGP-compliant key.  Let me know if you need anything else.
Comment 11 Julien Nabet 2019-10-18 05:04:21 UTC
i give up
Comment 12 Julien Nabet 2019-10-18 05:07:14 UTC
ok I had just read your first reply
Comment 13 David L. Craig 2019-10-18 05:10:39 UTC
Is there a problem?
Comment 14 Julien Nabet 2019-10-18 05:32:40 UTC
I submitted the patch here:
https://gerrit.libreoffice.org/#/c/81005/

Michael: put you in cc as you may have seen.
Comment 15 Michael Weghorn 2019-10-18 06:46:52 UTC
Thanks for your patch, David.
Julien, thanks for submitting it to Gerrit, looks good to me.
Comment 16 Commit Notification 2019-10-18 18:35:49 UTC
Julien Nabet committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/06b01f73a2d0cc5b6a1c86942e28b1ce7b37bd91

tdf#128189: fix couple issues in configure.ac

It will be available in 6.4.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 17 Julien Nabet 2019-10-18 18:42:31 UTC
Let's put this one to FIXED.